From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EC1CC3DA4A for ; Thu, 22 Aug 2024 06:50:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A59780007; Thu, 22 Aug 2024 02:50:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 955946B027C; Thu, 22 Aug 2024 02:50:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81CF280007; Thu, 22 Aug 2024 02:50:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 63CDA6B027B for ; Thu, 22 Aug 2024 02:50:44 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F2DC8C12DD for ; Thu, 22 Aug 2024 06:50:43 +0000 (UTC) X-FDA: 82478958366.27.7581025 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id 49C5D40011 for ; Thu, 22 Aug 2024 06:50:42 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=nwRRN2fL; dmarc=none; spf=none (imf01.hostedemail.com: domain of BATV+dfc8a69a7fb43479e7c6+7669+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dfc8a69a7fb43479e7c6+7669+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724309425; a=rsa-sha256; cv=none; b=RUiZB2gUhkJ8XHZ0qWhf3GkWf5pj0TwPELVbXfK2vK8CsEfn03OV1WW9WSX7X/g0lMbdtu 3SCDN3+G/Ao2MsCJcg9yWkghX7rjliBnbBJca+B0VkFwwvl1/lNNsoCtgtOL0g5ORFKJnx xD4C/aS9ONGzmvCuP2robIeHBNqj1JM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=nwRRN2fL; dmarc=none; spf=none (imf01.hostedemail.com: domain of BATV+dfc8a69a7fb43479e7c6+7669+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dfc8a69a7fb43479e7c6+7669+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724309425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hh3lK7YA6tMyNt0NgMPClW6TkjPTd/Pcc2Kjk9ny2+k=; b=JF11DdyOsXMCXB1XfzIl3UfBPMGFsTRg0HPQeJbXSQSApgJjgn+dF1E+j4v6SqzDOjDZC8 sevf7bMo2DVDhYhyCoRmH9PtB+kTzCsHmGj7wn9JAuQ1QJqcGxIqRsSyJr3tYmnZ9SeQhF YXKehSm2+23xjKZpyfBqMXdVYP33J3M= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Hh3lK7YA6tMyNt0NgMPClW6TkjPTd/Pcc2Kjk9ny2+k=; b=nwRRN2fLTCTe+ngKU1+o3kckPb zTTiHZIsNbmSEnHWnLcQBFTW1gla0Yum+4VDz2yoS+tjovRcVPptiExldtNBBj+MdwqWdw/8fZjJo sB++dNsqczkxj8/VzdyFpedBaqJ3bvnlUFVPFD4YXLBozzzc4Wrb2UbhXmNhvd3V4dfFr9En2OUTA ufaN23HEzOcFKPDxlyR/fGITUGY17pf7VbnaL49UHyduQrl0MyYQRvedpvcFSOc8xHUuU6qqX5dg9 skqMEMcdBMA6chGJY/HTPsGdnsxYpCn7t+qtd2NIJbcxqDP308nhB6pfPvb6gY9OmPZL6FjU0zSFY 2LqQVcBA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh1ea-0000000Bh9n-2pCE; Thu, 22 Aug 2024 06:50:40 +0000 Date: Wed, 21 Aug 2024 23:50:40 -0700 From: Christoph Hellwig To: Pavel Begunkov Cc: io-uring@vger.kernel.org, Jens Axboe , Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 6/7] block: implement async wire write zeroes Message-ID: References: <09c5ef75c04c17ee2fd551da50fc9aae3bfce50a.1724297388.git.asml.silence@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09c5ef75c04c17ee2fd551da50fc9aae3bfce50a.1724297388.git.asml.silence@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 49C5D40011 X-Rspamd-Server: rspam01 X-Stat-Signature: 39y98u8kpg9hrot64qohq9nca1ttx1zu X-HE-Tag: 1724309442-187125 X-HE-Meta: U2FsdGVkX18AXrg7SfJHw/ws9rHQbjHNfLcE4KWWYAuOOJnyOIAXjkhz3YPMBvCHaZoQ9Hg5WwA7jEa3LzI0VXJFWuBix+iKIfrjcgBnyJELWw5HSjY61lOHeINsXf2QUbDOxDQJl7qU9B8L7cVuKwYOztMAFCQXyd3BTVFIHHfXvRg716UXplfP2bDuAdgkZqEDG6H9itMcAGCtjWxq7PcVnhhDBewq55NiLw28z1NLZy4BQtMr9b99fpHICMxfIwlYwcNf+ZDtn1T/UP0K9gBoptSNQuckMTJZcNgc5LvrTPlc3tDyyIdmMZjqiaVoAZtV9LZRK+Tff4+nQEfmH6MwsY+9Qx52ueghoNGxNGunoV22qWOiOIGn+ZTgOrg5lurrBgBhkXudEDgN92XddHwZfHL3Pk33J2/5zKtxVaQKkhTrPlFNzIgkH9LvuLu3iCVJo9/Z4qFSdcFK/11sPv+CjNHZ7DhnNntrTLCIw7Lszg2swhhpRKgKBzeiWDM2XuOW/OWkiwTm/Z/OqAwJoiHD/BfjF/YR7WpgxKdRN57vGcvQ9Ute9idufjQhsPv5l/S8AiGLCzsoVc6K7AJAzoU/mkfiSCm7w1GCj4jq23U/IsvabfpAg4vJ73V1F9LVV8c4sWaR8TzfQ7QPYtc1jYRWYzLS+MWTUaRX+AClzfQhGSYR4R98TMcMf6tSHjzC1zd7Hxq9uRVq9hs9uyOu7smgj47CU4bdJbxTkgiqkIDO3IFZbYTZU6YZof5f3JZHu9ToKZyoQT62IqqmCzSdh5nyOiYa6WssFASa7LAapGn0d3U5S7XVl6xIb9yVkAzWJB0pO5kX8+RT/qysV7e7uVQytR1weifmdJjL5S2oRBttvoGc5sHiW4rDVMtnihz/4c/xXYeVNa+3ZJET1uqFga61Sobtxdj0/Ef0dG4ocCzw1p4PEpPrQT037nBwIMvtJphOnAuVsb3TE+I0tAB zLbssGXY 7BcLXwIub+OOLFoZ+pbkEPc3bFOG8RzK9HUkIwkGs9MoRNYQFgmu6Iwss1vczQVUO0UuMQnA9n9DrSVDXQZVRXPK5l3IKCpFrMztu1wPRVTUKN15WJYArFH29eYZrVCTErCaHMMbqOHWBdmhIFL/m1kDbfO1BWp+q2om1HBEJE4WUzvpI4a2kBac84nuNfMQpQawOJFpodi+hdUWCNz/r2yofApt+hanSyeC6vsrADHB7XvNCCvkD9oPfwbhox+rzkXJClPgG3O5q974Tibt54uRO2MpeFDR9iSU8WNdjatCGcsTWjaehRJIuNL57acKY+mfSd+F6iw7cI53rLxPwliiEK+T82EUN6nj3ALekhDKv6vznnNTGdHderrre//sJ8BXW6aXivpmnLfwWK5j+KOfc8M1z64IfEbKuC/XhXwp/HWv16IRndtljAlSwKVXqQHJ1wFdfkF7SNjUAdDqIZD9Ui1Id8JhCsGRLl2lCPlP5lbMZvnvuMzWL98E3wMEx3BFJsd7LWd0KUfMTfMLNWb3Uww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 04:35:56AM +0100, Pavel Begunkov wrote: > Add another io_uring cmd for block layer implementing asynchronous write > zeroes. It reuses helpers we've added for async discards, and inherits > the code structure as well as all considerations in regards to page > cache races. Most comments from discard apply here as well. > +static int blkdev_queue_cmd(struct io_uring_cmd *cmd, struct block_device *bdev, > + uint64_t start, uint64_t len, sector_t limit, > + blk_opf_t opf) This feels a little over generic as it doesn't just queue any random command. > +static int blkdev_cmd_write_zeroes(struct io_uring_cmd *cmd, > + struct block_device *bdev, > + uint64_t start, uint64_t len, bool nowait) > +{ > + blk_opf_t opf = REQ_OP_WRITE_ZEROES | REQ_NOUNMAP; > + > + if (nowait) > + opf |= REQ_NOWAIT; > + return blkdev_queue_cmd(cmd, bdev, start, len, > + bdev_write_zeroes_sectors(bdev), opf); So no support for fallback to Write of zero page here? That's probably the case where the async offload is needed most. > +struct bio *blk_alloc_write_zeroes_bio(struct block_device *bdev, > + sector_t *sector, sector_t *nr_sects, > + gfp_t gfp_mask); Please keep this in block/blk.h, no need to expose it to the entire kernel.