From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B773C3DA4A for ; Thu, 22 Aug 2024 18:42:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BFD68004C; Thu, 22 Aug 2024 14:42:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26F7080049; Thu, 22 Aug 2024 14:42:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1380E8004C; Thu, 22 Aug 2024 14:42:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E9AF980049 for ; Thu, 22 Aug 2024 14:42:25 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9B0DE1618EF for ; Thu, 22 Aug 2024 18:42:25 +0000 (UTC) X-FDA: 82480751850.12.DB09E43 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 0C71F180011 for ; Thu, 22 Aug 2024 18:42:23 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lBnYwbwI; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724352053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nDXnKMlzLOPb3GpSNnjPH1Hko34txp09ffWMfDxuwp8=; b=fqD7LpEMEfZZ6e8+wvURZHYamW7V2HQpw2sMojQ8S2YbbHoNOJJrFmEYr5nTEVmhJjLLrZ +KTeLpxUlrwUfYb9UdG5KYBWHppA2maZiwMkvLi3Rffv87orWfvWGRruqDb9dVio4wq46+ PN81LV8qZ5NkEPIlb9dApT+pTtryK+I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724352053; a=rsa-sha256; cv=none; b=QJK0Nyz6GaV7Z87pPGPdkPNPvgU9mJByEFzrQhD1IqSHbSGPGVB0aJY6Vtk1bIKXJSixIF HJjR/WmF1HLoaOcbuuQByn7u+X/Rmp02nt/srX1sMez5bgukHjM3vq+PK2RHBhC1X8s9oA m8+yuNFo1MhGUTxgaMbLlhQtt5sX1gI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lBnYwbwI; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nDXnKMlzLOPb3GpSNnjPH1Hko34txp09ffWMfDxuwp8=; b=lBnYwbwIEpmHXZe2vv2gGxfnJV OXswbincFzP4Ay9PV2SG2mV2hJyE52ajgfa5mylHWn4MIZPyzMPyhK7gc7xqKPkPmP5BIhci9Pbt8 7Ih0nZyhEjRpKOHXoqGETHwkIXd9i9z4wMLh5tYptJPWjpxAOEwxEuurDOBi8Tba0FiBRPKHQVwQx PEfaIaheLTR3twTN1Pn8YB61941L+2T22rDMaVEKUWyjL3TTVRoiWR9OHQLmUU8rdvVxJq4gH43gt VAdqhP/yY/it+XusJ+n7hQ7xk+kVtLkYXhlCdQU4z7oMq4iz8zDUjGLFcZg5nV8batRzgaqsomP2+ 4S4j/zvQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1shClI-0000000ApD1-24pk; Thu, 22 Aug 2024 18:42:20 +0000 Date: Thu, 22 Aug 2024 19:42:20 +0100 From: Matthew Wilcox To: Yu Zhao Cc: Andrew Morton , Muchun Song , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable v2 1/3] mm/contig_alloc: support __GFP_COMP Message-ID: References: <20240814035451.773331-1-yuzhao@google.com> <20240814035451.773331-2-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0C71F180011 X-Stat-Signature: 1sj5m4fxgdfamh3896fa73g9d51x9sy9 X-Rspam-User: X-HE-Tag: 1724352143-614301 X-HE-Meta: U2FsdGVkX19k+7endr1zbdaa/GQuOL71s+PmJr7plQZdXXlJK4/XNuHmbD3O3Lf8M1aAXELaigUXJP2h4Rw3gmJSU3TK9IwRev1MiYtlqH0JW9l37SLSW+I40dMKaTZnqJmcz2hJEfSWaT/h9/skitr/8ue58GvaN7rPyfy8/OgvLQolNymDkzqhA8fnHwZeX3riuQVoaeBsuGBavrXbqDigMEN2IX+NJphqKmD7uo67dQSRfgnfieALylEvQHaDAAxK58UJ46IP86l6ljdyzZ4JTnI+LfJfk/ik/XUYfFvXZi7giLrsZNvxTJ/iBv/wPojKxynpJ24EFwlvQWMs16BIN6c75Pai5M61FISmcOvsaI2LgTAdd+vLaWME3I8R4IbSG5NaJeNtU2XsQRdyF0wPzeH5980Uz1XH8lUmHi9/hx1GkBAwUN/SnJMNwhvQtgFCYkzA5DBB07F4tYTUyQMBPOZD02ySn/nl7IlaYjdKNXEwur0AwXqc6rCBWR+qWXmCRcSK7u6oOjZxOpY5E8tpUluxYlknyUqPbMKzXznF04tMPEzfCZfeVzbqIwU2dwIoA4JdSpUaty8vaJOYpRb/Rly9PIlBLhybLNmCLdLw01HiAVMqT687jSJMd42vI/Kl3fA2fD4x0dl0SWr+sAsVj9I3j4+dboXNtEd/0cjkd/LgTLqgkdOw6DB5QY+1JG4s74mt7I7RUxKIxa/BGnLXoO5os82xV4LUoS1myoqB+gJSgzuaHRGSFIVlcmnfnuU495/Cnm3McLGBmI4KTPmaGTyterpbSI+qR4Dzk4k8BiPFZXc9en9MWKQ/6byC5GlEX4+o7EfSHAszSrMQLRzwrTAnQmAZoEB8eVtZd9b5dea2V3cZcoddUi3qF1Fl/C1Y/qcsurnoUN4i7g/Zyv4q9iO3ZZETgVLjoeTKonvngaBeTDw0wQLxM6nNuYzPAj22GzKR8bJKGDRG9C0 OkSMIFa5 4AO8ItzFMPxQm8CKewqFk8IFRI+CVDWpvuS7lQUyfnSJXVSfHUDzn6OIpFKaSSTMSJLEjLAqhh7QNmzzIgBu5X+lqVkFuKIKzzIMljtfQx7kcO3CMZdDVUurwEm2VR/F/EXRQ9f3Hj2gayvNLdCKI3gkaDoqXdx9mAzqG3N+Ax2Jq40OzBPwh1rku79F7kfVzR3t0yeUuf2ZkggqcwP18S3z1mL8nQU5zVbJ47L+tS/U9cPn4959NMSz8Wl4gQXbsquZA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 11:23:04AM -0600, Yu Zhao wrote: > Andrew, could you patch up the line above? This is what it's supposed > to check: > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 59266df56aeb..03ba9563c6db 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -452,7 +452,7 @@ static inline struct folio *folio_alloc_gigantic_noprof(int order, gfp_t gfp, > { > struct page *page; > > - if (WARN_ON(!order || !(gfp | __GFP_COMP))) > + if (WARN_ON(!order || !(gfp & __GFP_COMP))) > return NULL; I don't think we should do this at all. Just this should be enough: gfp |= __GFP_COMP; same as folio_alloc() (or now folio_alloc_noprof()). Do we really caree if somebody tries to allocate a gigantic page with an order of 0? It's weird, but would work, so I don't see the need for the warning. > page = alloc_contig_pages_noprof(1 << order, gfp, nid, node); >