From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 806B6C52D7C for ; Fri, 23 Aug 2024 11:52:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1494480090; Fri, 23 Aug 2024 07:52:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F92C80084; Fri, 23 Aug 2024 07:52:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F02C980090; Fri, 23 Aug 2024 07:52:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D77B480084 for ; Fri, 23 Aug 2024 07:52:36 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 470CEA89BA for ; Fri, 23 Aug 2024 11:52:36 +0000 (UTC) X-FDA: 82483347912.12.04F962F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 1EDCCC0014 for ; Fri, 23 Aug 2024 11:52:33 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=clBokW3K; spf=none (imf22.hostedemail.com: domain of BATV+ff4ea1235fcdd8feb3bf+7670+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ff4ea1235fcdd8feb3bf+7670+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724413913; a=rsa-sha256; cv=none; b=xeKNspmxVzjnCU7YxzbYcIUtcMeAxqFQfqNsZ4RZ0e92IFjch4+mvytGOhvzrN8zlb8vcF XtkEgkLX4XEyid1GC8KcybGIB6CZ6mEpgDJz3M9h0hz8QXRLlkUUlIZ9GA3a2DTFzempqp zmRnvak1LkOAKmXVWWaJ1iqvYlCPiIA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=clBokW3K; spf=none (imf22.hostedemail.com: domain of BATV+ff4ea1235fcdd8feb3bf+7670+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ff4ea1235fcdd8feb3bf+7670+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724413913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M+Hzg1MI+serm3CFml7ogJSnhKAh6iB/HMhTOhekVsQ=; b=l8qQlHky09m9d1Ysz63NqIUB41OY4Q+VvonwENaWcHqUNLZxFX/F1ApBl5uQniQGWdH/tH p3Q8Tu71V2ZQmL+I07nV7pCEGJx+AT4FXXA8c09X7DKEP4V7oFls4n9PC3gPrtAxf/ihRF v7rZFjNk4v6n8nLpmvOOVK9p9+dRH8U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M+Hzg1MI+serm3CFml7ogJSnhKAh6iB/HMhTOhekVsQ=; b=clBokW3Ksos18zF4kfDs0qwiMu cQAmK+/eekYPGhMJ9u2VVe0mUW+WSDFjBowSFjsFwkuatkWwMNlsMJbf80YDd8oT1pPxW1lWDy9fj sv2gd0X9qVosr8o+2vhAXOZH5S9sdQx2EWRzCbpbtmGcx1VeR6MegtXeOLYL4+rfglqdMzCxAKgHY 1SLsqeTMfXXfIBk7OfEX28U1HxvawuvduXMveNboMpDs4YECzx9CtD1KALY8IbvkkwfXl4pd840h+ fmEZtF6NaZkogsjyrjkleh7ck/YVQhee7K6294u70OmDKj+waOAgdyw7hEMgHlf1RXY4dWushmkPb YdQuAc9Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1shSqD-0000000GaR5-2G14; Fri, 23 Aug 2024 11:52:29 +0000 Date: Fri, 23 Aug 2024 04:52:29 -0700 From: Christoph Hellwig To: Pavel Begunkov Cc: Christoph Hellwig , io-uring@vger.kernel.org, Jens Axboe , Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 4/7] block: introduce blk_validate_write() Message-ID: References: <2ef85c782997ad40e923e7640039e0c7795e19da.1724297388.git.asml.silence@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: aqbme351qmb86dqt7e6zh3jci38o8yfj X-Rspamd-Queue-Id: 1EDCCC0014 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724413953-523756 X-HE-Meta: U2FsdGVkX1/xBAS9Bx8PahEVvSv3qKxth3VWD4AS7x43EakY+UoAX1vKR1VSkffmte22y8l83G4sKMpWL6+XA/Hxg3OjypAdWW8+2dd1V7AZWZogFHBtNLRlh07ZHEuSoHYadZe/u02rduKp7C3bVAaZ1bcOtIhGHS0BUooCcNaIyiVNOJoYo2C1BS74XwBwliLmipZvPNRYVbbFPdaxehvfMjKw1F/vLD6BdHOTdGVdWpF1JL/L52hWeAJ3f8wPoMiclGfJ6MYKV7H+fuTEDFPZRCU69n4N6FeyA5aJOlVCx2VgpahrOBLHSonVSTcO347cWlexmTPG9vIyN5YIGRvUGm/0ptwuER+UoxoTE/BHCgiSmUwo2+z8fUnQGw/rT2YOcfbDiedMUbjWJ0T/uSc70zrId1T/MTvBkT9cBMwkVM1Stj+nuW3+irjqsCXTGgVS7hOveWSs1goCB9Bi0QgaF3WupyNgzziuwzViR8elX5rxJl5LxMRtsCfysb8KRJIBZvBzEhmmwk8uexqv2Owxt2COZ2o41owRQ9c1biqzUfVu3sy/UXt61r9SAuCDpFGtXW7zCU7d40cya8yoRrCJjgjDymgRhogjtsLOo8kixaPB1PJyQ3NSJhCbklkgJDl/vuylzwI+RPWCisPDCrrJ76x1jGilZBM8/gqXRJ+6icTEBAjZ48DIXKJ1hLjvpnhmNKRe5YgqQ+lGclpTKYZxibrq8nNfdJ69JCy//mXwhHvvkJllA5/8KrTWRT7fx1w86gu65pTFC9QaD4s28KsSHpXgYkE78GGbTe6s8mgem1EhB2eOHH+8gdDcCUr35TZKD6pBNgzDQxcuisuVkAop+JqgNWNmQbarX2mVSGcLx/q9Pqx73FvR1qjTR4j2yfngcb1qHIZRzhezuYOYcBcNeE3lieqba6e7RQt88A/oEK/Om9Ywy0f017xBFW4Q5jwixDiLvYK0NZK7iQq 1rEuDs18 UI6r9aWruWHGY1cDCRYIigSmmIa6gytXjeQ6dtyJZmAkntD8ZEPeXE91Eg4qijpeaBULNZ9+wuQt6M+cWbGhMx9ZpicCS+5TAR7HSQag9PXfuY7bEqaWdXCJbsDnXO/5V7WxBeym5KWQFPGdmnCUWsGdMwVmrh+Zf3YNqHneTc6MG3QhmSk/rT4z8VfPVcjQbSJaMes3HrHHIB32Keju0vODYoZ0i/mlX4Ho8Qp1QrxmNOqenHXU+ATVOHD/ZA6KAKLZtXO72GZuzMevdblRXaJU3iVB79Pji/BXLCthvd57qGnZMEkdg+CF5CTBHQOdKiRyxgE0Md9iuTnDIQTzU1j9LkLpPXAmlwp4/KBLnkNQYFAWoL3e/qlc5WYmwThPee43f2XecjgZA5YRENJ++tJsMtki0ufp4h/aUu1NOQiPa0Rlz51nFYAWFA+TDdpfTlBzXXuju5O/L1BPMahmeAKbM7kdV5HE6NLeaqoCHyTBIdZw8xSGY8Ep9tcP71D92rN0lCjafPc2VuxOGoSiZ+TTO4lHWa4Gbyy+mUCqUdlNWCpLzhSeL0cR1brxGXIILafck X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 01:36:10PM +0100, Pavel Begunkov wrote: > It's used for other commands in the series, all of them are > semantically "writes", or modifying data operations if that's > better. How would you call it? Some blk_modify_validate_args, > maybe? Maybe just split the writability checks out and rename the rest blk_validate_byte_range, that way the usage is pretty clearly defined. Bonus points for writing a kerneldoc other other comment header explaining it.