From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F05D6C5321D for ; Fri, 23 Aug 2024 20:13:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91136800CD; Fri, 23 Aug 2024 16:13:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89B07800C8; Fri, 23 Aug 2024 16:13:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6ED80800CD; Fri, 23 Aug 2024 16:13:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E9C82800C8 for ; Fri, 23 Aug 2024 16:13:02 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A615EA2343 for ; Fri, 23 Aug 2024 20:13:02 +0000 (UTC) X-FDA: 82484609004.02.A1F66FA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 7B52318001C for ; Fri, 23 Aug 2024 20:13:00 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="c2cL3/nI"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724443871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JsVlpGeKYbg4pM/Q7waOkd0NZPoyLhoXi4BOdIXNLpY=; b=kjoTW6bQSmoFGiWx9GgrD2IpWUSx0C3Vsk4/r+1cbXfpbiOsnSjeTQgJdY/igpbPRGPh0b AB1aaDh0MEzgLLJ49ue1Vm2slLdLVn5103na39ypHJag6aDehJhiLvEmfbR+HQBA7YxfWN pot7K4x+2vpJjDBNC5qtK/hJvRbIz/A= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="c2cL3/nI"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724443871; a=rsa-sha256; cv=none; b=r5PMHpppUhkErRP7ZOneFQ94XB5tMn6VUo1NG3ba8+qX2lkzghcKLQux+35jOL1CQb07gX JHLdwi08Q3AusC54sdNlZVTHngjqiHH0U/sjK3kL+J9bvWz9TFBdH7WWDqzZQVSgmqOeyS 7UbsVoRBklFiNIdhNELCWEJUKbnMU18= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JsVlpGeKYbg4pM/Q7waOkd0NZPoyLhoXi4BOdIXNLpY=; b=c2cL3/nIR787l++dJM5LnaWXeW 5dJMUyI901WBryZBvo6lRG2cxhxydHjFy3QTpizCQwEC/54YFz67jxnF/I5qszT9dqo0dsCCv4bhA dEMDmoaTGmh5pW4lvMOjCT91apPyQE4b24ZkMYKZ/FNipFwrhETEx8OgNkQFTi5jLsCgTVFQ3QDbd FM2OqcrPBsmNW/FsNsoGQn3qZNhtl0oRKzR3YOuY8XFJb2NKoje+ZfRlO+UrdlPKSiBRRywGoWFES NA0RleWtfD87vB2hp7AObXu6t74Rjpsc6agZ6/B/bIYAzbDXZ0pQnzK28mFgU+JbZqvvFGoQCjhP0 r9Y6Rv8Q==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1shaeH-0000000C8f0-18u9; Fri, 23 Aug 2024 20:12:41 +0000 Date: Fri, 23 Aug 2024 21:12:41 +0100 From: Matthew Wilcox To: David Howells Cc: Christian Brauner , Steve French , Pankaj Raghav , Paulo Alcantara , Jeff Layton , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Marc Dionne Subject: Re: [PATCH 1/9] mm: Fix missing folio invalidation calls during truncation Message-ID: References: <20240823200819.532106-1-dhowells@redhat.com> <20240823200819.532106-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240823200819.532106-2-dhowells@redhat.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7B52318001C X-Stat-Signature: mf6aednumywgz7qcei5jteuub3w8r7ta X-Rspam-User: X-HE-Tag: 1724443980-662737 X-HE-Meta: U2FsdGVkX18UEQMO7lGj1YXssCRCTY858kgICoM+rkIOsa2G+AYsqQsPgELi0B1JwPpuVKR8mHVCWUkXRK3rHh16AiQ1AJ4VCTOM5ViSsSMn3b0ROFM84mM1AYB86IRJ5Wi9s38eISu7D6H2/J0DOeaBcaFYJ0n96mQdIx9D8G7IQlqrCUX7RfrlESZSFgc/RXu36nCQ9IKGBN6mXZ1TCmhgZPOfHlbr0D3TfW+Dzogtg5d5gqjyghxN3yhyshpGta39wyZ19oQvWL0tGeQxEv0QF8hjM9zyrmWvVS1W6xrePXBOtN6sYvVLlqY+C4ZakX8kmavV0JyNdPQ+K9u98OUckejYGuFo+GUmjU7ETpTIS3/boJtak9likQ6nDu6s3uMbO/7JBLMz7oFbk0hm5TGw1DjsMuUWB8z6k2U8w0DHNS4FUxps9RhjRV6Uk8+M6Ia4WZVDwyyP/mn1lWevuGTGIolV5dsQbw4QgPHF7MLLoQI02jw6gWH+fXwafvocXUhGEftd9mPR6ZTVW3JyfdvI6X/XbhGvNjeNCgb1Djx7LupqSFXVsSHltKlqJyngFqpgrrKck6kpFxQfnbnp6Hzky68yhR//M+DUDrpx9cXly/n9cmsfDANt1pBuEkZh7yBX66FiNbTUnnvXsVMIyXHArB+6HWN0pgZdBs5I2QF4Af9p9hIv0pKRJNRr4fxg7+1d+Gb7lAzpUtBaprdzeB4HIdiZX7kyHrswvS8uSWmPwm3eWNmX4zyGhnTYlDSZRRnZJS5lfEQ6+zeU6GVYOXKW3HJWLPTyh4sze84GQkB0OODbWbDNHi2w79JNqY4rD4o+ObzsBPPby4HO0isRoz1lyzD1FstpZ8PuqYRTuj1HRqXAjMBlXU3aD0OxDHnFMyiu9zm6hiwkdRXPoefwMsrpOaSCVwAtRluPShJuIiqSKBPLImj2/5jJB0G3mZdPrIOfE2CBOlurJHoxYU4 UoXCijED NmxInRDees1oWYzT+VI1hbMGkfzhC/mfWB69g48Ro0jUaZsyfqVF2bIWPwWZxs72yqi1OuYmBHWQgQdHEU0X2bP6Z3rAQSMFkvNc749q2D5DVLc0vhWqcINYbmE4psQK3pxD5nBt27kq3LijXpQTxuRd6M5Addm4e0/g5SrlAA12yciicnpOCMaHplsVqsGkXp250TpWOHrqMWCJ3Juup/scFto6lpedXRphiGT7NF4M8Wr1q561FqNtVLGeDUqljnY2WCmEs3zXlCCo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 23, 2024 at 09:08:09PM +0100, David Howells wrote: > When AS_RELEASE_ALWAYS is set on a mapping, the ->release_folio() and > ->invalidate_folio() calls should be invoked even if PG_private and > PG_private_2 aren't set. This is used by netfslib to keep track of the > point above which reads can be skipped in favour of just zeroing pagecache > locally. > > There are a couple of places in truncation in which invalidation is only > called when folio_has_private() is true. Fix these to check > folio_needs_release() instead. Reviewed-by: Matthew Wilcox (Oracle) I think we also want to change the folio_has_private() call in mapping_evict_folio() to folio_test_private(). Same for the one in migrate_vma_check_page().