From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3FAC5321D for ; Mon, 26 Aug 2024 07:52:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E25F8D0040; Mon, 26 Aug 2024 03:52:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 292CA8D001C; Mon, 26 Aug 2024 03:52:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15A388D0040; Mon, 26 Aug 2024 03:52:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EC6F38D001C for ; Mon, 26 Aug 2024 03:52:46 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 937C8A913F for ; Mon, 26 Aug 2024 07:52:46 +0000 (UTC) X-FDA: 82493629932.17.474E955 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf22.hostedemail.com (Postfix) with ESMTP id A30BFC0006 for ; Mon, 26 Aug 2024 07:52:44 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=X9e+SViB; spf=pass (imf22.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724658679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0mWpjqvTPtHlK5lheMP9E3P4lBAgBvroCp9x579oAwI=; b=JKhDN8I473sBsZINas4dabLADUS6T2vY17HKZAfT7AWI2OFSqQeIQyDHjw7MqlGkLE0kdl ATintilm6aVxTgYxxKaX+BDQ8RZ4q6wrlOMqDnaYeSL79ZeZj7TocupgVHdsxmypeIfzlo MvYFNn2iZzbyQxh3WHlqknoZkpZTKUw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724658679; a=rsa-sha256; cv=none; b=rzzW6NKWJSEH1iT302TBTqPRc8GEb6Vt2MOP/YMxo9diJXs+yOQn1sPtP5lGdiW3VixmhT wHx2HaoK2cLX3r0UfKRPCFOTowaAyv0zeC/BTgYeSqAHn9e6bF677bHw/LIPolnQd2iECn b5FaPc/IHnwa8i1gbnQy4EnxAluW5NY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=X9e+SViB; spf=pass (imf22.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a867a564911so480370566b.2 for ; Mon, 26 Aug 2024 00:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724658763; x=1725263563; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0mWpjqvTPtHlK5lheMP9E3P4lBAgBvroCp9x579oAwI=; b=X9e+SViBL2Mw7ixx7MJNgQfpxRMphMWArpln7ySTdjzMZvcSiyUU+vEowT7U2c8LN8 Pv6SzVfO+RpyY657sj7UPgbE3YtqAxpycEaI/BcF+/eqW9XH2rJHKnDyuS4fbkDGoxuz 69NkkvCemgvlh19NMP7w+h6ci6RZxRjEq+X0KU0YO1aOKU/FjfdU6Woqjflq7YmFbJLD pZJt8p7L0tjJP1HOApWmu8qLMI5EalVK1wObOAo+58nPZjmzNhHSe5clLTEwwFqJbP0F ninV+FZspNq/+O0hMSvj/DRMbEUUpfFcpTfdAbJ04dqo74odTTabugcCMcjOCrdd7d5I 4F1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724658763; x=1725263563; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0mWpjqvTPtHlK5lheMP9E3P4lBAgBvroCp9x579oAwI=; b=ZoeVJP9+m56UdCLYZPKgkT4GtcOh6tALAh/1s5L9JNmqvGfVRN6p14yfqaU7qdNxDr z0ilLDtvg+zg+9yto5xJY/VkWAnmbqq4SE28AnZCEDQl5fd8idfnUK2MLICBpX46yFwb hslsTJziZu4fOUm743ncCEPvx6gnDY7SqBVhLmxAlow+muPTYID1wrO8w9oxpX7ES/03 zy9/rtKSuPcxpok3JBSpJ95s3QukRT4DRvxb6zKOrTQkSn/0dNXDd6aF9kQpBzWs/Pby g/pgUy/XlAzWT4i1LzYClighmxwea4ayYHV3MOlzMGbIuNAOqj+LHOr7DiI1TLNb4NH7 mlDA== X-Forwarded-Encrypted: i=1; AJvYcCXPJNuaHP3aN5YShRM5dwfceULPSp/S2d9vzca7/uIvaSp9FlnXdsAuJPfLRNxyTrJVLJo+PyHTSg==@kvack.org X-Gm-Message-State: AOJu0Yx0lUEpWS2Dl9sd+VxfVBnlZgB90keUV6gPKgaV8EZHoxhO5wDl X0nRFWsVpy8sdRvDvtvyZmj4IusmluBiIvVLo2vyPmEZW1iduCdNe6dIYjcAAoY= X-Google-Smtp-Source: AGHT+IEzV3jS/6ppHaAZh7jMr6N30qSPi273cP9sOA4SscXrkGrqDWhLVhBKUnQARYOoFbbsvyUckg== X-Received: by 2002:a17:907:7e9e:b0:a80:f6a9:c311 with SMTP id a640c23a62f3a-a86a4e5c7demr677648066b.0.1724658762991; Mon, 26 Aug 2024 00:52:42 -0700 (PDT) Received: from localhost ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f484b29sm624639566b.162.2024.08.26.00.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 00:52:42 -0700 (PDT) Date: Mon, 26 Aug 2024 09:52:42 +0200 From: Michal Hocko To: Uladzislau Rezki Cc: Hailong Liu , Andrew Morton , Barry Song <21cnbao@gmail.com>, Christoph Hellwig , Vlastimil Babka , Tangquan Zheng , stable@vger.kernel.org, Baoquan He , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0 Message-ID: References: <20240808122019.3361-1-hailong.liu@oppo.com> <20240815220709.47f66f200fd0a072777cc348@linux-foundation.org> <20240816091232.fsliktqgza5o5x6t@oppo.com> <20240816114626.jmhqh5ducbk7qeur@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A30BFC0006 X-Stat-Signature: u1uakigta5u8fbg7knz4ht68t85nnxtb X-HE-Tag: 1724658764-22263 X-HE-Meta: U2FsdGVkX1+MWR54MmwpTyOhKJgn7S/+sCySPZSoMdUVU0B6f3dsyMZUnl7BmKtbyGMxp+KmH7On0Kp5WMzLLvFpaM37R+6qnUscsS6Y+7P0BvPQi60P+rf7ZhbMsOXpJsMFmWAKlCU3uKNE/RId2zIIV/qqcCnE9IQ+rofRjEl0B+VkKgP7p9Zlbj4e/CQB/UWVuJL7YgtOkgsRASnBLAxfpXD4Iedki+Q97E0GdAYfLKaq1vBhW3zxc88k8F7pfdmaBF8e5UrNst+6xBA8NhhG3dRDRgZphoUeb5lDGbFMqSOGvJN5itLuXP6iYNOV1LDTX6KoO0ioBbzjNG/NCTgAZWVrl/GYLmZbFVkyMX+Ob3zkJ/caAaprXL/yxVBmaEEXWxCZWLcCMPAmCemiYR0AflmSsJtFY5cIwCv0X6wuueAfrN2ZNmuoKC5e1jlSijAQt5ewff+F0cJLLFpzuDp1o9aZaLM1YG5df0MNHhhv/0hjwFPsG9UzVQF47eqw4KNUfYicRRsx0KwzUseOpd0ftk2CEaF+9xMhOBz3MEwunskdIx4p4eOOvsGivTV7z5mDwcCqHntsuZ2JYdzy07BzrGn2RD4JqJ0uhv2yltTR8keliZt07HUPwsitc3tIVq7iQs5JZARA2qrShG0IBL2kcepYEDvjvgLdbO+65/x3gtnAIYI1PFuCIe+HBLdzlzrQQQ+dleTFouTYTx+e0ihQUM4CDZ+cgMgzz0ftaqdTlpYxWuf1CUDfy0y/Pjk5NPp0tZLAxkeckhUIBaVtuKQfeyC7rHA/GQbjnlD0eAnS8VWqqxgwm5Rje2UefXKLjOiMF6EaqRnBgLvSi6NMg853yqH9u+pJRSpUPfr32eC3bvB0CWRkhcSHmE2faqPUZHJPb1LXfGZNWBhoZXPdB/dwjscuODbYIlILfLkOh524+XWNCs3ufKkLA93bWOKecu4gtuLAAhpBEwdeI79 bylQ1SQl o6dy041lFVZT0XsiVoSEzAN+efQnUgsSSFmqyFJiIpN1Qfe038VO1GPsfRfDXsO7YEnI/6NwGa98/ha+lQlFcXMTpU0lJ4iQZzjn7hXi9MBVgrsZLztmtEFZW68FrRUx5PDZd564eQhM7VDjnZC3VWXFDZw+nKdwXGkMljxsqbjJs61iQ5A9qj4dmJzt5Wd8k1MZfo2XjmB2kV3PlyWlRNzVNtJRokMB8uW0BACgiFIGLKfu1E+YEdbTjc79NOeGwub66s/eQXOkRTuA+/33QCkoHNn7x+wM84aQ9C8qF2+fjpR2kxM0SWUaf8oyQ5z6FfKCMJ+UigFDFB/I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 23-08-24 18:42:47, Uladzislau Rezki wrote: [...] > @@ -3666,7 +3655,16 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > set_vm_area_page_order(area, page_shift - PAGE_SHIFT); > page_order = vm_area_page_order(area); > > - area->nr_pages = vm_area_alloc_pages(gfp_mask | __GFP_NOWARN, > + /* > + * Higher order nofail allocations are really expensive and > + * potentially dangerous (pre-mature OOM, disruptive reclaim > + * and compaction etc. > + * > + * Please note, the __vmalloc_node_range_noprof() falls-back > + * to order-0 pages if high-order attempt has been unsuccessful. > + */ > + area->nr_pages = vm_area_alloc_pages(page_order ? > + gfp_mask &= ~__GFP_NOFAIL : gfp_mask | __GFP_NOWARN, > node, page_order, nr_small_pages, area->pages); > > atomic_long_add(area->nr_pages, &nr_vmalloc_pages); > > > Is that aligned with your wish? I am not a great fan of modifying gfp_mask inside the ternary operator like that. It makes the code harder to read. Is there any actual reason to simply drop GFP_NOFAIL unconditionally and rely do the NOFAIL handling for all orders at the same place? Not that I care about this much TBH. It is an improvement to drop all the NOFAIL specifics from vm_area_alloc_pages. -- Michal Hocko SUSE Labs