From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8059BC5321E for ; Mon, 26 Aug 2024 13:06:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3C2B6B0485; Mon, 26 Aug 2024 09:06:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEC486B0486; Mon, 26 Aug 2024 09:06:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDB936B04AB; Mon, 26 Aug 2024 09:06:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C17386B0485 for ; Mon, 26 Aug 2024 09:06:08 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5E66E1C4A23 for ; Mon, 26 Aug 2024 13:06:08 +0000 (UTC) X-FDA: 82494419616.16.83A9413 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id CB29840018 for ; Mon, 26 Aug 2024 13:06:05 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VsA1NmUb; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724677482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2QB2DVJ5QuEWuIZED1pKfGdqrF1gTiaYTV/OyyLy5rc=; b=6aMuxkTlXlhHNO0phCUuKiCPpIQpCTJsCd0XYjoY2KKgs3+E/0wpV2q9FKacDXK1j8AXwG EGwglTDjoKujUXLj5n5azininmtX424PoQaoCuGJE6LzL7JbHqd5SmYILm+UmunbD6ulle l5zXORTX/DQaBn4fwvQ8jZfs04jLppA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724677482; a=rsa-sha256; cv=none; b=ylRrVnJTEfXUKAIDQZsOKtuAtYi+qgash3pkLT59J9DckzeCyL1gfisv2HMC83a3gSKDUB DBqADvG8XdUXa6hDjc9gSFTvVnasaBJdHN2m72gFFq8o7V8WRSdXyYA2nyLYtd1Irh+wmG 2QPIHPJsGaXDtMsaaZigWXJDUp1CjPY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VsA1NmUb; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2QB2DVJ5QuEWuIZED1pKfGdqrF1gTiaYTV/OyyLy5rc=; b=VsA1NmUbZ2ob0J/nJJwpc88tt6 IgfxliILWnmRan4go+AB5SlowAw00mLWOjcmJb569DOswA130osGfRqynRe3ZLtHG9rRUIuFnVaLV TIzz4wcvOFWyHjrHP0gnMvNHuK9MlhadicvFy8thnAySn5R1ur47N0784LhBuH6yzhmeYoZDb5EZK z4oxdRbzBqHwIvIsrmjPLXloLocpXFYDLXK3ZODG2zJiYqLQjYnKCZGJh0ZyjyAW/2AB+7lFZvetq 6ncyjUA2L2VRV9Ymx4yTmBTdL/3DozunFrZbc5ePqKNZUqNV0C31KWME9EPNRYyyLINmF+TT8XPMt D0ouC+YQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1siZPr-0000000FQ5O-26Gi; Mon, 26 Aug 2024 13:05:51 +0000 Date: Mon, 26 Aug 2024 14:05:51 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , David Hildenbrand , Baolin Wang , Zi Yan , Alistair Popple , Jonathan Corbet , linux-mm@kvack.org Subject: Re: [PATCH 5/6] mm: remove isolate_lru_page() Message-ID: References: <20240826065814.1336616-1-wangkefeng.wang@huawei.com> <20240826065814.1336616-6-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240826065814.1336616-6-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: CB29840018 X-Stat-Signature: 6jttz9zyfjam1umh7njoitjuyjp5eig9 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724677565-86785 X-HE-Meta: U2FsdGVkX1/XY5EA/tZqGos8RRhfJiTBU8JquOcxglv2OjMYKeJkmsDPxltLphtTFO+vwcGTLMtPrcxI3bkbQzu93okvEh9YcZQzI+I2JuIVTbicAh7QkXP1he6TTbmVCXC66Yz1Ai3L2OWtMhfHLwcK/u7ItVPhQPKY1I8pjHQTLgBRmxyqMKe0Wf7A28bTO005yGMi0c7KzKzjHiFPkXwmBq/s/3eemyyOGWGDhuPKLXQXiqgdFdWS8Faky2QQcwmM0e8HQXWXLksCh0mzRE5/Nx1zvF4pEH/B1tkhnbBs50ullmDCZtUuENiEr5mpuvVyEpWcvpvxFmTTq4k4suvmpULhVLbIC8ERhGvCjXsSjnWNQvoJTaG5G+FwONU5o3ec5Hso/UIhTojirL4sGFFUMGEwtBcCv84BTeyOKRli3udKO3eS1VJIUMxzXa9rLQpB6dgjA5v+nR/BGloLnz6ub2d2oDlq3HXlAPdopDZs3EJCQ7vkjVR33dRrYFHLZx8b178mCa+Fz3A4BkbudfpCRxQzdhr+bmIOnsKntTOooIwKOLkkUiEtCCJyx2RSzzQuJ+TQMPNmRXTt8mShNer6v6IHA13kKKk3gXdebSmH5g1G4jHcNkCSSUMw595Xtunzlg+8GkmrooS9kmMz2zxVlUxppEstakJQldWVpW03mJesDuA8JP+hDwy5OI9KEJtF0ol5roFT7OWcMc1jCL1qBZsjkHQAASq4xlkzIhTwzoGaXHgvtrvDTsejb0UgEiy7u/nCZwrIlJ/PH8TbGbWNXzzRQbu4EbQuOfR+q0O1rBVD9FeiFc0KlkKGMoO2irCEEf8k7ML0HUm0cqsQBeF8mh1XLiCRH+nwsLa+27JV4U2BTjYLJn1jAafxEgKSRlWVlN0K9RVxGALpuCh0rAgApfWed0xMOLi52/ik1TFREINNu98C+XiGhHQiRJbzE/G1epkJKIjC8ALmEoM 4DIVHHfj JKPr3sovTVMXObQni6M9M0YAMQrDbTzbVCaNzjOzi/pOCc9ycikJHr2qNsu4hEU9wp6d/xSo6Y+/7DuZx6p53G0B+PMaP7uzFOqcLzruE8geTUxzorXDDKgTo2hBajKQYdhjc44uC1mYRmzrMaggmS6YER0r9z7Ztq9IfWeyD0jk3fgDhM7wLSvrvaq8TgDBkuyI+m8YMa6GsaK685dDoJvka0WKrsMbc1NGvUqYDn3p94JyreZw5jSaV9EuXvYwl+yZu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 02:58:13PM +0800, Kefeng Wang wrote: > +++ b/Documentation/mm/page_migration.rst > @@ -67,8 +67,8 @@ In kernel use of migrate_pages() > > Lists of pages to be migrated are generated by scanning over > pages and moving them into lists. This is done by > - calling isolate_lru_page(). > - Calling isolate_lru_page() increases the references to the page > + calling folio_isolate_lru(). > + Calling folio_isolate_lru() increases the references to the page s/page/folio/ > @@ -86,7 +86,7 @@ How migrate_pages() works > > migrate_pages() does several passes over its list of pages. A page is moved list of folios. A folio is moved ... (etc) > +++ b/mm/swap.c > @@ -906,7 +906,7 @@ atomic_t lru_disable_count = ATOMIC_INIT(0); > > /* > * lru_cache_disable() needs to be called before we start compiling > - * a list of pages to be migrated using isolate_lru_page(). > + * a list of pages to be migrated using folio_isolate_lru(). a list of folios > * It drains pages on LRU cache and then disable on all cpus until drains folios > * lru_cache_enable is called. > * > -- > 2.27.0 >