From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31406C5321D for ; Mon, 26 Aug 2024 13:27:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B095E6B0083; Mon, 26 Aug 2024 09:27:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB9C16B0085; Mon, 26 Aug 2024 09:27:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95B866B0088; Mon, 26 Aug 2024 09:27:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 770E36B0083 for ; Mon, 26 Aug 2024 09:27:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A43481610F3 for ; Mon, 26 Aug 2024 13:27:34 +0000 (UTC) X-FDA: 82494473628.11.7196BFD Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id CFCF210001C for ; Mon, 26 Aug 2024 13:27:32 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=Wa823DeW; spf=pass (imf05.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724678785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OUCY//gcsGifesZ1olnZEnGellJ2FsUj9xgqUPmJgSw=; b=jvdZ5efh2+xiq4nHuKkEDk/4oLuaORNeNM6GR+6grcQbk2gvYU2qOC/K0j/OROVm04TiO/ eW+1N/o9jHSpS6t5PrnMWm28YZI3OXOlMRjvZLBnXiwou40f3NY/icekdxKZ0amxMLjh1T 2+IPjNberYQgjZ1hypBcofOZUeYJVPA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=Wa823DeW; spf=pass (imf05.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724678785; a=rsa-sha256; cv=none; b=IYjfbo/piWsQEXtwdRaAY5A5AsQbLWy9z+6G/Bvz03eStGxuoa2d2JC4lIS9xtw+aBd6tu A3mTtLbAaSAV9/6FWvORLdjdnEPN9SjQCxd3QA2x8h31Bg8UhOcML/weIJ90dLGVGLMMS1 1xKzKUH2bMHNRvloTzuqjjggk3UgAQE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A6DBAA4281F; Mon, 26 Aug 2024 13:27:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FCF2C581A8; Mon, 26 Aug 2024 13:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1724678254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUCY//gcsGifesZ1olnZEnGellJ2FsUj9xgqUPmJgSw=; b=Wa823DeWZM9H6FLazF9Mr7TU1lpT7Ca2BQGMHRpVMu5+STfZJ5yOG7/csTW2UT9kZ/KBWj m4Pcyxf1F3yWLOjqfmxbtEC+RXdMlDtMhdJ18zwVpt75LqV+IwhUjmTamCySjlInVeSQ2M Z/Qj8HfmknEyBTYjbzrvjxsG25vCJRA= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 7d5cb29d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 26 Aug 2024 13:17:33 +0000 (UTC) Date: Mon, 26 Aug 2024 15:17:32 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Michael Ellerman , Nicholas Piggin , Naveen N Rao , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Vincenzo Frascino , Shuah Khan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom Message-ID: References: <2a081f1fff5e40f496153f8e0162fc7ec5adab2e.1724309198.git.christophe.leroy@csgroup.eu> <7e519ba2-0293-4320-84bf-44f930fc286d@csgroup.eu> <51adbe91-3c3a-4baa-bb39-29df98a6eea5@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <51adbe91-3c3a-4baa-bb39-29df98a6eea5@csgroup.eu> X-Stat-Signature: yhr64fp99ymqy6sm6up8ryn9egzaaou9 X-Rspam-User: X-Rspamd-Queue-Id: CFCF210001C X-Rspamd-Server: rspam02 X-HE-Tag: 1724678852-259826 X-HE-Meta: U2FsdGVkX19YIURQYGkl1zYK9Dwgm7xPhcV4sCnCDSttN3ISxxP1XmKZwcmW9uD8EAbao5WaEvf4GMJLxqYoeFm9XD0ekBGhCckspkw5p+dgg6/z0e6Mw+HtHX7wiRVlU9Uw7rzgvlnN/qO8otO7IDx8oo2HNFSyGZGop0ITwm0XZCgA+izspWTsfcm+uApokhfdIBoopv87ZpXuu06ree3i67Um7HkB1rBqZieLB5hetnQzHf2Vi7SEoSllZhyxmdjUPddMj0b2Ozs/KroJjBSBr64VDc4urShEZBSESj+DjGdkDGPLiZLn4SG4b+Oq6i/NkRyNHrG+hul7rnPzcZ3E/etGEM9qT7LWS1FhoUbqnivWcD+X7U9a7E63evy5L1+h9MyzseXIMCSSGxs6RyQGa5rljKHegDDQXYrnNIPPJYUCqBvAk+hB9wirohvm8OOfPmb7nNf5dBApx1xSCx7yWNFSLcqMmwMPU7Ajr9N0d2Yi81TJsyhccvI/bsMIaLdBVv+pvya/2NRs3Q1v5irK5kkRUAAPrzdSJ3wzu8w5/LDNKw/d1bSaYivBo55YZhZpl/IgnFOjgCEYjOxGrWLrJzHCCVhSrV30LWnrsO5l6I9J7zINA7616QwlK/c3gqw+6hvft1vzVLowmNraiT530v1jOWMRv9YoxMoMIyRijCuwLWOiThMQnZNjGcia5zOzJnUCLBSLSA3MDe7wMMKQi8NsZFRpZ6dS8PydJLCt83Oz35WDkjVc0nAM/gdJg7U9Xj/+ogzjxJMEq6LsMKEK2moPB+AoKofycueF25WNKmf5AMu+wkMbuXOvZAR2KOTVovzWVNwNzbTKucGwpPzmZPZZFConSU2vlJ9rXQ0JdPxEEgJGF2jYmfs6bPqTVp+Ky9HndohFz7NZVzydKm0KGIo/dJaWCmpzoBzw7Ms7wI6bxPztZTlT5jfQJjACleoVQ/48WsBswiGsT2N S3psNQBp tFobMsNWt0bE/R8TH/ZaBNnUGwrdDVihVG+4WvuAtj4lz31PP404XI06dMMkrtx61gJHKowN4OjpgXLSHxETEBI2rRD5X/DP4eZijJTqwRLAcBJebWF5xfpg1gYUZf4j38+z364NZvMZ4QWTQlZKl3/1El9RDMkKnpt5o84KuEHtR/bqQCr69Gwxb3pTKDvmmpgMvDoTQKTcwKcujsvuLddDkkglQRnVN0MYHtutBS2ks10ZgfiJ+vuHZS64LrrUByh6/suLcebcTD0fw45fAtU8Hsgc3yA/fHqC4aVGwDw+IQXKblGr2OxypXxc92NZVVa0OK/pkfs5Vvimda75CW6oku+ffQvyXtyLglJzLgOTjqVw83NooFIojHuOcLAUgdic5m7/V4zsmawJdWB552x7vfVMUHye2FrEHrOKsoKp6BoWAnkSka8pSmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 12:45:40PM +0200, Christophe Leroy wrote: > > > Le 26/08/2024 à 10:58, Jason A. Donenfeld a écrit : > > On Mon, Aug 26, 2024 at 10:37:49AM +0200, Christophe Leroy wrote: > >> > >> > >> Le 26/08/2024 à 10:07, Jason A. Donenfeld a écrit : > >>> On Thu, Aug 22, 2024 at 09:13:10AM +0200, Christophe Leroy wrote: > >>>> > >>>> +#define _PAGE_SIZE (1UL << CONFIG_PAGE_SHIFT) > >>>> +#define _PAGE_MASK (~(_PAGE_SIZE - 1)) > >>> > >>> If PAGE_SIZE isn't defined at this point, why not just call it PAGE_SIZE > >>> instead of _PAGE_SIZE? But if that's the case, why not put the vdso > >>> definition of PAGE_SIZE into some vdso header included by this file? > >> > >> It was working ok on powerpc but on x86 I got: > > > > Seems like there might be some more fiddling to do, then? Or did you > > conclude it's impossible? > > Maybe someone who knows x86 in details could helps but after a first > look I gave up because it looks very x86 specific, indeed that's > x86/asm/vdso/gettimeofday.h that pulls several x86/asm/ headers , and > the same type of issue might arise for any new architecture coming in. > > For me it looked cleaner to just do as commit cffaefd15a8f ("vdso: Use > CONFIG_PAGE_SHIFT in vdso/datapage.h") and not use PAGE_SIZE at all. But > I didn't want to directly use (1UL << CONFIG_PAGE_SHIFT) and (~(1UL << > (CONFIG_PAGE_SHIFT - 1))) in the code directly hence the new macros with > a leading underscore to avoid any conflict with existing macros. If that's the case and you can't sort it out or it's impossible, then it seems like adding #ifndef PAGE_SIZE, #define... inside of some vdso header (not inside getrandom.c) would make sense. Jason