linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.com>
To: Zhongkun He <hezhongkun.hzk@bytedance.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
	roman.gushchin@linux.dev, shakeel.butt@linux.dev,
	muchun.song@linux.dev, lizefan.x@bytedance.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] Add disable_unmap_file arg to memory.reclaim
Date: Thu, 29 Aug 2024 12:23:55 +0200	[thread overview]
Message-ID: <ZtBMO1owCU3XmagV@tiehlicka> (raw)
In-Reply-To: <20240829101918.3454840-1-hezhongkun.hzk@bytedance.com>

On Thu 29-08-24 18:19:16, Zhongkun He wrote:
> This patch proposes augmenting the memory.reclaim interface with a
> disable_unmap_file argument that will skip the mapped pages in
> that reclaim attempt.
> 
> For example:
> 
> echo "2M disable_unmap_file" > /sys/fs/cgroup/test/memory.reclaim
> 
> will perform reclaim on the test cgroup with no mapped file page.
> 
> The memory.reclaim is a useful interface. We can carry out proactive
> memory reclaim in the user space, which can increase the utilization
> rate of memory. 
> 
> In the actual usage scenarios, we found that when there are sufficient
> anonymous pages, mapped file pages with a relatively small proportion
> would still be reclaimed. This is likely to cause an increase in
> refaults and an increase in task delay, because mapped file pages
> usually include important executable codes, data, and shared libraries,
> etc. According to the verified situation, if we can skip this part of
> the memory, the task delay will be reduced.

Do you have examples of workloads where this is demonstrably helps and
cannot be tuned via swappiness?
-- 
Michal Hocko
SUSE Labs


  reply	other threads:[~2024-08-29 10:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29 10:19 [RFC PATCH 0/2] Add disable_unmap_file arg to memory.reclaim Zhongkun He
2024-08-29 10:23 ` Michal Hocko [this message]
2024-08-29 10:37   ` [External] " Zhongkun He
2024-08-29 11:50     ` Michal Hocko
2024-08-29 13:15       ` Zhongkun He
2024-08-29 13:36         ` Michal Hocko
2024-08-29 14:30           ` Zhongkun He
2024-08-29 15:00             ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtBMO1owCU3XmagV@tiehlicka \
    --to=mhocko@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=hezhongkun.hzk@bytedance.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan.x@bytedance.com \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).