From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817F6CA0EDC for ; Fri, 30 Aug 2024 17:38:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 862AD6B00FF; Fri, 30 Aug 2024 13:38:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 812916B014D; Fri, 30 Aug 2024 13:38:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DAE66B015F; Fri, 30 Aug 2024 13:38:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3EAFD6B00FF for ; Fri, 30 Aug 2024 13:38:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ADF741602FB for ; Fri, 30 Aug 2024 17:38:46 +0000 (UTC) X-FDA: 82509621852.28.AC29EF7 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf25.hostedemail.com (Postfix) with ESMTP id 8D86EA0010 for ; Fri, 30 Aug 2024 17:38:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VxiwD7GQ; spf=pass (imf25.hostedemail.com: domain of oliver.upton@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=oliver.upton@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725039479; a=rsa-sha256; cv=none; b=IYvApRPfos37mH6uT+pY4EQfmgAulFlwLb3p/pL11sreBU8WR1C34970xiI6iaARwtQzoZ 4tUClsGc2lwrmPZSJvLD9p9EZBvt2cB34dgryMQgL/+Tg/UGKYRgrCWadrJzr8ytChcxVP SlHnTUiSlbJhEvffpJM/bHXrhqJNnaU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VxiwD7GQ; spf=pass (imf25.hostedemail.com: domain of oliver.upton@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=oliver.upton@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725039479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d6L+KI/2jSnOcw8BblWMkOB9gllIb6gCZOsYWN7xgAE=; b=k0PSS7SBzMnw8GOYKUWvOEUJ7cyU4swBY+AXHucQXOJlIhL5J6qJ7dia56BCU/DOXStRsx 3089URCXVefvTWkr3eH1TPvJIzAlpVE0Dx2k8yjYZ2tcZ3Lkb3NvlG9oruBq26/VK8/s/F lIcDl/KsCw0fGjyffMhFKmIUi0CAnaw= Date: Fri, 30 Aug 2024 10:38:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725039522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d6L+KI/2jSnOcw8BblWMkOB9gllIb6gCZOsYWN7xgAE=; b=VxiwD7GQ9XhGMOI+EnUY1hbVf1hzgYZ5y62ghG8H7NgsCgvXK4O4uAcphI2s+QGcMzw68d UaCmBNo7L8WOVI0SB8xsTf4TWWtvlNsKEr9IyKBJdR3cffMLp9Ra0WD2saR02EGGsiHuqM Gm5puFHjnuYd9wcQ2Fo4PIH+Gvr10zY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: David Matlack Cc: James Houghton , Yu Zhao , Sean Christopherson , Andrew Morton , Paolo Bonzini , Ankit Agrawal , Axel Rasmussen , Catalin Marinas , David Rientjes , James Morse , Jason Gunthorpe , Jonathan Corbet , Marc Zyngier , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Suzuki K Poulose , Wei Xu , Will Deacon , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 03/11] KVM: arm64: Relax locking for kvm_test_age_gfn and kvm_age_gfn Message-ID: References: <20240724011037.3671523-1-jthoughton@google.com> <20240724011037.3671523-4-jthoughton@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 5yncyeocro6zxi9ze1bjupid5ds5r4s5 X-Rspamd-Queue-Id: 8D86EA0010 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725039524-588400 X-HE-Meta: U2FsdGVkX1+lrDxzyJzTs1YitZdsENhJOxripAXxf7tuOwag0OKSOAECbmEDa0cX486V0vhHwarPIpAUGLs35jvezp6vt6q4pQE2YHOo1HV5C49TfIFDevoYfbC/pigPWaZtUhqNehTneOG58lpfvbNeIEepSGtnMn5sZpgYSDPu6z3eyhagG2x+oSq+Wn2AhiY9XSQExvEjbAHy/VCW3og888ebcSJeM4n8742/SbXBxNuFoTwq3OskzS/okE8ZWyYi70GRb4PGMn1xSJMxvwScRyf930MNT4IUdbkbD3QJuf3N1uuhmCITq+Rjr8T/d+MXKB31jkNo50PYdpXzlfl93E9Qjl2UKlGaTqj4bBIy9IKEIPJe4BrZjiob8bwJSKdp6L7Ce61tCdX8yDmXCQeIwocqo0LFgFZiyJ7idCN9iJKY+2fzgY0YEMplWCmRJNxN5ZyUv5YHgtjWRX7yF3V2wh5Nv9ZMdYb9TksqFzP/AXjt8Ozzul/SQ/SbJ6gh0fFmUKxv+2Klwh/n0KbUKv5LhqrPSbPPANW2jVZBZqRP4kxARaIKGpV7NM6/WUdHDJg7pyOreYdRL7t+5WiJ/sV0Om8uX2zIRHiQrI0JH31puRs3DfTLD9jpQ5TpAB3rOIBeBDyg12Z32+sTKemALB892SD6KdW3H1/1jDEBxX62mjS5aqOhpMtcUUGyr2AbReUZ7kXUZEPe+EoMz1l6YzE6DaZfNNwoh75hDvCJTED2a760BME8Y6a1VHS0L1qGfsv3aSCrFw8IqO7Se1+/RxRHZkKhc4ybtvo+KIzXJm1SpE2pcMElggJXpodD9LCBdIqJtBmAcRogngf3xJsVNZh6rn1m14ZrkEXRAb2rfMhNen4V5erfl+smiA9+yJ4cwTOszZhsHJ37BQiDy+PWCOF0Gd6Qa9la0Smj8jwPPikTaW0xEoZxT2xbGDEzeg1PCgdAkUWFjz0euL3Ngc0 Bmf7wTBt UsIL5hgFf1gFKtQ+aNfQ6vSR1UVzxBIUJpdpnkK+bv4ZgNtLUdZZQWQB5fl7850fBtd9Rcx8JbgpikEP42AzEb/qqe8YzZ3jfOXeisq0r4D9twy3eingxgsTSl3VrlttXOyArNCYCaxLZmgZ5Cj5INbt4NV+Q7TWluza+0+KRrhl8gpyjK1H7bRuNtuqQSAnxQsjzhTps5fvxVy2grVw2RI1xdSZWUVJdmdGj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey David, On Fri, Aug 30, 2024 at 08:33:59AM -0700, David Matlack wrote: > On Thu, Aug 29, 2024 at 5:48 PM Oliver Upton wrote: > > > > On Thu, Aug 29, 2024 at 05:33:00PM -0700, James Houghton wrote: > > > On Mon, Aug 19, 2024 at 1:42 PM Oliver Upton wrote: > > > > Asking since you had a setup / data earlier on when you were carrying > > > > the series. Hopefully with supportive data we can get arm64 to opt-in > > > > to HAVE_KVM_MMU_NOTIFIER_YOUNG_FAST_ONLY as well. > > > > > > I'll keep trying some other approaches I can take for getting similar > > > testing that Yu had; it is somewhat difficult for me to reproduce > > > those tests (and it really shouldn't be.... sorry). > > > > No need to apologize. Getting good test hardware for arm64 is a complete > > chore. Sure would love a functional workstation with cores from this > > decade... > > > > > I think it makes most sense for me to drop the arm64 patch for now and > > > re-propose it (or something stronger) alongside enabling aging. Does > > > that sound ok? > > > > I'm a bit disappointed that we haven't gotten forward progress on the > > arm64 patches, but I also recognize this is the direction of travel as > > the x86 patches are shaping up. > > > > So yeah, I'm OK with it, but I'd love to get the arm64 side sorted out > > soon while the context is still fresh. > > Converting the aging notifiers to holding mmu_lock for read seems like > a pure win and minimal churn. Can we keep that patch in v7 (which > depends on the lockless notifier refactor, i.e. is not completely > stand-alone)? We can revisit enabling MGLRU on arm64 in a subsequent > series. Even though the churn is minimal in LOC, locking changes are significant. If one thing has become clear, there are some strong opinions about arm64 participating in MGLRU w/ the read lock. So it is almost guaranteed that these read lock changes will eventually get thrown out in favor of an RCU-protected walker. Then we're stuck with potentially 3 flavors of locking in kernels that people actually use, and dealing with breakage that only affects that intermediate step is gonna be annoying. -- Thanks, Oliver