From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966FDCD13CF for ; Tue, 3 Sep 2024 08:16:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F26438D0147; Tue, 3 Sep 2024 04:16:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED6AF8D0139; Tue, 3 Sep 2024 04:16:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9DF98D0147; Tue, 3 Sep 2024 04:16:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BC5808D0139 for ; Tue, 3 Sep 2024 04:16:32 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 732C0140A36 for ; Tue, 3 Sep 2024 08:16:32 +0000 (UTC) X-FDA: 82522720224.28.253FDBA Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf29.hostedemail.com (Postfix) with ESMTP id 5EE44120016 for ; Tue, 3 Sep 2024 08:16:30 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fyLZ4RQA; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725351285; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ojV6UElN9wXuS/0J1carDitgIkM/X8KA7SapANSlFw8=; b=BQkfpOPjELarvoqvzQOyutewL3l6cD28MdZb7Sd/sJXDpwR9sWnr62uUpYOml4onmzco93 aj9eQHl1UMeoBuIaGjpRRlfIA7/GY+eEN9h0bEJNgQTfeHbxQvQ4Q4jYZHXn9NsqOq0hwk yGCM/k3kotxq6K4+rwjM0/X8b3WAdaQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725351285; a=rsa-sha256; cv=none; b=wy44lw+19UW4NEGb3f9M7nVe4CKYIfr+JBIzig0Q5vkTc8/xQr0SLLipygxA5QNYtj98Gz ndaIvd4CaujCcCDkArOte+pMnnGsK2UtglC8WlVCPdzWGVSvKReTxyihp4gHXdaXqs8+lx JI7YarsYDmWuUJ5n0PXvcXsA3Dw8cD4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fyLZ4RQA; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=mhocko@suse.com Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a8695cc91c8so491350366b.3 for ; Tue, 03 Sep 2024 01:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725351389; x=1725956189; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ojV6UElN9wXuS/0J1carDitgIkM/X8KA7SapANSlFw8=; b=fyLZ4RQASriIGUJkc+JZ6N8tSwN9XIjTT8YtG8Ycsjms//FdjlAJzEXpIdo0hLKATh xLI3RA5ZnymCePWa+GTZTuU500e7uCX9oMHuOVjuzBn8hIpX7V7huD1leyYaL52805NV AZFuShzlyZMzQZgo05Sv6zX74iEsL2acg7yz/bk3/eh8Q3OK+P14/uBPhSO6p88DnyTA /ig/aCdvqJMgTRmsIBa2u4rHtjy3q9hfNrCIgPimZdEYTrC/DImY12VOtf5jjiDv7X4e 4w4brudj2wyspP2c1xQEuorGBEmrBH3+R0DaNtEgN+r3a7sfb2eSWm/7Vdon1BF7fKYB ENDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725351389; x=1725956189; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ojV6UElN9wXuS/0J1carDitgIkM/X8KA7SapANSlFw8=; b=Vikx8OWHgaMLNGMnstQDPOCgt0ybT5Ej3/LmhG1+coImJ/Myv71Kdq6zYbYmFS5Lvi K1ri4ogGKHBX2Fcbaw/PRnA7vh7a0GWZ9AY0RSwcRUuDPy1SoBazc3zoEqt/QclemeQY zRhk5HazHxgyLpf8PvwUiWe0BHk+iQk93NO59Gs7Ua8Eh/e0jpr1lJ/sQ9DPH42ZCUpR LvFDllAOOpKZWB1C8TjGJspgDxbOY8tMPX+Fzyvj1yKZQahC87mcSPXgB/UGULirCxy5 7pbTkIYPTMhOEroxGg5oyKzyjThlpyVu1z5jEOVgIN8y9wfs9nU6iz8Q0V+9d/YLsOWM sINA== X-Forwarded-Encrypted: i=1; AJvYcCWuVslYoyCegwIPGDG68aUmqN/H7+YBQoNORQWRCU3x57un65a+5+04RAcvwh3FSMmqkL9IialEtw==@kvack.org X-Gm-Message-State: AOJu0YwDLRmpuNNAaH1IOrvFifUpSKIs2cAn1L3cQowV60slBtiYDXwU V0AkdfgtKZSY8601trCYk6VDVE0FKJj9ZQMavGBkpka5nCCWtdpspPDxEOadgoLNEHPisfnv8+l 9 X-Google-Smtp-Source: AGHT+IGWsxakA53kfoA6Q+nDGvgrE3zDIwBUGKKTInbMEKE8xdX7CFyQ+Eon3wn1kzgfjsX/YSRYyA== X-Received: by 2002:a17:907:7e8c:b0:a7a:ab1a:2d71 with SMTP id a640c23a62f3a-a897fad365amr1098707966b.59.1725350981532; Tue, 03 Sep 2024 01:09:41 -0700 (PDT) Received: from localhost ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8989196babsm651441966b.100.2024.09.03.01.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 01:09:41 -0700 (PDT) Date: Tue, 3 Sep 2024 10:09:40 +0200 From: Michal Hocko To: mawupeng Cc: ying.huang@intel.com, akpm@linux-foundation.org, mgorman@techsingularity.net, dmaluka@chromium.org, liushixin2@huawei.com, wangkefeng.wang@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm, proc: collect percpu free pages into the free pages Message-ID: References: <20240830014453.3070909-1-mawupeng1@huawei.com> <87a5guh2fb.fsf@yhuang6-desk2.ccr.corp.intel.com> <2ee7cb17-9003-482c-9741-f1f51f61ab4b@huawei.com> <871q22hmga.fsf@yhuang6-desk2.ccr.corp.intel.com> <193da117-30b8-425a-b095-6fd8aca1c987@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <193da117-30b8-425a-b095-6fd8aca1c987@huawei.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5EE44120016 X-Stat-Signature: g1yt71ckeewuwje8zty3dkkrmp1bymmo X-Rspam-User: X-HE-Tag: 1725351390-561086 X-HE-Meta: U2FsdGVkX1/cmD+LAhSuZis5Uginzwo0DPbkzastMeEANZolqKHUHLHsc+ToM7OPvbLd/wtoU0vT+Mg5kHKE3mGs8jZBG9SPFodGT12Un3f+EU8MS5WRJa+HaezE6S0G1Fcu8lmTfyuATGkhnAGlIK7lsox/SaXQRpm3E5EMCJJVwknpV0HA/+56bx6DhN5uX7neJpxZeU6uTDQu95V9bDiMIUaHYVASvYM2Zy5PEws54x1Bt1qUdFKTsSqNfH1Xpindgv9rDfIluJ1jDoZDtbIfAig9fdBOHufAxWwpE7SU4jIN9RTimSzBWtDnTuSEezO00ME4GuOJ80Geny6PhfX2cBF91EWF3UCsS6k/2Bsdw5Dd7fORrL9q2CDV738YdJwM5GXJhSE2YQ1c3XusVRuj1yJL/jQ1ThZs2MyPcrZFPRtb9lfSfiLQDZt5Qlzb3ZUlGnkl2PBu5Lvj1oUZQpKmtgfwwxSiIhAqHkLMzRK4oNTgI1WjYLGK28vs+lyI+TgxA//iJyWtNEcuVjNbEVlr6uNYRObTLUSeojiEAB5oN9rdJ7Y2eJBhjox6BprHNQu4O8OEpZTifY/XKJi+Po1X2+VZZArFJXUgXynmaqxNTKjdLgrAc7yyhs2epLC/+v69NeRPFCjQ+HZCHRay7dQGtF+pVAtTHyLBowJ5O5Pb0zg9iED9n5XimgDwt5FfXCxz1j6xhf5wopOukZGxtnWUWpQLcEUyicWCVxnPnA/hHYq67YSqK9f2GPrpZ3xeZnhw1E+4QBJv+VDGwCkTNEBKIKamn22RidWi6dghKMipm8q/QOvVI5YY3juXeDIzvb7qT/847LntYoKU5ipC3tW2o1MBmh9qDo/4WRcFw3G7RqwLDUionKpviMBaBfcBq/DQOtOFMFYi/qnDMEYQ+fWoUK9/+7sjXktH3gLOwjeI8tSqnbZ475v3Hs87sZivEHGotYIWYlUALqQklBL r/xw0tWp CjoCb6tUHc0mweUYdGvNrLDVw5RmAqKgNf0nZHZVQ9FSA9Ypsf91gLmIPtS5XYuX49C6NUFalY/5QBO3DZ/CqUhBQKTfNJmB2hCuWj+onyfLjBVSJGEx+o2TrS+O8u8uGUdhCkAioXW0F6fKpsEEyoLP6FFooyXLSYcZxetZ6frEBH0OwCNFQmnMmcZw9KhVkp6jZy2wIm01grXVALxf/pjSN/QJPTH7sltr++kHXv4owlMvnDf3ItWvnq0KtlRqG/kPcSEhX74XZYz803m9V214GBSjMjB6xUTps6f0YzjltBkZh7LUaFAZJpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 03-09-24 09:50:48, mawupeng wrote: > > Drain remote PCP may be not that expensive now after commit 4b23a68f9536 > > ("mm/page_alloc: protect PCP lists with a spinlock"). No IPI is needed > > to drain the remote PCP. > > This looks really great, we can think a way to drop pcp before goto slowpath > before swap. We currently drain after first unsuccessful direct reclaim run. Is that insufficient? Should we do a less aggressive draining sooner? Ideally restricted to cpus on the same NUMA node maybe? Do you have any specific workloads that would benefit from this? -- Michal Hocko SUSE Labs