From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5756CA0ED3 for ; Wed, 4 Sep 2024 04:59:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D2728D0225; Wed, 4 Sep 2024 00:59:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 782088D018A; Wed, 4 Sep 2024 00:59:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 623CC8D0225; Wed, 4 Sep 2024 00:59:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 44A698D018A for ; Wed, 4 Sep 2024 00:59:21 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D6BC5C0B34 for ; Wed, 4 Sep 2024 04:59:20 +0000 (UTC) X-FDA: 82525852080.24.9979715 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf03.hostedemail.com (Postfix) with ESMTP id 553FB20009 for ; Wed, 4 Sep 2024 04:59:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sA7pW3yC; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725425883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xD2F+Q70ubrFcYDSnPRU3t0RHpjyIMuXBP1XX2tn2+k=; b=y9AkwOp3nPrWpy3+KrzT5mBmJ8CO7SYq4b1MyBET8/mK3PYjaf75iA/SXRCK3Q1V+/q6Jl jUDJBmDeMcvZqNccUAQHHgbcdmz8rUK3mhIU+gO0PoQVbHn4ipNIHiOyUsW8SDEtIRuh2h 4P4xCmuJFdaF7F3AErsnWsd72c2xyR0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sA7pW3yC; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725425883; a=rsa-sha256; cv=none; b=GUUFpB/VX1fkClWfkgTKpC0WCcqg1awtz86HLPVZSygf84DD+O8+SUd+B8gzseaycrlt9/ PABy/rsGKrEmNC/TbGYQPpJUTKYUcsf+0mzXm0jeKdBa3Q7uHNW4OWCJFGXWbX2VtK4dg7 oxLWe/K2nSHWyQAtVDU6Xy7axk8uKqo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 93926A404B3; Wed, 4 Sep 2024 04:59:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE073C4CEC2; Wed, 4 Sep 2024 04:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725425958; bh=8+GnIVhs2cEaVvWGHlSmiYB3pqH0EWCyi0fO4HvJCgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sA7pW3yC3Gq3w1RC/zQVLwOYDz0qMNK4ZoZZMYDS40Fqi9B66fwyyFa1OFUXP+74B qcZacOC1/KwDhipq3I0Exu8vupYXaNYe0Plc19Nwr4mu0oNucfOsufTDROzPqG7QIV 2slBBzwxEE0uoT29f/6V8OloAocKQ2S1Gzfy6vOOhEBGB9zlm2iWOE6KcbBq0F+IkD sPVdDTbIxccOHyfnsRFcYedXb8qcYYauIRJvH4iWqCXShdHufDnrwl91QeAJrSF5HJ nm0yreYYRi6GtNzLguY36ko6R43opwP3UyrNFHX+lUe/AzjFkr1Ccl/l1mtLMOTgOW 65TxIsNTBW3cg== Date: Wed, 4 Sep 2024 07:56:32 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 05/15] slab: port kmem_cache_create_usercopy() to struct kmem_cache_args Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-5-76f97e9a4560@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903-work-kmem_cache_args-v2-5-76f97e9a4560@kernel.org> X-Stat-Signature: xyxpdtp658nfj3wgceb4exz9wpktgbch X-Rspam-User: X-Rspamd-Queue-Id: 553FB20009 X-Rspamd-Server: rspam02 X-HE-Tag: 1725425959-201410 X-HE-Meta: U2FsdGVkX18ZYWhy58OqVO6meJj+7MoTD6SzGmVAcxsramlmE0A0QnIZytgFJrQaQklx2yjCJoWJkrJ98YZD41Zuu6yHQfYYMCgm8FhNAPTA8yj8M8AFNG+lF32ALf74glMaXkjjreG41mG1ka6O8C/30m+rd4y6APR7MSssI0XfzTjg0HKKTdjd/W3LCxjNxB2n3o9XkRdZxzFHENlS5ISoGGeUrdrQof3dv4dFdLCOmrcKBeFTwsIfrVg/DVkD9qd+1Rpv/hsIj5pojMaTlLKLNFeVw2iT53MWTdNhLtOeWliJhbiBoNPtuKqFygwDJeEf9aftK45Fdr6CYiT6tpEVYK3FK6tARs/5mXcmsqjgjyvXQ1U5kMin6va7NRVFveN/e3NhxWGdJjjnWADZ3MiE0twOFsK98F1kImDsps0YCealPDbHbBDb0QgnjSvTHJgq4GHKyn92xbMumsxLkU3hkrqzVRFxAHbRQh1nFISqM9hwVcbqxVpOFFzTpOctZ1mkq4RNYRPdQEUpQpDGLGl0uoCiNdk5CfJy0uekSuuFXoWlSOwTc61hHeNGLu1cu95kzvwSl1+uedSrQShBMbYxUPKQzHtGqr5ah1R1PgMupVKdkeAgHD3rdWNE5hHvlnWS8SugI1Qzy0uGblVe4NH2Hwc7ZjURumorc2M58gpNLEqHpEXrTQt/CUVQfX/nXgI2nbHGRXF995wqHyCPkIL/SiGJ8RNt45krAWxUe26ietWRhsuXLltuhl4soLqX91yS2VnXKJS4iMqigbNNBEGsRMpd+9/S7ubdi8mswDow8vsGl4bU/25RosJiDZmz4Ht/aGup+KYIf7v3igBSgg1YOIoXL54DtESib9VCci/zfgySuqwYKWNP4IFqw1Y1g7pzFjYc8bIFdmWsGlKhXGopCxSYfCL9MPg61HCx2cWDINzDo1Ym7hrVqgQbhcfEcsRXHNbhcxw0LLRbx95 p+PfFW0L Z6XoXg47GjHdHIMfV1qv0Ds3XhvEVUbKVgHsb+yxb1rPqcaSNfi8EwTrWE6Th1dqYJkWpr+nRD4uND2qT8X/WYFvxH5OiwYEDpiZf+zvgfT+G7/KQvQlwG3alF1LON3tBcMfz8yhIPIOpYX3/jD/2wW39fmO84GVrOmRNlUtaUTdmQwcfQ/suiLbLcqdDjIqvhv8TzwEtyoIeIyoyb2gV1VrS8iLyi/3JUbmvyo3MJxv7JfmBqKfg7aM0e7lFbIGozlUy9VkLQG9i04D1anazenJEo7b94u5DvcaYd3vlUWn0AXLPt6TPt2SQ3Z4Aw4tJwwBx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 04:20:46PM +0200, Christian Brauner wrote: > Pprt kmem_cache_create_usercopy() to struct kmem_cache_args and remove > the now unused do_kmem_cache_create_usercopy() helper. > > Signed-off-by: Christian Brauner Reviewed-by: Mike Rapoport (Microsoft) > --- > mm/slab_common.c | 30 ++++++++---------------------- > 1 file changed, 8 insertions(+), 22 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index da62ed30f95d..16c36a946135 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -351,26 +351,6 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, > } > EXPORT_SYMBOL(__kmem_cache_create_args); > > -static struct kmem_cache * > -do_kmem_cache_create_usercopy(const char *name, > - unsigned int size, unsigned int freeptr_offset, > - unsigned int align, slab_flags_t flags, > - unsigned int useroffset, unsigned int usersize, > - void (*ctor)(void *)) > -{ > - struct kmem_cache_args kmem_args = { > - .align = align, > - .use_freeptr_offset = freeptr_offset != UINT_MAX, > - .freeptr_offset = freeptr_offset, > - .useroffset = useroffset, > - .usersize = usersize, > - .ctor = ctor, > - }; > - > - return __kmem_cache_create_args(name, size, &kmem_args, flags); > -} > - > - > /** > * kmem_cache_create_usercopy - Create a cache with a region suitable > * for copying to userspace > @@ -405,8 +385,14 @@ kmem_cache_create_usercopy(const char *name, unsigned int size, > unsigned int useroffset, unsigned int usersize, > void (*ctor)(void *)) > { > - return do_kmem_cache_create_usercopy(name, size, UINT_MAX, align, flags, > - useroffset, usersize, ctor); > + struct kmem_cache_args kmem_args = { > + .align = align, > + .ctor = ctor, > + .useroffset = useroffset, > + .usersize = usersize, > + }; > + > + return __kmem_cache_create_args(name, size, &kmem_args, flags); > } > EXPORT_SYMBOL(kmem_cache_create_usercopy); > > > -- > 2.45.2 > -- Sincerely yours, Mike.