From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4CFCD37AE for ; Wed, 4 Sep 2024 05:11:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E456C8D0229; Wed, 4 Sep 2024 01:11:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCF718D01E4; Wed, 4 Sep 2024 01:11:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6F8C8D0229; Wed, 4 Sep 2024 01:11:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A788C8D01E4 for ; Wed, 4 Sep 2024 01:11:34 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2BF78A9AA9 for ; Wed, 4 Sep 2024 05:11:34 +0000 (UTC) X-FDA: 82525882908.15.DBBE929 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 8DC7FC000F for ; Wed, 4 Sep 2024 05:11:32 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QaquArHG; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725426615; a=rsa-sha256; cv=none; b=Qpcvn9BdfG+mVbFvcBkGDRVY7VuK5SNsB43P8UZUyPwyq1e0nR90MhIdcPJoHcXnmP+V6M e2W67Xw40ObXGwrIjaYYrziDxElKZ/6z8TEUEMiLcXm0OOvdzO8Rkx4X8ofQj9IDPLkVg6 uBcEpHnoewYc1eCFQ+4DwwNjFfhO+/k= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QaquArHG; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725426615; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OUUs3DSCzI2xHrlF6NeOT4T+vCiMvjDrvPweOm/VNLU=; b=54uiR8RItfujhJ5yxYlgVCKLRgLyiF+mJsg26J1HMkBW+z7P0lANzqBpwA4PllcmAnL7OC zTA2oYh0DQzZ1p0FdA06XTubzHS8JYho5xeda8qqp4nHLk8IDpyS6rUmLrqJANRnhPgIkL ql0+N2CD5RxJ+y3Gkzw4NGKDlGD6MjU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 447ED5C431F; Wed, 4 Sep 2024 05:11:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDC18C4CEC2; Wed, 4 Sep 2024 05:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725426691; bh=zv+d8RqTD8nakbEm5vm6JLfyQuiLsX3JxcK/0vUOVC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QaquArHG4wK8LD6FLAVFXWK2tBgkWzS7vEWGdNJK82THFDZsmdSHP6vKdyTF9o0Tv YxZMBHTP8+IKHxLTUcm3kv7Xt1h38iLCqMMXyKh89DJ9YjYCXvvFfD6IvCE1erjbZC N9DOlbOoN3L7QG8urMxefgIcfWJeMd7Tytb5au0fImEvJO5UTrWnCOtQS4oAN75kQb QzUqCzte0oZi5kg8im1FUFX4bT3s5OUoiHj/EZLs7F9BOp43xj3IzdCPgm8Ta8GwlH +YjR+vmnHaA4RSx2w+zI4pj0OeS75SAh9/gDr9CJMsiYUqzWnrbVJD9MJWvz/PCGWU CCzgeScca72TA== Date: Wed, 4 Sep 2024 08:08:45 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 10/15] slab: port KMEM_CACHE() to struct kmem_cache_args Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-10-76f97e9a4560@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903-work-kmem_cache_args-v2-10-76f97e9a4560@kernel.org> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8DC7FC000F X-Stat-Signature: e6k6g11hs8dpscqxgpicrkf5rte9ckr5 X-Rspam-User: X-HE-Tag: 1725426692-951602 X-HE-Meta: U2FsdGVkX1/AhL1GmJvew0n0FSdNrYzrSlXH18rf/GDpQBIQI3Z4uT4KoZSZMfoPewxNzWbwxjpG2NBBX1OV/IPcg8JmTojkE8GoSvqLq+dGZhfhPSbR+lRa11DhHqgyjfUnFshafR0skbU4zZc1AqfRdoxeoZhL9A7Lh49YkKnYoFvBEoRfCpedH6fjGpWBOOq9SJLJb6pfRjkWHCjISVUyVfi6oHP8VTS+y4pBeEPZc+nQh3Pmw22zucQntwWR5kNap+fFtsn81EivgJInd37VnYukwh3wRXoM67FgVNrrVKm9vHPxlg3MNJDunDlrScxupVwerzPo8rWyQlapjsvFWzsiRJ0gqP41rQGzx3ighFudlLeI+5b19QgvzZcjkkcPwcwzSShjNsfL9qJCL5Pukfzl1oltUDe3UFRqEPkarUdfKzBmXYPVrQ7g+X7CpsoiElzENEkKamXr+BmFSymloLOnsp/Mg1BLtwqRy6aNS1aklkqqWgQibWhrxaRV82g792MW/qJ2lXCio6V64I8/oU9myEuO2JO/Qmse2cNXUDR7U4wS2YogFnUspMugtEmAbUUFhPEIKqFnNx+0VOIjpLYNfIkFKWQhTH+V05XowJT/mQTv9UM+lzKENWLVQ+eUrWRx/AHA7BmSc7d7RBUJ16zDCKRTMzybVMz0kxRhPKP+lFkwgvwG6LgSxACf6317bw6gE8OhuJdkRiF9PFploTNxqRVAXrCaSat0l+n+jEAwLaLufiEj7p0AgGiawURY1t13qDZROBS0sMOZSfYV/n0FLIh7vIxeuerWKNMrBebOVCVXwaGplO3/SH9ebSQTr7Dq4Ss9v2jikv6pkjQ0eT4bl8kE75b/hr58/3/5AaQNpxZof7FTV2tRFHrYb4T15uBbFDQ/iuyJ6LP9VMq5TR2wD1GtAZE6RvhMYWkYG0ZdLoIN3ZRSeZ0LRAhKbcaxkVc5ph40N57wRSY dMzisIyf BvhV1g8YiWolvHikgoKNLjZbSUwtrolyp7FdjW4csN2p51cM/YxzY9aKxeHc70+U2e1UPgFbxd+ERBHuJ1UrQkzSaQ1rOHV+LZ94Kbu5mBnCNhqWu9LfYDThp55/Yn0HLrNqlJmZ8nswjDGr2f0haFxI/yJ2TGByuLnqbu205gLv/Qddbn4GV79M7BIAu1NJ5oS+SyndpkORE43Laj198Aa6eJU9dWhX6zU4NNuVQunlj6kxGP/uppNn8aAwH3fGuLSoqeccZOEiCmaIJ2MWKqczpALzirLhnqe1Z3+K2zBuRN4TAmWxD4PzVKALLU/W1ZMze X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 04:20:51PM +0200, Christian Brauner wrote: > Make KMEM_CACHE() use struct kmem_cache_args. > > Signed-off-by: Christian Brauner Reviewed-by: Mike Rapoport (Microsoft) > --- > include/linux/slab.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 79d8c8bca4a4..d9c2ed5bc02f 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -283,9 +283,12 @@ int kmem_cache_shrink(struct kmem_cache *s); > * f.e. add ____cacheline_aligned_in_smp to the struct declaration > * then the objects will be properly aligned in SMP configurations. > */ > -#define KMEM_CACHE(__struct, __flags) \ > - kmem_cache_create(#__struct, sizeof(struct __struct), \ > - __alignof__(struct __struct), (__flags), NULL) > +#define KMEM_CACHE(__struct, __flags) \ > + __kmem_cache_create_args(#__struct, sizeof(struct __struct), \ > + &(struct kmem_cache_args) { \ > + .align = __alignof__(struct __struct), \ > + .ctor = NULL, \ > + }, (__flags)) > > /* > * To whitelist a single field for copying to/from usercopy, use this > > -- > 2.45.2 > -- Sincerely yours, Mike.