From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBABCA0ED3 for ; Wed, 4 Sep 2024 05:12:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34A7A8D022A; Wed, 4 Sep 2024 01:12:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FB378D01E4; Wed, 4 Sep 2024 01:12:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C2208D022A; Wed, 4 Sep 2024 01:12:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EE7178D01E4 for ; Wed, 4 Sep 2024 01:12:43 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8BF5380D68 for ; Wed, 4 Sep 2024 05:12:43 +0000 (UTC) X-FDA: 82525885806.14.61A66FC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id EC4F21C0010 for ; Wed, 4 Sep 2024 05:12:41 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N8QpU5kZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725426655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1zugeZzMW3JU5p2j8Cj9PFezCvqKmXqH/ST8xSpT1Ik=; b=j51ZknpXeLhhFv4eLDrbeimB1YH6EnIyY1XAaxV3c0AOsIDlQIsNWz0mXv8a8AfXQ/nU9r IBVuhO80AWOAJcQt2biyZ92p6bLWgowvf4j8UuRtvKbh1x9wGwhKGu5nTk5S9aARK5t5EB miB7sQfhIL9hM95rsAjp/eSqDPBdvIE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725426655; a=rsa-sha256; cv=none; b=a+mnvK0lwatV09Eh9u/aE+Z8vNMzq7P0RAOYKkJZ1Q6qLRR1yYeoVe4T14YpWMzlZGTuy4 qlgaabkUPH2WF1pjbpQ98heHzY2Z3PnQKp68EyJDCe/gTt2tS2GYWRJGEkt9WFHt+HXsuf OjMekp47UWFFavXMn15rSgQM3CztQW4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N8QpU5kZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BF0E15C0FE6; Wed, 4 Sep 2024 05:12:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97E5CC4CEC2; Wed, 4 Sep 2024 05:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725426760; bh=GXFWYq12M7jhDfSzBGBOkv4zE3MWpY6bG8JUUY369Po=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N8QpU5kZoR4R4obOW+wGLt1u0bVapKFaaHW/zhK1GP2/yXAtvQYSjSYI3j0hXOfEU SLMsHe6+kKWGj8xu2jT90WpNgf8gnw3gfMYDSLpqi+RnQrBPWJbVVdQKepAdsM2f0X amrPznZE9O2/6jAb3Qj5vaVjfs4fWPMVaA3883ilIeJD99b5sudPDpobgFjDbQRpJq jjDkx1l/AsFGZHC0LHHDyWmDMXcIgRpgDld/nCIzyWGvmu9W0NHS7lTOPKTXSa54FO vwakGWaQS71ZM8yE90jNvvA+84sxZjL8IS++a7EP4SU28bZJvs4CVBiVUBJYmtvneV wMIfwkvnJ0GCQ== Date: Wed, 4 Sep 2024 08:09:55 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 11/15] slab: port KMEM_CACHE_USERCOPY() to struct kmem_cache_args Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-11-76f97e9a4560@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903-work-kmem_cache_args-v2-11-76f97e9a4560@kernel.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EC4F21C0010 X-Stat-Signature: gwtzdngtr3iireea16dwi3p1qxcmentg X-Rspam-User: X-HE-Tag: 1725426761-708938 X-HE-Meta: U2FsdGVkX1/x0XiTUhaEwmpGms0fzI6j7S74wfp9NfhhgdsMb9jWbf3JCthngqk6g+HMBJerM78c0+b1gp2wB9goeJIefBHsf2a19E0tGK8H5f/vEiV6eIMn5tkTHpWKuEtCtzcK6x10RFyMGhz2pyKlP49rP3lG6Um37SsLEGN3zPdH66dnYhxOfJoH7WHlD6Cc5g9sIIl07zh6HaZodONqHLWmAeXgQg6LH0FZumJB0DXBEqUVNhvwUExa0nNqAphAg0cBL2AK8X7xyr09ewcPypEYLZArlgdUHdPTrIpcYbsCX0nGgoxoGUtxkK+oGWEbz4zWH7VEGQkAYwWc/cGlwh5bY5S4a1P451T/1NaHpXQSGQp/xHlmn5/dcTFDIvc8sM1AD0MIYIPiFJ+Iqjo3NzmEUECm8GTJ6/OQc/wYnyZtBERcxGZ72EgT5kzZcodKhfWc5eRhi2Yeh/V4eORlWcFtwx1oHK/A6LFBUvqHnk0K2d78gH/y6Uws9pn3WloXRuQyC7XwwBAZT1ecA8iCWtravDbEKwD5d+M4FLb4CVASe5nIhlKmOnxYCxfQC+4CMBz0VNLnAYvks5JlH/gH2GwGHf+jcTBGEZhPXjsgOqFTWxVEm16TzSqRn1n+dWE7IKqWtrWvnnVvRpDnLbtFrpX94fJ5VW9TBJ44+oAsX/bsMTtQsRGlm5+tvGYUlAAQo/W1Jr6dE6HKYziUceO1uQsVOEuKuVnglFGg2aYN54xB5gbBBWix9WKMbX26oy5U0ywlVeMxRk69tXiM3t+WdOGgYOJVDbnECleu4qxacyzlwkTfqN4V310vRYY/ZIXbFrZG/gukw5egidgCCxu9ZBIMAGeMEXZJg4BJrhed/nlbyKHwCN1Vv1R12zT3uv54yHiDhMe1rLgcSZA3QZPI/VWpiG4I/61bydSWBkFcQSWYyGQbSxtyljIPNHGLyRbWg5n25ICISbe7Ast jPmAv4Xh RC+9Jadcrg/A5OfeyMT6BbKhiW6STWWg+Bmta/+u9hv48BOH18BJcopnuaYJGo0RO4LYJP8/4n28xOwVJYFpbCzrvtCJpqh6rYTaAxiFUngRjZkQwIoL0xG68JdlAgSWttVV8rEpZDi8+TEW42OOSH1or5NPV5zMjYkrz+SA9UMPVSkGW0YSFtKjuK0FUAd+l76QXE+CmqXfXpSIbVNEinZfAx6Z9B8z4MV4L2wLBh94b5/2knbZlxuTMj+tNepzwddPC9keid0+8Dwvs0X6bIZx0RQYTqiUiDvFxNLfN7IcZJlLFSqpMu0OvtzhTi+3ObeL+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 04:20:52PM +0200, Christian Brauner wrote: > Make KMEM_CACHE_USERCOPY() use struct kmem_cache_args. > > Signed-off-by: Christian Brauner Reviewed-by: Mike Rapoport (Microsoft) > --- > include/linux/slab.h | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index d9c2ed5bc02f..aced16a08700 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -294,12 +294,14 @@ int kmem_cache_shrink(struct kmem_cache *s); > * To whitelist a single field for copying to/from usercopy, use this > * macro instead for KMEM_CACHE() above. > */ > -#define KMEM_CACHE_USERCOPY(__struct, __flags, __field) \ > - kmem_cache_create_usercopy(#__struct, \ > - sizeof(struct __struct), \ > - __alignof__(struct __struct), (__flags), \ > - offsetof(struct __struct, __field), \ > - sizeof_field(struct __struct, __field), NULL) > +#define KMEM_CACHE_USERCOPY(__struct, __flags, __field) \ > + __kmem_cache_create_args(#__struct, sizeof(struct __struct), \ > + &(struct kmem_cache_args) { \ > + .align = __alignof__(struct __struct), \ > + .useroffset = offsetof(struct __struct, __field), \ > + .usersize = sizeof_field(struct __struct, __field), \ > + .ctor = NULL, \ > + }, (__flags)) > > /* > * Common kmalloc functions provided by all allocators > > -- > 2.45.2 > -- Sincerely yours, Mike.