From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C796CA0ED3 for ; Wed, 4 Sep 2024 05:17:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAEA48D022B; Wed, 4 Sep 2024 01:17:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D60118D01E4; Wed, 4 Sep 2024 01:17:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C28568D022B; Wed, 4 Sep 2024 01:17:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A3D6E8D01E4 for ; Wed, 4 Sep 2024 01:17:53 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 527D3A0CDE for ; Wed, 4 Sep 2024 05:17:53 +0000 (UTC) X-FDA: 82525898826.17.16FEC19 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id B7F85180016 for ; Wed, 4 Sep 2024 05:17:51 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OSFplgDz; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725426975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pgk1okHBRQa1onu3RC/I4/DBBGvqthNt/NbC0Aio+MQ=; b=gGZjISa6RJEGdNB4NgUwAXRQVamJL+vP0/trm9U0hbT0kpyJ7VypWPs+v6HtFug0z0Y3wz VwkFvXBcYAzPVckREwkBgqS2T3AoVQHjVdfCS74dbEuiy6vXg1mtWJ+EYKfHDkzaT1Z8Pl XeBi+O6qExG+zywUIrj/k7Y9jvDZmeE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725426975; a=rsa-sha256; cv=none; b=HEhNC/kPD7wSOxFmTMiLKfNPzFfp5qIpiQvPIqRMkDJxPpkfpGAQtVGNY+uURw3Aooh55p zPyCNM0uCkJj7+rb/BqLW+yptGEcvMg47O8qa23TMjvAbBoqgYQB4BEW7chwLN3NyTBE1g tOOy1e005lLfA7tu5Q6K5iUbcjyIfbM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OSFplgDz; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 66DA65C3A60; Wed, 4 Sep 2024 05:17:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB46DC4CEC2; Wed, 4 Sep 2024 05:17:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725427070; bh=zeGaL8E1K5vXvWQZ/9ojHDXnsR4kl57ug+P3voJOOVw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OSFplgDzUdiYVeTcX1uJL4RRGLlC9b5huriXpazTQtmzwSmtr/Y8/E8nhdOGfNE8z lY7mVREOHc289hfL0/JZEa1pxzdTKMdkY47K/qsY61MzbctgAuWU3UNtYqsAazLjqs 5f9/6sEa+ozCmVLyiXIo2plVtRaqcaB0aUJu6W1ml3Nxt/eJrCuDe+CfIocqW/Amkw z2A/z2FmWHBesehlygwYn734zuZwKoG5BcO7SiyJaL4zk79X1e9AthtkL0oOEWMI2j 2s/maKENy/WtWOOi0ncpsYWEL22RHNuxvj7ecUZakFtekIoVnzqsU1+C+MPgDy6mfh 3Ere0qASZeXbQ== Date: Wed, 4 Sep 2024 08:15:04 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 13/15] file: port to struct kmem_cache_args Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-13-76f97e9a4560@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903-work-kmem_cache_args-v2-13-76f97e9a4560@kernel.org> X-Stat-Signature: mcga693b9z64gwnst1mdkh78wrna4ynq X-Rspamd-Queue-Id: B7F85180016 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725427071-82778 X-HE-Meta: U2FsdGVkX18vobpg7Q2gmAza54iO1ewrrNomrneVHtVonia0UIwy1neDJctYi3XWdWu3Sbpx9+TZ4TUhhznsbx1+DtsvGeyBZKCxD4JU1ud9n1Hkc4BqXb3+hKRZsbbZwRx5srZQhxsKz636QYc3Uqg023/CcOHNZjz3d78SNiYcIKprWZYW5vz19AB5XC/NgyKRpGVMTlVL4gGZictYyBtZbvgvay4PFUN/yv8nizab7ACgflrzhSdm0Atl0PMHMfTB5vcISlw902dbV8FoXZpSbl7Az9NXZbU67J5TFvYgX/EP59K0SZ4uNZNSaDIARsb2ZjeTSZu7FqIm+WSRu0/8NOTqrmZQrjyDkBxgYA2Ru0sLk4ITzlqOaerKgwe8W3p6iMwX5ktxzUKovPfujQORhOg1u4gbK5wqGBD5gmf8Vd94PR6TJ5POQAmzTumNEDSKo/rnjLy0+voWZkAiJN2OBuxJ1aZfU/m/nD57OxbokLjNBAMX/AtJORWIyPs+ALmpAUU2wsQY5b9GctN/MMdFHNtnG+YxfkOgHvQKHjSv2NCG7DuGwJH7dUkwpfWb/xb2lzGh7jmK4MtuODzSZykhyYhAFKdro7frrIhbCkcbGXvOCocCZoiTRK/wRN2g7frjvowQLfgYIXndOcEVuj0DFT4Y+bOqF/XXKnFcgVL8AiCmTgR1BRiViAe1PaNCaeWsabVoZD2wvQh1cAFPvIvvZlX5nwvyJZGiCG8Nv0NmUjERB5c3ZyO1quq4QYYYRy+2LqW2s5hI82j3cETpjyXY7zJxJTX8rVMOuB4L0buAgDJT7cY+t1LRwBjVYR9u2qhK4rpmS3Mdx9YPM2u7BsGsdrJvgn/qWNawr22wOq9xnQVuhpslF2+dXV4S4j1oBltZXLr005P7NEnTESMdcY9gS5MGeqNv6npQ2/tUKkZLPtCSW9bwFkKVr0VZVvq/89Vm2hNy9MkzFCdT1rM ZvkG+8Cy Tkq7x9bfYJjOdrUyRLIVH+uFGAN76S28TXYGV/KUzUBhrv7IWVgIUzdEIyaVEalmpYXQ9TMmTkiz0OByfmyb1A0Mhzk8XhnZpZyz7NuptCLTnGH6uKtlEjnrW5cN5iOgT9Cza883Q+n13TUoud90AKcZJIPXYVtfJI2jvAawxVqCyqwbsZ/LQfrY3VSJfhairt4aVleaZ1hR/9jtOh1egtymWsUvBCnFWm3bMrG9WiiM9lvNufNKCgrasQEXPtW9p8o5jpKgIEdnQrttsNeO6yhcZeAB6mdSjuN6gnSf/HzBH6aUDy+orik2MQe4SctklsPVI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 04:20:54PM +0200, Christian Brauner wrote: > Port filp_cache to struct kmem_cache_args. > > Signed-off-by: Christian Brauner Reviewed-by: Mike Rapoport (Microsoft) > --- > fs/file_table.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/fs/file_table.c b/fs/file_table.c > index 3ef558f27a1c..861c03608e83 100644 > --- a/fs/file_table.c > +++ b/fs/file_table.c > @@ -511,9 +511,14 @@ EXPORT_SYMBOL(__fput_sync); > > void __init files_init(void) > { > - filp_cachep = kmem_cache_create_rcu("filp", sizeof(struct file), > - offsetof(struct file, f_freeptr), > - SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT); > + struct kmem_cache_args args = { > + .use_freeptr_offset = true, > + .freeptr_offset = offsetof(struct file, f_freeptr), > + }; > + > + filp_cachep = kmem_cache_create("filp", sizeof(struct file), &args, > + SLAB_HWCACHE_ALIGN | SLAB_PANIC | > + SLAB_ACCOUNT | SLAB_TYPESAFE_BY_RCU); > percpu_counter_init(&nr_files, 0, GFP_KERNEL); > } > > > -- > 2.45.2 > -- Sincerely yours, Mike.