From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4867BCA0ED3 for ; Wed, 4 Sep 2024 05:18:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D12F18D022C; Wed, 4 Sep 2024 01:18:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC38A8D01E4; Wed, 4 Sep 2024 01:18:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8B458D022C; Wed, 4 Sep 2024 01:18:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9AFC78D01E4 for ; Wed, 4 Sep 2024 01:18:12 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 49BB1140C74 for ; Wed, 4 Sep 2024 05:18:12 +0000 (UTC) X-FDA: 82525899624.23.6614121 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id B97ADA000A for ; Wed, 4 Sep 2024 05:18:10 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ooAxCfyj; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725426984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XmhHhaKU1gCZ10ell02WntXOApsDg9WTIrkG6WCWntc=; b=MC/MgjL0oRWz7VlFjw1uq2t4j/aTRzXikFv1DN6a1B7SQVT54EFVyX/hVwuiC2jKEQHu1V BvIODTgRmhaEITSrIK2qV/akU4yMsVUCrEmCd7/a7h/E9WG0Q711RRFvhYFLCsI2KoE0Bu JK4HYRjWnrkCQxMaxgwv98d2rKfAC9k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725426984; a=rsa-sha256; cv=none; b=w2ErdYBTcPhREf+/NAPnP81juefA7kltcEDP30189yectoGTN8djNtRwIwCrI7OQ3Shisk 6Vw/S6b/fqOFub2vfopq54hLgfzPdMhAKYGKWKqvug1mpZhkcv4BJRlaYYuZ/IdxCFsXBx 80dSDwVgwXOhjnVYjPR/CA+cWoqjxKM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ooAxCfyj; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id EEE73A406A3; Wed, 4 Sep 2024 05:18:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C5BCC4CEC2; Wed, 4 Sep 2024 05:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725427089; bh=Dz13rylvhrRPpHk9Sl6YRWeBjANz4ja7bmi9tj6+Jnk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ooAxCfyjE1CwmZ4uQnvj1dwiuK4wSFxniELKr5aWObC+Dbup1Mp+x2uQ0kT/azhNp EL5OvmtlrdStG7PUdWwk1ljAFOs+laTPG9LT/46at9es9Y7eC9lrgQDTvO0RecgM2j 06F+vBx5hNsfBO+S8e23Vn7skAPIHabntFxjR79VZAabFvoQPTgZJ6vDGyHtlunQKn /cVFF5LRPUY7njTUcapi0f7w/PZvQLQYugaE4wNQ8GH7XJ9JeYJOAHqs2ZbXHqq5+L AB0EnB2gkRKIGlV1FD8kct0V3YnAVdNcalMqA+PY1bJJGU46cfYuo6jFDcyCSpKMS1 pQdi4bRHk7Rag== Date: Wed, 4 Sep 2024 08:15:23 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 14/15] slab: remove kmem_cache_create_rcu() Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-14-76f97e9a4560@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903-work-kmem_cache_args-v2-14-76f97e9a4560@kernel.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B97ADA000A X-Stat-Signature: tw3k41e7eohxnwne3rk976854fdjafxb X-Rspam-User: X-HE-Tag: 1725427090-222314 X-HE-Meta: U2FsdGVkX18FU9w7WHjeTATrJzb7W29Mt1D2beTtsVrDs+NCE8yYvBNTRI4guN4MWIigf4nVXortLUa7YQikMRoDKsMQ/HY04vY4nlGY5X+YIdibw9YpPV6NoRAqu0ZXNeom0LPTfSgw943ySdpAOKJHYgbkVKfGNVQuiEGHt1H6FyEZAn3rMMV6mSD7EfyN6mAy4Ah5Vu5lPgORbdHTc76ZfkPUPNNGLZVZMZ7Eu5hc28DMELpcwxH0yryCAbad5BT6zi4LU8kY0Jao01CXe2qHYjtIcGGpnMmS2FQOzEBcOimAdUi8tKoXK6Xix5ynff+0D66Te+Dfq53HnKNGbu+ND8+bOXNNNGjuVS1EO7wRW7KiOvRH8aJUrxYA29LQO6IL7wEUjj/wQoHLCkiOP2dO5cSM67f8b1QCIpTI75c95a1FBCyYBTaMuCaaY7YIpRa4Xp/SO+biYTMsgqUqTq4XW/A/e3N9O9dcbzbdPmfh6rQems3SoBuJLzPeq3i2et8aOT9+d0L/7eGjihT95rZxAdugVgzhen7nghNdJ3i7y+MJOGGTOkG7HKyF5bh4AflVItHMiGzHTbvkP5K7UpmP7/fxKasRW2xnp2CkffavZ4fbdBLGsu0O37DMx5xWr9/L5aWpFOb8rV/bUCvXd75WHo59Vwk6WAbSjsjMnNXWq0i+LyUYH6weRUjLCe+E3P/Tc09MiQ3NIr8Qxea1ZQXSDElS11oCNjF88PGFm9XE0i7mQfpzwV/GVeFJzng5vtIAKIPjCpPj7DVMm4eohBnj/c4d9j9ynHIHck5BXvfDo84qUH9O1yjQlTgGSy8pyh1A3R+L9xnC+dqJqeYZ9ALZxzA0fhD0ZWhdG2LbubkdJowWDXk0Qt5AiwbZkPxKVep9f5F0alz6Vy0mbUjfcxazQKIumaaK6iKoSq/k1P6m+3lznqTZDzTX+918A5qEX0IjvxO7YoNsqrc7XPo SRmTgK23 DUwnX2RN36IkS2YtqmCbbGaeOto2wfdi3Js0Dgx0FqJgr28+IkpCBTIj2lZySa50cpocMahAboC0M2hzfBWc76nyUFjHLStZ3K9QtnGbdI0YhWomSrTEKoX9Ws6W5+RFYazE1JEGh6bXXBi1HGz9n2ZhOCViKInzzZAx++DT6WADZXfqRrZ3Et0CCX+kqTjlhWcBuXNrG/POVJILj4JP1cA0GtgN7afy89RiEXSWlojLMtWMP8dvtvilOk/lWfkkFxPAeN2Rx4H2xpZEUF8ryDndZUMeysoBRMnl5ij3EEjaXxVYWQ703Mh/0QJoYxn1hSY0aSAi613Lpd2w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 04:20:55PM +0200, Christian Brauner wrote: > Since we have kmem_cache_setup() and have ported kmem_cache_create_rcu() > users over to it is unused and can be removed. > > Signed-off-by: Christian Brauner Reviewed-by: Mike Rapoport (Microsoft) > --- > include/linux/slab.h | 3 --- > mm/slab_common.c | 43 ------------------------------------------- > 2 files changed, 46 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 4292d67094c3..1176b30cd4b2 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -270,9 +270,6 @@ struct kmem_cache *kmem_cache_create_usercopy(const char *name, > slab_flags_t flags, > unsigned int useroffset, unsigned int usersize, > void (*ctor)(void *)); > -struct kmem_cache *kmem_cache_create_rcu(const char *name, unsigned int size, > - unsigned int freeptr_offset, > - slab_flags_t flags); > > #define kmem_cache_create(__name, __object_size, __args, ...) \ > _Generic((__args), \ > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 418459927670..9133b9fafcb1 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -420,49 +420,6 @@ struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > } > EXPORT_SYMBOL(__kmem_cache_create); > > -/** > - * kmem_cache_create_rcu - Create a SLAB_TYPESAFE_BY_RCU cache. > - * @name: A string which is used in /proc/slabinfo to identify this cache. > - * @size: The size of objects to be created in this cache. > - * @freeptr_offset: The offset into the memory to the free pointer > - * @flags: SLAB flags > - * > - * Cannot be called within an interrupt, but can be interrupted. > - * > - * See kmem_cache_create() for an explanation of possible @flags. > - * > - * By default SLAB_TYPESAFE_BY_RCU caches place the free pointer outside > - * of the object. This might cause the object to grow in size. Callers > - * that have a reason to avoid this can specify a custom free pointer > - * offset in their struct where the free pointer will be placed. > - * > - * Note that placing the free pointer inside the object requires the > - * caller to ensure that no fields are invalidated that are required to > - * guard against object recycling (See SLAB_TYPESAFE_BY_RCU for > - * details.). > - * > - * Using zero as a value for @freeptr_offset is valid. To request no > - * offset UINT_MAX must be specified. > - * > - * Note that @ctor isn't supported with custom free pointers as a @ctor > - * requires an external free pointer. > - * > - * Return: a pointer to the cache on success, NULL on failure. > - */ > -struct kmem_cache *kmem_cache_create_rcu(const char *name, unsigned int size, > - unsigned int freeptr_offset, > - slab_flags_t flags) > -{ > - struct kmem_cache_args kmem_args = { > - .freeptr_offset = freeptr_offset, > - .use_freeptr_offset = true, > - }; > - > - return __kmem_cache_create_args(name, size, &kmem_args, > - flags | SLAB_TYPESAFE_BY_RCU); > -} > -EXPORT_SYMBOL(kmem_cache_create_rcu); > - > static struct kmem_cache *kmem_buckets_cache __ro_after_init; > > /** > > -- > 2.45.2 > -- Sincerely yours, Mike.