From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C500CA0ED3 for ; Wed, 4 Sep 2024 05:17:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E241A6B00B0; Wed, 4 Sep 2024 01:17:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DACF88D01E4; Wed, 4 Sep 2024 01:17:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C261A6B00BD; Wed, 4 Sep 2024 01:17:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A4DF56B00A5 for ; Wed, 4 Sep 2024 01:17:13 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 47CF780C51 for ; Wed, 4 Sep 2024 05:17:13 +0000 (UTC) X-FDA: 82525897146.19.340BE73 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id AB223180003 for ; Wed, 4 Sep 2024 05:17:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QBqC2xVw; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725426984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wiO239IBhvtmsQsdzzxP4QDF5ftyCn7tISAru94fzJE=; b=smX+pkcxZuc+0hNRqIzs5vH/eXIykAkdANKtchoHhxrKWrcGkIPBlVPDWL+1WPLlY2J62e lfPLG3poCP6uon6NRUx6Na8ex/LJ1Ksl2nqd3BkIpiyk9bTQJvM1G1ZVEkhd7vIFm7a38n p6tXOJfqe2wrehs04HgyHshPm5HQ2M8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QBqC2xVw; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725426984; a=rsa-sha256; cv=none; b=bgm7Gv5fsWM2Z+ujXZ/ph33X5I9g8DBR8lrMFzPwFut3spTk4vA3P76a1/UFGZC7qWjy0f cuTalBDT/j5A4dggZM8cwgbQ1oFah/DXTxXyMXco/5gCAjwZmuKuedqw0pqG1423vVErZ5 HLYgKHE9h4Cuz1duEzCrueWAgULaLAs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id CB780A406A3; Wed, 4 Sep 2024 05:17:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30579C4CEC2; Wed, 4 Sep 2024 05:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725427030; bh=UWJ3IrTm1u6boS0Ss1RlAPOifSdksQzwJ9xv5pb3ogM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QBqC2xVw3KIPPtyfNucYAUNIRriQbgEgfAA/Luz+Dq7uKkeVYZQFS2irmIv5oJ8HO iW3jbihcNIVYiaAHrPGOKjeWybXbDuJnMt39dvAgFDjyGXo6kLHMFZgIw5P6afkvaq SSNnLRfxmY3D7YqW4Hk7FsRVVms7lXA9CU1cKvDRaJ9MW9Yghy82H4p2ubz4au9Go0 MsIP5Q6MGqLgGUNp4UPavK5X76gjGzTk+QkAkznUlgwCVcZp9nWjwzCbdDf2qtUT3V 9EF/4XDMrBg8hDpxMRkxXNXejw2prXIXVpvQl8SbG0c2KXWJ8eZECXv3cWCsQ0p5pT I/bgNWRcyck1A== Date: Wed, 4 Sep 2024 08:14:24 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 12/15] slab: create kmem_cache_create() compatibility layer Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-12-76f97e9a4560@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903-work-kmem_cache_args-v2-12-76f97e9a4560@kernel.org> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: AB223180003 X-Stat-Signature: sthntw4uig6ktsofw6cb8hwee51qw9qq X-HE-Tag: 1725427031-723697 X-HE-Meta: U2FsdGVkX19u3pGcWV8zwrB/D8nUJlRRXRwt2JBoX7rpSdO9vUyQmrEcVJ3rxd3GMLUdBcCWlGNihHbpyx++YIqil0CLfhv38QoXLqDqUrLTGoaZIihRkB9oRnBQrOG7/J6mYvZ1aN8ToH7DArSczz8c7T9GO09BxdCCKJJsXPYqlNy6UAfP9CYuIvIH3FjX19SvLDG4P9ZuwEyqvfFbncEv6yWLPLgGN8nLby5COJnd4bFj68PjWAX2uqlBB65CaD8B8JUyZebKbPP+VSP3qrtVo7Ql5j0LJYbg/aX2DN05zg1uxKtFfCHXFUpjsDZ6xkKer88h4Y6SXx1e2sWubMK2rWfV9mS85ypLil/SZFuTLQQWumOx9b7X2KsOYyEqAllGe6Oap5LMeR0UJiWRjQajRdNI+TNX3UvOioWEBNirrhjc23v4xs2j6+TUPoa48R5n5v6iZhd7Wa1BYBxWd0uisdeAcZ2tS2a5mMiQ5KIbRrRPiFiLcxRF1A/uFpMykHxGt0MdStRTjRy/a1eZKWbEc3uBmd2kUN2AHAV0perviNWL9HIkuMFzbnU89EJS/BPGnk8Y1R5WhDC5sJU/pvEAk/6/4b6EwxT06ibJiY6d/IzWYziBx/0JedkXMeciV1MRZofxhc5ast4+ijZnG6tmPLou6mk/sBnV1Poe7GYK3XuKn0pFBSCRtGOWzJ44DzlrqK1E0kGp0TEv2h+zH6HcXgTZKBUn5eAjXs5TVs8AIh67Oc80wlXByUpGX2J1L9V/ybnHnHQ2rj9UefoE7k88+msxnoXAwRhhcWGjbxlw05chPo7RL8x6Hk4WVaS/jPHXgj7lYLLIT+zBeI/KT7r1AfWeDF5q2B9McJwO6QbsdcYdGLF1qko00N04a+SE5FgVB31k1ORgStAwvxHqXSnqi8bfQobJ4/XEa/pFL/QOYf1yQpWrTJXmqZqqaeuWV307jELrWoyVV0dmvDW OOHxAM/l A3p9hV3wIPGyXp9OCcVWpk6MVOXyX9uBhfA/pjcBLigYS4C6mR7JgpJZt/sR49Vyr2LCCXne+vE6B3iD4M4XKqJZmM+HfkNGr738XL/RyrBJ2E9e3K5jgNfAWB2Jld2jdFkxxkyPZCbVeQzWCNdNs8XJi9FGdnnP3b7/73iFjM8CcxWmGulF8lNY//UVzF8Tibw4AQaXfEG+1U1SmBQB0p8CVGlMVlCWrTEbwEYzU4RnGvYuiaOjUcA17q4Wvud1Y0Mb4UvaKvJJeSC860tw2dKU8pVR+ZD7yipvDlygYFHJph3i4AvUGt2AebHpctY8pNCwUYZWw3ZTHFz9d1/Z04ZjofWXc4BxttCpx3yzLWTS9by4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 04:20:53PM +0200, Christian Brauner wrote: > Use _Generic() to create a compatibility layer that type switches on the > third argument to either call __kmem_cache_create() or > __kmem_cache_create_args(). This can be kept in place until all callers > have been ported to struct kmem_cache_args. > > Signed-off-by: Christian Brauner Reviewed-by: Mike Rapoport (Microsoft) > --- > include/linux/slab.h | 13 ++++++++++--- > mm/slab_common.c | 10 +++++----- > 2 files changed, 15 insertions(+), 8 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index aced16a08700..4292d67094c3 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -261,9 +261,10 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, > unsigned int object_size, > struct kmem_cache_args *args, > slab_flags_t flags); > -struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > - unsigned int align, slab_flags_t flags, > - void (*ctor)(void *)); > + > +struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > + unsigned int align, slab_flags_t flags, > + void (*ctor)(void *)); As I said earlier, this can become _kmem_cache_create and __kmem_cache_create_args can be __kmem_cache_create from the beginning. And as a followup cleanup both kmem_cache_create_usercopy() and kmem_cache_create() can be made static inlines. > struct kmem_cache *kmem_cache_create_usercopy(const char *name, > unsigned int size, unsigned int align, > slab_flags_t flags, > @@ -272,6 +273,12 @@ struct kmem_cache *kmem_cache_create_usercopy(const char *name, > struct kmem_cache *kmem_cache_create_rcu(const char *name, unsigned int size, > unsigned int freeptr_offset, > slab_flags_t flags); > + > +#define kmem_cache_create(__name, __object_size, __args, ...) \ > + _Generic((__args), \ > + struct kmem_cache_args *: __kmem_cache_create_args, \ > + default: __kmem_cache_create)(__name, __object_size, __args, __VA_ARGS__) > + > void kmem_cache_destroy(struct kmem_cache *s); > int kmem_cache_shrink(struct kmem_cache *s); > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 19ae3dd6e36f..418459927670 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -383,7 +383,7 @@ kmem_cache_create_usercopy(const char *name, unsigned int size, > EXPORT_SYMBOL(kmem_cache_create_usercopy); > > /** > - * kmem_cache_create - Create a cache. > + * __kmem_cache_create - Create a cache. > * @name: A string which is used in /proc/slabinfo to identify this cache. > * @size: The size of objects to be created in this cache. > * @align: The required alignment for the objects. > @@ -407,9 +407,9 @@ EXPORT_SYMBOL(kmem_cache_create_usercopy); > * > * Return: a pointer to the cache on success, NULL on failure. > */ > -struct kmem_cache * > -kmem_cache_create(const char *name, unsigned int size, unsigned int align, > - slab_flags_t flags, void (*ctor)(void *)) > +struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > + unsigned int align, slab_flags_t flags, > + void (*ctor)(void *)) > { > struct kmem_cache_args kmem_args = { > .align = align, > @@ -418,7 +418,7 @@ kmem_cache_create(const char *name, unsigned int size, unsigned int align, > > return __kmem_cache_create_args(name, size, &kmem_args, flags); > } > -EXPORT_SYMBOL(kmem_cache_create); > +EXPORT_SYMBOL(__kmem_cache_create); > > /** > * kmem_cache_create_rcu - Create a SLAB_TYPESAFE_BY_RCU cache. > > -- > 2.45.2 > -- Sincerely yours, Mike.