From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51DCFCA0ED3 for ; Wed, 4 Sep 2024 05:18:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8A0F6B0096; Wed, 4 Sep 2024 01:18:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D40B18D01E4; Wed, 4 Sep 2024 01:18:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB4276B0184; Wed, 4 Sep 2024 01:18:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9D5C46B0096 for ; Wed, 4 Sep 2024 01:18:58 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 508AA120CB3 for ; Wed, 4 Sep 2024 05:18:58 +0000 (UTC) X-FDA: 82525901556.02.A42D234 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id C5438A0015 for ; Wed, 4 Sep 2024 05:18:56 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s0UuoRft; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725427066; a=rsa-sha256; cv=none; b=2rcXbMX/ag6aFSJhfMJiWwHMgVz5r2WnfvfYVr67+GxEc4HRWA9Z7riJ9cbcy+QjAucNrg jdcwIVSjo8V4ErH5OWWD1I2Hr6GfylpvnnCPwnXjXAEyXpyXBfwcgPKT6sAj24xjorpNgt 7cMk7ShbVgUVk9sIlz83MnaIvlIjXZ0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s0UuoRft; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725427066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EC5KNmfzrMwx7FXbE4uGFCzDMZuNA1CJPta+qJwB4Vw=; b=BAjhQaoVZtb2aNRqF29OY8S1oPvwEDBvDShTNw08E0M5BY/+j1+0I4mbb1h41b/20picki On2pMlXAk1KqQtODe0w55SGrBPlUDE4hh7/D+OtafE2imm72Oj0lxlRr9mXb0kOr2E8pUV pSLsKrymbgafdnf1aG0vznegthZDT+s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 07106A406A0; Wed, 4 Sep 2024 05:18:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36314C4CEC2; Wed, 4 Sep 2024 05:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725427135; bh=oSa5MkUfVUGc4lGYcNLkbNhyI4gxtWrjnDAQ5Dr6a2I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s0UuoRftw6qb1bDtSkV2PDdIJNLfWztU6J7s4OTaJnC+J+5YqXk4gwOP11Qhr3fJY WrfYyZIKanqWQQWZO7Ck+NyKxXye1z7OjVWduMxDugHVb21S8h93xDa6CFEataHSMH afrF4tdWfvlAZyUh+rBcWgxwMggo/2mL5nlbFYT/l0emLjAPEga72vtFpvHLPPtoXV 7n8pKYN8VDkASTToTV2dTpwhU/2ilI3PedRO40a32nNk+XUH0ULmAHEX2EZoB52XY/ 4ZGTiQgPgNps+mQIHUUppVEw1PsSWH3Lv/P4wwVPcoW+8mr7ULMs4ITGh77/2l78WX gmFWWo5VdGOTg== Date: Wed, 4 Sep 2024 08:16:09 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 15/15] io_uring: port to struct kmem_cache_args Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-15-76f97e9a4560@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903-work-kmem_cache_args-v2-15-76f97e9a4560@kernel.org> X-Rspamd-Queue-Id: C5438A0015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ic4x116bjkexr76soap34qmzgk4f6xy8 X-HE-Tag: 1725427136-384201 X-HE-Meta: U2FsdGVkX18lAp7yBTxhHOwJAZG1dKo2JNTXS2VZmzNMqmpFihZC08AdSMCBijaOrNyFRwsfPTNnt/ntW08I/ZenNMZOREcjdcl2Phy/mqmNvpJ1QdIFj9Vyf6dwl8rtu/q6vysYWMtSzqavflqWx5hJqmWRQhf4N7Vi1FZUd9MgdteU95KhLBEETQ1zS95iRFMeP3PAsSfL4Daes+631w7IWJIAmz7xExv/KURTry4qQIncegCSuYEbGppS6v3SYeMyEd1q99DPoMIX06Z+Z7R0w3ZSsD5e0TcL3xG3MYjE75yaKkBga+FafNtZ4CSKge0ABsim3jBf6AK1dQIZ5A+/zOJIdFfaQ/8hKMU8yOp9YHyy/6D0sVw2ppFOfZH8uzxFuw25mne6MHRW//rW9Q+1Curruh+BLSmfg3YsfuFndYaG2FaSVakeJNKitEENaH6eUF8ltOLaSKA9YQvErWatOt4icIt4gs4N8wfzTCGDHKIxLdAhbHesFW3k1/LYMVZWl52y2EWD9uJyuNjdKCnW+yy25pBmviDWFZSKmO1BcxiNBXKMs1BaBdGdD3ZvwUxs0rIvYWtKomqp/UO9ShENzKRC6PqxWcH310+WXBJJoGZ0HaSy5Dmv435Qw1csXzYfIB9cqDXFeEODIUDk3QM2NsAsJWUCYqWRHipgyb1yJuu5P65RxXqFGrC+aemPX6g+eNyNMhn07uKtgi0fT+mZ3IBBtdxdjpXQFd1yncUfSIJ7gf/0bCKjoC3hJyYyUO9fHlE67v38l9JbfYTYO/F4vnMDoinTPuYC/fRtQEARlwV6W243f46Ion9Nq+nI1YouZy7kSYeqT/gBvpsWrN9Isrr92sRA2BnNanJ6+BULiK/UJDMr04ILFfIm0LMz6SWm2snSsYu4ZNgk5hNYdT3ws/B6mUZ+odg1bpf8rXOw6P5s4Q4PYnbgQm33tEvuU9rlyMvMixOrsqJPLUw j02RzXqd HFwE3yyryzkLLF0Sbq0L0tI2+eiLJWoIU6ueVmZf0MQ+b2V6Y/62gux4EGQJkVGP5rCdItFDcJyu0IQJsLKUoVZqkNvQUbTs79ykaWCsSZBxGjekWSuEB0K3B7Y4wuPuDccd+SVv/617rbCg0sCdQfA88V0MTG2sfFhwqfIST/+mj4CZQB3d+tjrzWJaxWvRq9lJbrOQBoi+Fp4STQCoTFMRFGFSYQawLDzx04rcISJwrnPyvtRAtsan7e2M7mftSqGjZ9y1x9bu6c9rOecEpjKtYDzm20UoQynAsSU4+d3KPwQTfNizlh9EtSar25XsAcoFT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 04:20:56PM +0200, Christian Brauner wrote: > Port req_cachep to struct kmem_cache_args. > > Signed-off-by: Christian Brauner Reviewed-by: Mike Rapoport (Microsoft) > --- > io_uring/io_uring.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c > index 3942db160f18..d9d721d1424e 100644 > --- a/io_uring/io_uring.c > +++ b/io_uring/io_uring.c > @@ -3638,6 +3638,11 @@ SYSCALL_DEFINE2(io_uring_setup, u32, entries, > > static int __init io_uring_init(void) > { > + struct kmem_cache_args kmem_args = { > + .useroffset = offsetof(struct io_kiocb, cmd.data), > + .usersize = sizeof_field(struct io_kiocb, cmd.data), > + }; > + > #define __BUILD_BUG_VERIFY_OFFSET_SIZE(stype, eoffset, esize, ename) do { \ > BUILD_BUG_ON(offsetof(stype, ename) != eoffset); \ > BUILD_BUG_ON(sizeof_field(stype, ename) != esize); \ > @@ -3722,12 +3727,9 @@ static int __init io_uring_init(void) > * range, and HARDENED_USERCOPY will complain if we haven't > * correctly annotated this range. > */ > - req_cachep = kmem_cache_create_usercopy("io_kiocb", > - sizeof(struct io_kiocb), 0, > - SLAB_HWCACHE_ALIGN | SLAB_PANIC | > - SLAB_ACCOUNT | SLAB_TYPESAFE_BY_RCU, > - offsetof(struct io_kiocb, cmd.data), > - sizeof_field(struct io_kiocb, cmd.data), NULL); > + req_cachep = kmem_cache_create("io_kiocb", sizeof(struct io_kiocb), &kmem_args, > + SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT | > + SLAB_TYPESAFE_BY_RCU); > io_buf_cachep = KMEM_CACHE(io_buffer, > SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT); > > > -- > 2.45.2 > -- Sincerely yours, Mike.