From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15269CD4857 for ; Wed, 4 Sep 2024 15:14:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B0CE6B00D3; Wed, 4 Sep 2024 11:14:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 938816B01A3; Wed, 4 Sep 2024 11:14:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B2506B0163; Wed, 4 Sep 2024 11:14:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 566996B029B for ; Wed, 4 Sep 2024 11:14:02 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DF097160E74 for ; Wed, 4 Sep 2024 15:14:01 +0000 (UTC) X-FDA: 82527401082.18.034436B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 3F4B7C0007 for ; Wed, 4 Sep 2024 15:13:59 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CtFNBJ9A; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725462744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gJ4c6EPXsk+3duBbTN/2G1dv3D7hPdocD9XLatPaeXA=; b=zvzPfb+KOEnjpX+LYZRNaBACnkhXi406AuEUmvueY8KZqYdy3cqfbnSRUeZLwBB0JN+ov+ IdgMrQeh4+bZBfwDoWfX9RHm8jKgWZAMgqS140bXo/+2xBLqMufwsABdchjkUPqUr/rTjV Zf055Jv9V2tp670vzTxkG7lD5FGLePQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725462744; a=rsa-sha256; cv=none; b=IFdfbthEf+mIZ8zYQZY//QEMcN9tp5l+e3z2uulzRcYuUaM1EDxCXaqzGBPAbAIqaXhb/T wvdONJZAYidg1WgFxYDHeQOsQIqwkU38d0uzHOl5l/cElXt5mx0tsZknPiDAiKWUcfnLbm nNeTmjSyTnr+sPJYO3BVHedK0YjErfw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CtFNBJ9A; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E20AD5C57FA; Wed, 4 Sep 2024 15:13:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54D51C4CEC2; Wed, 4 Sep 2024 15:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725462838; bh=rX0vS1zR5X7dTFyMgPdiMHFhqaGeKMhYHOljR2dXDA0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CtFNBJ9AwQe6ozrVAAu6Gv0mBSh1UeN347L+FByBeT7DFYXbXBgkLXQ2xq3ZKRLva xlPbWd2Mj+tVnhN+kDGr0UvIVT1qzALnKCTOxNh357NVg6NFVBAfSk7zgBSFbeS0Ne IS49rNakaIyhirV4GyV/LJ24E9E1IJZJOUCWeR750RY8sLR9t9dE8aC4pKtu8pshXo MjgIxwVZ5IJpvTnT77ngWCjM/ObgJ1aUj5imsR+SYllXc9MxkoIY7IHOXTlB+40zLk dUCEHUUlWUyM9ptqqoYMcyReF4EIPabXIj5vXaFTKclIH+hhXGZjio2mkzJCR9m95D ZzwDDJAShVnvA== Date: Wed, 4 Sep 2024 18:11:10 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 12/15] slab: create kmem_cache_create() compatibility layer Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-12-76f97e9a4560@kernel.org> <20240904-storch-worin-32db25e60f32@brauner> <23eb55c3-0a8c-404b-b787-9f21c2739c4e@suse.cz> <20240904-absuchen-gockel-8246820867b4@brauner> <24717bab-7d5d-4ed1-a17d-65d4676e22a9@suse.cz> <20240904-gegessen-kalziumreich-2817b07433b7@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904-gegessen-kalziumreich-2817b07433b7@brauner> X-Rspamd-Queue-Id: 3F4B7C0007 X-Stat-Signature: j99yqm9jirbej44t3estfzptzzs8fznb X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725462839-866635 X-HE-Meta: U2FsdGVkX18WwwtS1zD1QzkFYBx6X35wFFv4ICwHnIwDAO70xS3zXZIQThdkB1dD25ZCGr9WqQtBYLwEIEwfkSRvwg+krzDPpZ92SPWN8CXpMqSqkaKbVTSvltoV3BEIkSHQ7PCSawhVMn3UeLzoxFYgCuFuRdVYgW3mOf8EmsNfUesPuFR00b/iR5qHKLcWjI4hT7Xu/i1OUO9gr4sWupojgqevfBLlFmAJoytheEoVACZ0KHZ0smHqa5VfGZxydCyqGMNPKczvG2D+QsobOLh8r+XEg+IsoTJ635/dOc56lJsQ+Yrhx/0k+zviQMZNAVZltAvmrlCPJJM7dALILjNw0pHhcSL3faata+5Nlu1mdJaIInafA+MA4crNLUupIO+w10CaC2L2GCY+npUh57DpD7waD2ds+Sp3qQuU70krBtCXR/q+PFlQDL9y/S/yZ+AXLYxzTvWEneaPEWjAgxXAsHE6KV/sGu4SnwXtQJXOxV0/IwxjAcOZVS0vNquQUPwKfvxVrR4JiKfMZHWNbXLYyIfg/baOz6zDE3fMIg/S842NkPYtwx1Eg/IHXdWd0WAhnzskJEP4x5HYbDa1I9539NRVYrVxV/2V3dLMjXUO71eQUlFPxc3C8twq5oJG6lgmhUy5nUgobOYF10hGt2uOIMXCYKzKa5J3e0Dov0gfW/57PPP732d2Xw21UaA8dp5FAG3FjpBzowDD7GmRA+H7g4ZVywYX/HRJzNQd3+YupNTkZl+ba37L5+o/Bd+fz79oVy11Zb7vCBgLeK1wCH2XeJOjxsZnCdczgUdzyRzVTnGKfVo6EX0ryuLkxdPa/4SkvKsx03I94D8eUyXoEi5VlhM2/caUsu7DffokjZjnlkfwmdwVuChi/k5YUGESwqVGgnGR3b2DEGOsioy3l7syRRlTcqpUQryhg/zuJqRbFTnYLRGaJoBHv5PT98t0BJMFobG6o3KCueYnWAw aVSjdXHW tqthdhms74pOH1IWQn4fGvNHXk48eAXijV13wOJFf3dgV40Cx7AG9kA59vF5lZoMKXjx+fL/tDwNclJRqgulqooOgAIGtIanOiWMfoSo6KQRbMnplfslmNPYE82V7gvpHoCuN50I/+dflKkjS4JhwSPc8WQrzb9tkfjOlHguGLrS0Ypta82Xu/XoOZOiuh1HHttdr9DLqkxoWg5xiu2kyWvIoyQt/LZVwljW40dgiRDCdDneGdWRgp8O8xaSGQvNMmGsj1AAEM25IHYt4qozL6hAm2bw+dUUpDIA/+iEMTIwujBUm4wena1CXpJ+onwf9kyjywqTFw49EEVg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 04:44:03PM +0200, Christian Brauner wrote: > On Wed, Sep 04, 2024 at 03:33:30PM GMT, Vlastimil Babka wrote: > > On 9/4/24 13:38, Christian Brauner wrote: > > > On Wed, Sep 04, 2024 at 12:50:28PM GMT, Vlastimil Babka wrote: > > >> On 9/4/24 11:45, Christian Brauner wrote: > > >> > On Wed, Sep 04, 2024 at 08:14:24AM GMT, Mike Rapoport wrote: > > >> >> On Tue, Sep 03, 2024 at 04:20:53PM +0200, Christian Brauner wrote: > > >> >> > Use _Generic() to create a compatibility layer that type switches on the > > >> >> > third argument to either call __kmem_cache_create() or > > >> >> > __kmem_cache_create_args(). This can be kept in place until all callers > > >> >> > have been ported to struct kmem_cache_args. > > >> >> > > > >> >> > Signed-off-by: Christian Brauner > > >> >> > > >> >> Reviewed-by: Mike Rapoport (Microsoft) > > >> >> > > >> >> > --- > > >> >> > include/linux/slab.h | 13 ++++++++++--- > > >> >> > mm/slab_common.c | 10 +++++----- > > >> >> > 2 files changed, 15 insertions(+), 8 deletions(-) > > >> >> > > > >> >> > diff --git a/include/linux/slab.h b/include/linux/slab.h > > >> >> > index aced16a08700..4292d67094c3 100644 > > >> >> > --- a/include/linux/slab.h > > >> >> > +++ b/include/linux/slab.h > > >> >> > @@ -261,9 +261,10 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, > > >> >> > unsigned int object_size, > > >> >> > struct kmem_cache_args *args, > > >> >> > slab_flags_t flags); > > >> >> > -struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > > >> >> > - unsigned int align, slab_flags_t flags, > > >> >> > - void (*ctor)(void *)); > > >> >> > + > > >> >> > +struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > > >> >> > + unsigned int align, slab_flags_t flags, > > >> >> > + void (*ctor)(void *)); > > >> >> > > >> >> As I said earlier, this can become _kmem_cache_create and > > >> >> __kmem_cache_create_args can be __kmem_cache_create from the beginning. > > >> > > >> I didn't notice an answer to this suggestion? Even if it's just that you > > >> don't think it's worth the rewrite, or it's not possible because X Y Z. > > >> Thanks. > > > > > > I'm confused. I sent two patches as a reply to the thread plus the > > > answer below and there's two patches in v3 that you can use or drop. > > > > Right, that's the part below. But the suggestion above, and also in Mike's > > reply to 02/12 was AFAICS to rename __kmem_cache_create_args to > > __kmem_cache_create (since patch 02) and here __kmem_cache_create to > > _kmem_cache_create. It just seemed odd to see no reaction to that (did I > > miss or not receive it?). > > Oh, I see. I read it as a expressing taste and so I didn't bother > replying. And I really dislike single underscore function names so I > would like to avoid it and it also seems more confusing to me. Heh, not quite. I don't like kmem_cache_create_args essentially becoming a replacement for kmem_cache_create* and I'd prefer __kmem_cache_create naming. As for the single underscore, I don't have strong feelings about it, but I do think that it should be renamed to something else than __kmem_cache_create to leave __kmem_cache_create for the core function. -- Sincerely yours, Mike.