From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F2A5CA0ED3 for ; Wed, 4 Sep 2024 14:17:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F22A76B0487; Wed, 4 Sep 2024 10:17:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED2346B0488; Wed, 4 Sep 2024 10:17:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4C076B0489; Wed, 4 Sep 2024 10:17:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B52996B0487 for ; Wed, 4 Sep 2024 10:17:11 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5E1081A15FF for ; Wed, 4 Sep 2024 14:17:11 +0000 (UTC) X-FDA: 82527257862.06.73AF408 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 5C99A100002 for ; Wed, 4 Sep 2024 14:17:08 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=ltEJ6AK0; spf=pass (imf05.hostedemail.com: domain of "SRS0=ZifB=QC=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=ZifB=QC=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725459333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0gX4iKFO2d6giGBiJdj/U8E7BIuEXsYx2gfWhptxDWU=; b=KrqDjst5vQXk/zMKYumtwNrb3SIj3ntMh9Xjm6/yCBL7RuaoLZ4eV1VCXzV/X/0+rCOU8T mmL+buzLbZJeX670P+1/KYM1PZ8fk7M2ypVruuTmn3R5xTL6p0f5DBEArV0WiY8zRLrja4 /4ghoCdPrJ+t2quj5NXe6SM1n9FO2KM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725459333; a=rsa-sha256; cv=none; b=kQA936K8dCcTuTEeGYsZ9MerHOzFl3i5eHauqfTJHD9STIcGQoCa0sqmHf32N+bf++elwY 1XnlSkusrxLHVtRXK3hUCDIQcTLm8bzt6jyYNMV+pys9cSVel/ZFl46hgFlXoz5AmI0EMl b1kBYsUXXsXcBaJiJR0iK97pnsfq66w= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=ltEJ6AK0; spf=pass (imf05.hostedemail.com: domain of "SRS0=ZifB=QC=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=ZifB=QC=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7FFBF5C57F0; Wed, 4 Sep 2024 14:17:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30D7BC4CEC2; Wed, 4 Sep 2024 14:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1725459422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0gX4iKFO2d6giGBiJdj/U8E7BIuEXsYx2gfWhptxDWU=; b=ltEJ6AK0bHrwJ9RXlZ516PTeVUtSiUL7yGEtQLnYEjyD1A1U1r0m+mgYrevZkKv2SDRcnb YkcfwwvWKQHO67NklnaO03mC/TAAJUP+XqDWQ00JUD/4WMIVCqL7ugAMEJq23lFeUZtWsB GaTlLQGomeGWPBvK1KOIbdDK5n9Hp3Y= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 19554c25 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 4 Sep 2024 14:17:02 +0000 (UTC) Date: Wed, 4 Sep 2024 16:16:54 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao Subject: Re: [PATCH v5 0/5] Wire up getrandom() vDSO implementation on powerpc Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 5C99A100002 X-Stat-Signature: 5wiz1sh5tpe8zfnhyxnmoctc9x659f41 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725459428-561317 X-HE-Meta: U2FsdGVkX188bbVP7SQkTz+VbyLjFF5f50MW/+7qi9p2ohRS1FP8D34/EK2VPR0c7hwXyga/khSFUQ71OjYM49C1/eW3jdpdPWwaMcTrCAWXgaGFCwLgXQM4rjeegt6TXRRbUBWPvWx7hyJAcuaZRqvjvquG5YdLQUkz5mZk4uYuCW1n753b/GAkI67Frl0dzhITyfg5jDI3RGVj9Nzvokac4hW0uzbC/DB5za668yFeI0dcasHjlPZ+5YXDK30VqXL0EJzouAvr/2e9Wmb5SlTI2rMn/8NydG8zP6ScRa9m6KCogna4AkuqAzNgAd1R7ZUDz8Shvus0hdFTq7puJuWIxDeRFcJXwbvC/bNVmcz5MxrsSFBb/Xod5iZPF6PRg7ebWYvnM2AuudkdfYWJx/KvZs8bo2hwKMa9cJv5gJuF3ae26O1d7Tnc65fvQOKrHBA26gVDJ83fA7M4cShE6TQ1w+fb225mmr/WXNx06Hic28LQx7bzSyPx88rucrdLMgUKSJFE5e6NCGNRlXo0hCFfC0kpXoDchGsGCFjBwxQ+AyCYLYGzjVXet8Cyk7uIzP0lvwWJszam2QVvwjbgH8U/jOrNNs5CjtmVrmtZILEMQ6HTH7CqN5VwCBggKmqDqpmYLw/d1ojhAijN7cLQU/AB9G/XntFwAP9KNsYfOyl3ychWYxUx4WT3x7RDNTukxwST1bbMXhf+KK3QgZWmH3qeKV6gfCTDUiFVFMk87VDbg4xEodejeuIoTw8uuRiTsm1xOSGpoudnpx25lzfVIWnXnzpotx8MTalNQU7wfijGkimXYq18HmE8bOji0JobHb5oBvJ74cdb9em+6xZEEC7mIdtKaSEeBZ+KuL2YTpxPJ3d4iH6H5ARReHjwbJ4aW4P8Fkc1Tjq5UuXTx62GXFQwUejTVcuMDL696ItRMlKmFX+2AgkztWk9UUT5KJTEf0dUuo1akFrNHYnRVWH uTyHM+ng oo+oASxJkWMg6NaM8gKt7pTvS/hj4d0hWPcJ4lm5ZRJ1A7ATkMPfPqcta6lzBEE63GEsd3htai7Ct6gH40lAtDRJUEZMUVeldjTbPOZQu5nlz5ikVv6pLcgNNMA5mqnhc9QHzKiuHDA22Rp+WA/8OA2OChoS4vo5hi2yWdJbfP8VaNstBDOJdYz+wFs5DrqdIXnWqOAoqdEDSbeJn/rUBbXTciT/c7cC3fJ1XDWjUZi12m2qV2pnVPr00QDPA59BwjByo/9z/enGGDzOWljwEDe0iTwagPwuRK2SSzzxiY9Ev2oJRJCUqZMmLj+V2+A3ME9WH5Mum7Wo8hamOwCqDl9Ppk/DmZ4FmUnBVHvNH2DcLxZbJyYfcCnlMFFKllmpF2Da1aiETWZnsH36WxEQzqm70cqFdC6RGMf0/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Christophe, Michael, On Mon, Sep 02, 2024 at 09:17:17PM +0200, Christophe Leroy wrote: > This series wires up getrandom() vDSO implementation on powerpc. > > Tested on PPC32 on real hardware. > Tested on PPC64 (both BE and LE) on QEMU: > > Performance on powerpc 885: > ~# ./vdso_test_getrandom bench-single > vdso: 25000000 times in 62.938002291 seconds > libc: 25000000 times in 535.581916866 seconds > syscall: 25000000 times in 531.525042806 seconds > > Performance on powerpc 8321: > ~# ./vdso_test_getrandom bench-single > vdso: 25000000 times in 16.899318858 seconds > libc: 25000000 times in 131.050596522 seconds > syscall: 25000000 times in 129.794790389 seconds > > Performance on QEMU pseries: > ~ # ./vdso_test_getrandom bench-single > vdso: 25000000 times in 4.977777162 seconds > libc: 25000000 times in 75.516749981 seconds > syscall: 25000000 times in 86.842242014 seconds Looking good. I have no remaining nits on this patchset; it looks good to me. A review from Michael would be nice though (in addition to the necessary "Ack" I need to commit this to my tree), because there are a lot of PPC particulars that I don't know enough about to review properly. For example, you use -ffixed-r30 on PPC64. I'm sure there's a good reason for this, but I don't know enough to assess it. And cvdso_call I have no idea what's going on. Etc. But anyway, awesome work, and I look forward to the final stretches. Jason