From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 198DFCD4F21 for ; Wed, 4 Sep 2024 16:19:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79CC26B0108; Wed, 4 Sep 2024 12:19:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 726388D025E; Wed, 4 Sep 2024 12:19:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59D4A8D0253; Wed, 4 Sep 2024 12:19:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 356AC6B0108 for ; Wed, 4 Sep 2024 12:19:35 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EB50EA1821 for ; Wed, 4 Sep 2024 16:19:34 +0000 (UTC) X-FDA: 82527566268.21.CDFC819 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 2C43640022 for ; Wed, 4 Sep 2024 16:19:32 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="B+qjX0/q"; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725466677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OzC+B86FQyF/YlzUNo/nXEm+Ugfs6lInXrDOX1mynHA=; b=wiURfK4DmyiJO17X949fc9jvyvcBeDF3Sfv+FcMKGsaNlDrI9kjFVelEIwsTCS10yps9aC 4On3ZuhRcU1HhrEZghHnE/5+CtlbeKZ8tDx8sxD6SdFeZWmU9H91fOc3S9RPe/mqET6at2 HrqYl1MgHWygtEarMU8d6gfNy3ZYCJg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725466677; a=rsa-sha256; cv=none; b=zzkpoW1hiIzMpO+3OqlGAa/MFkcCoqqFpvr/4myK2DrcvQKqht9YgiBYMfXN8F0DLVqVZ5 Ui0t1VAd/DWdFlP+DGTQY/Ja9rGr8FTp/rzf4gwikE4RGfljFBQDw28KYV+zDjGURwevg2 J5AQw48hxcfkMEGdrIS14eWhlVuatx8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="B+qjX0/q"; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BA8075C57B1; Wed, 4 Sep 2024 16:19:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F4010C4CEC6; Wed, 4 Sep 2024 16:19:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725466771; bh=zux/Q6f4GHCljD7witUCfRLF6iwgNCywYMqZ73GamjQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B+qjX0/qWy9hx1FU2ZjCAbOeZiD8kg3OkHuZIckSG3Ymj2TJ1jGOvKtlNGvtZfQ4p DxC9UZfJ5J3szU1/4b26OjSINeWohL1S3X18fvStMLE2wPxDSfQdm8rPeaBQiPGtEY h0YmCPq+3ClvU/HjjV5IKiItJjqQPpSO2ZhVnb1P0svz7A9TquHlYW46hhgbj/+6Ez uLbQl2su/gCeZxRGtkNcipMBrpUfljeuM7qr56DARJJ1eY6b/5pY9bogzpP6NFirkI 3djAvqKxIAOQda/XHzunCtW+cBsE6xwKmlGBxp0xvgTYObkmhbB1rI548bnWabDryf tJJZ4kr4zSQCQ== Date: Wed, 4 Sep 2024 19:16:45 +0300 From: Mike Rapoport To: Vlastimil Babka Cc: Christian Brauner , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 02/15] slab: add struct kmem_cache_args Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-2-76f97e9a4560@kernel.org> <9303896a-e3c8-4dc3-926b-c7e8fc75cf6b@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9303896a-e3c8-4dc3-926b-c7e8fc75cf6b@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2C43640022 X-Stat-Signature: 791zotkonr9fsdnr98mpx8n63mq3x9ta X-HE-Tag: 1725466772-900245 X-HE-Meta: U2FsdGVkX1/29T5/x3/Copmlzxen7Fh6jobl35V8zknjdt+hsnFPWZUsSJczC5S4ybQuL0nsVr0E2njdFAoROf4NzGsh3m/buV+cKidh+OVqt1TVYI5xSBrmJSHzGmCB+Zfi/IlTtJQgGSUJoIPWAUlg89HeN6G7a2yzvLyg4X/XAWv3QXOZb5l3Tuhs2W00rqpz6SwlnTnjHBmOrwfsm2KWro/TgO6Z3PPdmzFXzI+lveyQETTV7O/PDUPTiRvlgOhA+Oy/JJCqhaYj90X/4YlsR91y+w/VaKM4Z1PgMzhLVspoTS/b555iBDgC4zKa4Fa3UKwEjzlILHDh/HHokcawCuRLe5PlgEJ+P7ZF7hDcyDKc5vHkT/MeGa6aC+WlduvQGU2fue535319OCaOQE/669ABBTdk4efCCmhI3gIO+fvNsyhtWquk4bdNCiguyIBR+ZRBDLr0RMiX++59cCOCM6QfqaNjnmvHjaNRln8owYfTtucrL9WRIg10wnQqn85Lc2FAYHZNnIXfUxZnUmLl1pglmiJkEO2a5bzSeJMC1Vrwu1tvLN8Jdgtnv9HU1upzlOTHhDrQ52KT5EMk3hb2TVFOtDkBoumCAn4cyacVWosT0D8HIYs2DckHt3UURpCATMH0TDsOYq0ldYAFlKjMwxxr0BamsNtMiSCyYq/r/Y8zPc/mFAm8SkTxgz4zK7x2dm/SmjUZoG9aG3eyIWVMfB+xoRCDgkTJZCKjo+msNbuwmVHRRRhXensMqifoWyy1SwZAeLmbTMGhXhYlJJ5Xy0zUBtZ0hsy2iYO3i9L/DE+6E0iTEOyys4G2zeCahlkyyB3bJ6l8SfkAYGthnvwKAlNPiosjG4Y8dWQgaKNTPDD8vrucjXrhFBrh1QUA4q4tnT+yZU1j804kCaIszAxy8Wud8gNDgl6rLu2ATthykOkJpUcqcKTX0UJW69Yn7UmZ0UbjqmlUAxp8Kw/ nRrO/fNk mU3VEr0we4ULlrtGJ1zR0EAgr2bKTR9zG9vsNHAgiAvt/0Xq523VPMiLDJjaU/faumt04ScuzoJ7Z8nh9Gdo6B6vwn3UNzw35Kp0Eqm0KlVQ3iPxOjNQeT3JDxFkLSTreyByVP1b+Gb55lg271aqSlOgAgbiUewU/hTnlChf5+pwhwnFGs0naEKj9cg+hOjx1EKR0jBMv9zKg1Vy1ZrvkcqiFUODSxZeJa906vGRkXo7wUKBzoTXc26spwhTb9Do4y+bbfzVxlrou4uoVWttEFDZgYhVcmfZXwlP6jd8YFMXgh6g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 05:49:15PM +0200, Vlastimil Babka wrote: > On 9/4/24 17:16, Mike Rapoport wrote: > > On Tue, Sep 03, 2024 at 04:20:43PM +0200, Christian Brauner wrote: > >> @@ -275,7 +285,7 @@ do_kmem_cache_create_usercopy(const char *name, > >> > >> mutex_lock(&slab_mutex); > >> > >> - err = kmem_cache_sanity_check(name, size); > >> + err = kmem_cache_sanity_check(name, object_size); > >> if (err) { > >> goto out_unlock; > >> } > >> @@ -296,12 +306,14 @@ do_kmem_cache_create_usercopy(const char *name, > >> > >> /* Fail closed on bad usersize of useroffset values. */ > >> if (!IS_ENABLED(CONFIG_HARDENED_USERCOPY) || > >> - WARN_ON(!usersize && useroffset) || > >> - WARN_ON(size < usersize || size - usersize < useroffset)) > >> - usersize = useroffset = 0; > >> - > >> - if (!usersize) > >> - s = __kmem_cache_alias(name, size, align, flags, ctor); > >> + WARN_ON(!args->usersize && args->useroffset) || > >> + WARN_ON(object_size < args->usersize || > >> + object_size - args->usersize < args->useroffset)) > >> + args->usersize = args->useroffset = 0; > >> + > >> + if (!args->usersize) > >> + s = __kmem_cache_alias(name, object_size, args->align, flags, > >> + args->ctor); > > > > Sorry I missed it in the previous review, but nothing guaranties that > > nobody will call kmem_cache_create_args with args != NULL. > > > > I think there should be a check for args != NULL and a substitution of args > > with defaults if it actually was NULL. > > Hm there might be a bigger problem with this? If we wanted to do a > (non-flag-day) conversion to the new kmem_cache_create() for some callers > that need none of the extra args, passing NULL wouldn't work for the > _Generic((__args) looking for "struct kmem_cache_args *" as NULL is not of > that type, right? > > I tried and it really errors out. How about #define kmem_cache_create(__name, __object_size, __args, ...) \ _Generic((__args), \ struct kmem_cache_args *: __kmem_cache_create_args, \ void *: __kmem_cache_create_args, \ default: __kmem_cache_create)(__name, __object_size, __args, __VA_ARGS__) -- Sincerely yours, Mike.