From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16EECD4F23 for ; Wed, 4 Sep 2024 19:05:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26B616B0349; Wed, 4 Sep 2024 15:05:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CC436B034A; Wed, 4 Sep 2024 15:05:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06D466B0348; Wed, 4 Sep 2024 15:05:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D775C6B0343 for ; Wed, 4 Sep 2024 15:05:20 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 187D0414F8 for ; Wed, 4 Sep 2024 19:05:20 +0000 (UTC) X-FDA: 82527984000.19.E342831 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 7285A1C0014 for ; Wed, 4 Sep 2024 19:05:18 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kV5LeuRI; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725476623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=95Qj69imEUPbhvLJi92lvO2N/iaSNhuXd/4sCbQHI3E=; b=DZH3SLMr8EjA7KKlIO8vlSVSkWrtEkx54APqF6C6JKVPFxLcgRrT37wcwOUfXiAPtr+KzI TAWIOfjIT7g2/h+V6mKIrjsp4a/1NpqfQm1HlvS0HoUotbDHyIrHCbytCPpR0wUlnBODxl T96HQCLsj65w7tkOgjSXCiDdFd/UOaA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725476623; a=rsa-sha256; cv=none; b=2o//mNZZh5ruitxh6KbtZK51ohVN5Ef4///lv7U6Bg452H+plrlpyQF7Ke8L2gGDoI0v8u hz72x9dfOq6TFyMp+vnzVa2NnOBAJp75hRkdtcbaIQi4xU0yS29HYZ7tqbyu3ZJV1LkHYz w7W9f6rmVLnC3Lh9eOwO7t9tWt46dhk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kV5LeuRI; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=95Qj69imEUPbhvLJi92lvO2N/iaSNhuXd/4sCbQHI3E=; b=kV5LeuRIsJwQtYpvhvgppdXBoM 3UoeOX1sq5K9XJJpdRwjuOATsLQ8uzvv8QR/z7AWH4k7fdq77Kq1lppq7lcVAl0Eo/vHJW3vXN7Oh PZh2Zf9zzz1n9FP4EPyuOd1h6qGaV5ttFvrKts1rj0VA14iB+teKBBQxvxVZej+BZ4j2ndszU7KYX R+EG5+6AgravKuyG75t+/PwFJPc3e3YI645uKFVVGg+ZJWrMf0yCBrSUVIsL0UDrQf+Mq3OoD4mYc cY/IXbZVNDWm5KSorRPUmpbAcuu4P6Hhb5OMfHOCNaTaFdgmpce9FDVKeobeb7XW6dxV0H5wJukqJ RaA3KeXA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1slvJZ-00000001Hsb-3Rov; Wed, 04 Sep 2024 19:05:13 +0000 Date: Wed, 4 Sep 2024 20:05:13 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , David Hildenbrand , Baolin Wang , Zi Yan , Vishal Moola , linux-mm@kvack.org Subject: Re: [PATCH v2 2/5] mm: migrate: add folio_isolate_movable() Message-ID: References: <20240829145456.2591719-1-wangkefeng.wang@huawei.com> <20240829145456.2591719-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240829145456.2591719-3-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 7285A1C0014 X-Stat-Signature: eppsek3w7nakrmstbnmx3n44uu3p5rb4 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725476718-163623 X-HE-Meta: U2FsdGVkX1/rNcdLdCPynoFR8kxfpoBtCPcz/xCEWdKK7Zl5rwSJzH9DPvUYnQ07Z+zyiG/CMikKsuXCXlxZ8lUTzQGVoIwaARpTB9VCN6NUM7ITsUbqRS4iz1GnzU2qREvDMxaQaG6JSnuHTrgkmIoMAHUMZnkzVhuZJ3oM9pcNbpto7/uQhMCRimqE1zt4fRDB6i2GtVGTMEjJJYDiuL2GXJjp0BdFJ9k4M49pDHmcO/hspsTnwS3hw8qwvPmlX1aLM8tOlVcuzTbMfytVCeUOjWxYYjQ/jj/GKA0RbJDy3lLBtVih7UKFxYLP/JP+OXeYC5lEJrf6Q5oa6XT92abQPiCMLLIFXjwtRhjyuZrf9FQPd099mhBFM8di/3kLB9w1O/oYB6i9cBIc495Gcxwpgko0gXim7fqcqxVZnLHFZSR7uQN9Iec5/8pF6jyPGm7uAFNNSrv38/OZcbf4iJaksvgM1dfd0CbFsOG1Gfgg5WG0roHndSt2AW/Teed4rbIN41W3hSztZBsuha/5kkavJ8s1zVpcLTCVbkqhsPf7aZRYOYv8q9jfTKUJ+q+kd2zUSGG490yUCZ7IMfp24htYm1BGSz34g6qnkxRmlQQ5daKoMMEcTbDK1t7I1HEixW8ImHfjsCP/VOf0I6GmDYzp/5RFM2uxPrxPF4JGic+XSSEZjOjqY67vC4eXs8G8f7k3j5eGmO2+D1Gp6P/WsRKLxxiAu7YUSZDvqeQvChKw1fMRf4OgTXmlGNX6Jg0PceRc3zzVPPC1MwyAjp/xG6qKrBqp55X1wENhJcVIitqctPH0sqnq6+6D0nhgjLGwWXCT10ZYUOaudeoLjb4TAvW77riKMyodw6gPjY9BLlSPESp5yMKazGVM/bIxxFDZmeVHY/rG0LLKL29lCTjUjiDj+LXZhU2MgyJZQ69Ov6bOlfX/pzYYNvqBnRaUzV0uygIiFHwqNspKw9WxT5j F1FHq8BT kVXJLCg3+VWOYeqoZDMm9t3NYOuXSbHEUONBB/LTrbpP78DjqjhJ+O0kPph54n7mzH2k1ivaZQAgA6EVYyurRQVxz2T84/7bDuH7YoH2JfMO8E/+KC4u03erWtVGJEiEwmIJ0KPRkiGfjycF+uSCZT2pGVf3X/3ekb6jV9TrIyKp65SnWYIZK8sBGK5reoPJHn5EFcLFE7A9pFM3OVL1sNwMnPK8PNpM6YM+EVw2xMPF92cEGxqEZUAbDrqCYjvlKAl4ioDbhbW25u8eY/fGLBkvWsv0XJqWDGLPzYp4Umx5qJL8ysfLEQLR4OzGZZVoPf3CadSDIU7gsXMlKYkNiiCERHHcGaG2/aXs/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000096, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 10:54:53PM +0800, Kefeng Wang wrote: > Like isolate_lru_page(), make isolate_movable_page() as a wrapper > around folio_isolate_movable(), since isolate_movable_page() always But not everything that is movable is a folio. Look at who sets movable ops to see counterexamples.