From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B5B6CD4F5B for ; Thu, 5 Sep 2024 08:19:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 859156B00EA; Thu, 5 Sep 2024 04:19:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E3226B00EC; Thu, 5 Sep 2024 04:19:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 683F96B00ED; Thu, 5 Sep 2024 04:19:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 474F26B00EA for ; Thu, 5 Sep 2024 04:19:16 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id ED05D1C6148 for ; Thu, 5 Sep 2024 08:19:15 +0000 (UTC) X-FDA: 82529984670.10.E339B5E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 53E0220011 for ; Thu, 5 Sep 2024 08:19:14 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EaTH0Fv0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725524283; a=rsa-sha256; cv=none; b=CaFD+XitZB4ZfZFTpY25w1/0ccQOy6w6ohh1+lIc5TGTytaDA/cmcrpvAPckedZjFeEjNq CqyHErp+HAR6BKg3YaN8XCL+ng3wsR/DVriRQDpUYc+Idh4dXJR33RhT6cs2hBZI8sm65s 7ZAVKRSsskUiHH0o8ELWLLcMkbTg244= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EaTH0Fv0; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725524283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JIHdi4//mBqZokA4ohQLATd1voZ6UkJjm1LlOXXMxrA=; b=ncSCgZFuoGqrgPhdZ0zdnWZJJYg1OdSJxoZd6FtUYmlv+CMuEfvgfBZuYuh8/T0NjpMTro 3IBYjcsCRxdTFSVbqESNlMccJXanhgTzkXUO8iEEWVzS4TG5nf2OHbVPf5/p9wBANahAUw dYBT4sHp+5y3Ztu5+uKH3KP8HWYpnLk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 061EF5C53DF; Thu, 5 Sep 2024 08:19:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C173C4CEC3; Thu, 5 Sep 2024 08:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725524353; bh=sv2gQtQX2pmJd2dgqLsOPXPgZNnpjXpyckrdF9ZT0Mw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EaTH0Fv0RzPdsLBgnK8ihQjwMRHr8XojIf86cTHdtVv38M6wQJZsrOwy18iBPeVHl 9c6zyuWAIimBf2npB5AW9ji76uQHC2rhnPBrpxKsGKRRTofWQLKa+oQQ7+YyP1LEqR oOaV6q4vEFQ1W8eknqyWb/UBsKlBKxCPr2VLA0+iqnPyLWcunskoHjcUmF0vWSpc5N FLr1aOonTzDNTqjCa3BZbotQlOscTOPPYIFu75SBpHhQ4fD3Ux1kn1ATmmDISCGSYS q8dM1W0w/u40L+0b19R/voQJrdcEuh1v1JgeadPx6Oqw6BK9OAiLnKN1scXQfFM0eZ yb8pYmgB5kjQA== Date: Thu, 5 Sep 2024 11:16:22 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , Kees Cook , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 16/17] slab: make __kmem_cache_create() static inline Message-ID: References: <20240905-work-kmem_cache_args-v4-0-ed45d5380679@kernel.org> <20240905-work-kmem_cache_args-v4-16-ed45d5380679@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240905-work-kmem_cache_args-v4-16-ed45d5380679@kernel.org> X-Rspamd-Queue-Id: 53E0220011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: y56gtwicgn1bjb6iquysgg6qrfs8fb8q X-HE-Tag: 1725524354-962151 X-HE-Meta: U2FsdGVkX18kSVfT24EwoENZNCx0BWJU2DOisq4S5OiVfXV568Ht7VSqkek3t3+8YnBxQWm0mzBcV8pPb8HkaE513/ezfVU6l6ZSita6uIJpmzjlznkg7Qi+zm4Icli2+G1Bgn3lufQSomvQk/zZuRIXnUmbgkD8n3tcuTiZukhIq8EFMOKUTTjGwdzpCynxT9ivYHBh+Ia5z9MZjtQm42Y+pTOiTNEcFuYyrprZd+Y42ZyBVcZWN4i9k687URz+yR/19tL2N+GbnPWMufThaC0LKuf36OJ7mPd4EhQLbF6/LpWfeH/5KpofVtHJ/0fPIeAW/gLKX+5eJEptsYPtwW94Ak9z2NdHPF0ExLOhtsw9tZFdwy9IJkpuyKxtHs3siJehDUbxyGLuL/3BIeDVRvgf4A/tUh0ov3dhY668OIFHwPULP1tdhw20QMHb4K486SOVz859zX3o8tJ915G3PwpPESMIJT3K7MV0Cqe2SwIK4i9aL9SRxHq77SaN+bDOFiCfAICLaW9I9vbe1EAWdiL8HF+na2Lz64wf9h22hli2IPDExnQ2gt35oplEF27D/vnAJJwyrdxVsbYPegWyLpAiF6MDco9gdB80Dq7TPd18D4GqQBjREpgB3vvc/jzfvEtkQ2fGHX4/Wt3+CZxShu0oe6QL5Gz/WAO15TqgYEVAq1THjrm3mskgNpZoRNgFqU+UZMw/zS7gfq+j1VLIvBUMRh90p9pw1R+mGi793RC09bvDdf2bMCsLoLgZw8vVm3A/8SnL4EiwnR6PFJuoH5m67hmaqlbVgOnfoz+HIEPRlid5ddKMsRKJc2AJFQEIn2fW+S2nbvDEGCMguyEB1jjwCnWNqgCLGZ0DBMzhYVUCMoC7M6mMpnEXJdpfYogLNcjwwPmd5/RMQW3aE6LSdxquRmcm1MSpmSJrX3LVUBsNZeVmnvmRUiphBWsNK7zKJEtFNBBQ9O1/pZqpUz6 xED1DPki jQxJdfTDV2ZfjRAmLodudP8agLV/9NbrmMKZBBNjFDO1rESIdApRrTO0gtBsNP6ujFVpXPb4WKMjfGTdf3jpJmZ1JnkzK+1Kxfbso/Uz/7EZEGD3aS+amnvmpFkScvN8NxMVZy4otuTK6VyB26jzciM0iVdCMgQgSDFr3qZyVpRmiB+bK78fj+OIIjyB52ofnm2TejMPre7xLrST/5/KazBoxc7b8o4PFTfl12WjFkRr3Xs6KzA+J6l3MDyTFJPAsbz7VnIoSHiN4uSUDPPadbV7uyqpO1QyCpb49liQp6tnQvjF2ZzVovMVGVc+dcPmrLtN9tq3rkLLAOGNYwsmpRE1GKEixawAqGF8SS3E097oYI8vJsmn+KOSFHeXFtUErk/2pfRxTzFCfoBlSUS3hWS5/gQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 09:56:59AM +0200, Christian Brauner wrote: > Make __kmem_cache_create() a static inline function. > > Signed-off-by: Christian Brauner Reviewed-by: Mike Rapoport (Microsoft) > --- > include/linux/slab.h | 13 ++++++++++--- > mm/slab_common.c | 38 -------------------------------------- > 2 files changed, 10 insertions(+), 41 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index d744397aa46f..597f6913cc0f 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -261,10 +261,17 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, > unsigned int object_size, > struct kmem_cache_args *args, > slab_flags_t flags); > +static inline struct kmem_cache * > +__kmem_cache_create(const char *name, unsigned int size, unsigned int align, > + slab_flags_t flags, void (*ctor)(void *)) > +{ > + struct kmem_cache_args kmem_args = { > + .align = align, > + .ctor = ctor, > + }; > > -struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > - unsigned int align, slab_flags_t flags, > - void (*ctor)(void *)); > + return __kmem_cache_create_args(name, size, &kmem_args, flags); > +} > > /** > * kmem_cache_create_usercopy - Create a cache with a region suitable > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 3477a3918afd..30000dcf0736 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -337,44 +337,6 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, > } > EXPORT_SYMBOL(__kmem_cache_create_args); > > -/** > - * __kmem_cache_create - Create a cache. > - * @name: A string which is used in /proc/slabinfo to identify this cache. > - * @size: The size of objects to be created in this cache. > - * @align: The required alignment for the objects. > - * @flags: SLAB flags > - * @ctor: A constructor for the objects. > - * > - * Cannot be called within a interrupt, but can be interrupted. > - * The @ctor is run when new pages are allocated by the cache. > - * > - * The flags are > - * > - * %SLAB_POISON - Poison the slab with a known test pattern (a5a5a5a5) > - * to catch references to uninitialised memory. > - * > - * %SLAB_RED_ZONE - Insert `Red` zones around the allocated memory to check > - * for buffer overruns. > - * > - * %SLAB_HWCACHE_ALIGN - Align the objects in this cache to a hardware > - * cacheline. This can be beneficial if you're counting cycles as closely > - * as davem. > - * > - * Return: a pointer to the cache on success, NULL on failure. > - */ > -struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > - unsigned int align, slab_flags_t flags, > - void (*ctor)(void *)) > -{ > - struct kmem_cache_args kmem_args = { > - .align = align, > - .ctor = ctor, > - }; > - > - return __kmem_cache_create_args(name, size, &kmem_args, flags); > -} > -EXPORT_SYMBOL(__kmem_cache_create); > - > static struct kmem_cache *kmem_buckets_cache __ro_after_init; > > /** > > -- > 2.45.2 > -- Sincerely yours, Mike.