From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F377FCD4F59 for ; Thu, 5 Sep 2024 08:18:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 795A76B01A2; Thu, 5 Sep 2024 04:18:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71EA96B01A4; Thu, 5 Sep 2024 04:18:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 598086B03DB; Thu, 5 Sep 2024 04:18:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 35B116B01A2 for ; Thu, 5 Sep 2024 04:18:00 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F2EFA161A70 for ; Thu, 5 Sep 2024 08:17:59 +0000 (UTC) X-FDA: 82529981478.02.6A9E610 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 48DC4140011 for ; Thu, 5 Sep 2024 08:17:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UtSTKHg5; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725524181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=McG2WdeSLyoDAkzpy7CySFQ8UMnBD71+eUYDj4u44Og=; b=UvEOidk8t503fix7h9HSgMSt2GsrjTTktD+Xza4dPHFhlcSHp/QvuZLlTS2Gfou+Wk9QY3 dD+bwFI6fK0WvBFR8HHkzrKGL9UUH+GWjpAyWWG6KvSkLp0oYxxk/WkNr3tQBOoPtcI4+5 vi5COUuiPOPCggtETkXvYje4HqglBOI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725524181; a=rsa-sha256; cv=none; b=X9Zq0BStqj2wZ6te48Sd/6bBNOYiLASoBvkpgagQAQxs7L6OeW1EqjguUXehTS/GUQ1cPW ygcIziP364EDYOnUKGxw6p0Y55dM1z+JxzEPNKO3tIMZ60wDvHDKD3pLlBneLARXECJcYP 8uaTu1mXUwpDq8fi5Ywb0uzqARRPQMo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UtSTKHg5; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E82245C5636; Thu, 5 Sep 2024 08:17:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F584C4CEC7; Thu, 5 Sep 2024 08:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725524277; bh=5TgCuB2LLe9eQrdVm1yMGNqreXfg9pwWN4AzFS2fvb4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UtSTKHg5Q6X+udB4GEEpwMf+I11xNOyg5uF1MvPWJTcIk07gM2iv+Pm/N60btv+fv hs1DfCN5GoXRDpn/+qu2QBuEAQ0syor9uC3j4czyn42vrf3lG7KpaHxe21hzwGcAfs tAAmGd1RL4lOg/P2B4hfR3ZUT1zhrLijDO/W95sKPIHD1iGtqJuy/7FJalpXJgMfiu g/WsqfJsCTKRM4ihaiXUiZYEsl3/Y2QG++WF6RR3Y+8XXLYXZ+FcgTS/oSJ/45LIFd xwgHnjEtUt1TEQY9aPZZft4Tg4gZAwrnQS//ldRSZNdaYv49tm+x5NGBZUXRiHIEBS 8ZbFh/AxHCkwA== Date: Thu, 5 Sep 2024 11:15:05 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , Kees Cook , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 12/17] slab: create kmem_cache_create() compatibility layer Message-ID: References: <20240905-work-kmem_cache_args-v4-0-ed45d5380679@kernel.org> <20240905-work-kmem_cache_args-v4-12-ed45d5380679@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240905-work-kmem_cache_args-v4-12-ed45d5380679@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 48DC4140011 X-Stat-Signature: h6obpbx83sxwjwwduk56sg5zdt7qhfij X-HE-Tag: 1725524278-943580 X-HE-Meta: U2FsdGVkX19h9rWohHimLjiuQzI2q18Q9bmW8VZByNGJeKO2R46YW7EreaFqahCEW2ttMtot8zGpWeciZsb3UX9VLo9xTag4vDAWMqgxm0o4ksZuYuv6na8UG5ACjKwfbdDCRvF1mpmaMLOw6R3XeYewRPLrWC1VnSWo1AZXAWoita8pC7PU8Abc2hI/wTheR7C4UTfd4bxMdIFcPHfKW2wNBdnw+UT6S9Ez89MV5ej/d8VdWtcajWzuez8mlhrdwZHobbJG0dcY1mL0ehtM5JVDPStp+n2KCQqa3dgvASO5tZ2uN4qG8zhcHDekQZSgC2vO0CO8V+/ub1lufDtDNUdbso9Rew6UZAf7jsVZs9/AE9u0isW76fvu9046F9dlzlt4zfu74fGZGMQBtVEVgDHlWfy5U845hEWu9BqFGSt9H97kSUBG82BQRvZDZO9FNydz1CkJsD8LQ1PBhY5bB41+MnnKWC47Ls87c/bD9M49U2k7u7k+/kjOh9irEe09dpE5Pf927lSDaVzDJrKPaoA5VwByrXvIkm5webIzb2LvE18UjaC6nMBB4ICglgMtOcQDB6+MVZNwVxIVlY/eROiq1dF4WYYAMax+j/0wJ7vOMMPa2n4pTPkTIOIgnPDdUgvCKKMvms1uZrpDRddfQM2uK5x7JI8rJytxd3IU7M4MpKeEBa7RgLnqH0/5tQDy57MNLto5Gu7e1eJSvBIYCrk0zK8OeJpIgq+M4S8rLH4ZauAuzyUKlaaW+tcwriqfoMPiQGR+imepzYA2JTaigU0itLU+v4yMMXOuR1/fl++OnPUp2eUmRaKTNkWKdXPU8IG5p7zsjneRv+BakSujIn7D3cdB14StUCp7bNs2webRKXL8sd3zT/GW1zP+zuy5nzZybgbS9D3YQPyOP2qDBV5hYZsI+ewOUSlizMq4QeHPJ54jNJisCprwh0HnsIbYulJwVtJTwVu0TqLMrWO wwL4eq21 2RmBtN0sPYya4iUwFmxP9X1pNXVe9pfbEF2Ru6voRU38Rho5hy9NJF7zhLcOGwt9t69bMUJ87boXi5b1f925DXCVaLwp0r1dkx2vQm+dGTGEQXm6c0wqnB/cNjxlUfK8wIAZIGm39I3kDbZBEiXUDZ331+zZzM947O32J0fZ63mySTXS1c/nvFqpNyYPaC1lkCqUqT6HQuFMilC9+Ik1efydS9O2QK+0Lq8pAeJpZubLP33y17nj7y7qEuhvNsDP3YwySCoXlGHc5GtmIqF6JTfPA1qSt6cXSxRRdA6YnM16b9qmW/PmpMk8/DLB0lKssaJCxC2ctjesUWzlCTCistE4Ux/4pEuZFlraJB1/wiXt/YwrJeXrAr060M/oEs1knrj51S1CoAYR/YOjBBB6RH2AnKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 09:56:55AM +0200, Christian Brauner wrote: > Use _Generic() to create a compatibility layer that type switches on the > third argument to either call __kmem_cache_create() or > __kmem_cache_create_args(). If NULL is passed for the struct > kmem_cache_args argument use default args making porting for callers > that don't care about additional arguments easy. > > Reviewed-by: Kees Cook > Reviewed-by: Jens Axboe > Signed-off-by: Christian Brauner Reviewed-by: Mike Rapoport (Microsoft) > --- > include/linux/slab.h | 29 ++++++++++++++++++++++++++--- > mm/slab_common.c | 10 +++++----- > 2 files changed, 31 insertions(+), 8 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index cb264dded324..f74ceb788ac1 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -261,9 +261,10 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, > unsigned int object_size, > struct kmem_cache_args *args, > slab_flags_t flags); > -struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > - unsigned int align, slab_flags_t flags, > - void (*ctor)(void *)); > + > +struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > + unsigned int align, slab_flags_t flags, > + void (*ctor)(void *)); > struct kmem_cache *kmem_cache_create_usercopy(const char *name, > unsigned int size, unsigned int align, > slab_flags_t flags, > @@ -272,6 +273,28 @@ struct kmem_cache *kmem_cache_create_usercopy(const char *name, > struct kmem_cache *kmem_cache_create_rcu(const char *name, unsigned int size, > unsigned int freeptr_offset, > slab_flags_t flags); > + > +/* If NULL is passed for @args, use this variant with default arguments. */ > +static inline struct kmem_cache * > +__kmem_cache_default_args(const char *name, unsigned int size, > + struct kmem_cache_args *args, > + slab_flags_t flags) > +{ > + struct kmem_cache_args kmem_default_args = {}; > + > + /* Make sure we don't get passed garbage. */ > + if (WARN_ON_ONCE(args)) > + return NULL; > + > + return __kmem_cache_create_args(name, size, &kmem_default_args, flags); > +} > + > +#define kmem_cache_create(__name, __object_size, __args, ...) \ > + _Generic((__args), \ > + struct kmem_cache_args *: __kmem_cache_create_args, \ > + void *: __kmem_cache_default_args, \ > + default: __kmem_cache_create)(__name, __object_size, __args, __VA_ARGS__) > + > void kmem_cache_destroy(struct kmem_cache *s); > int kmem_cache_shrink(struct kmem_cache *s); > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 19ae3dd6e36f..418459927670 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -383,7 +383,7 @@ kmem_cache_create_usercopy(const char *name, unsigned int size, > EXPORT_SYMBOL(kmem_cache_create_usercopy); > > /** > - * kmem_cache_create - Create a cache. > + * __kmem_cache_create - Create a cache. > * @name: A string which is used in /proc/slabinfo to identify this cache. > * @size: The size of objects to be created in this cache. > * @align: The required alignment for the objects. > @@ -407,9 +407,9 @@ EXPORT_SYMBOL(kmem_cache_create_usercopy); > * > * Return: a pointer to the cache on success, NULL on failure. > */ > -struct kmem_cache * > -kmem_cache_create(const char *name, unsigned int size, unsigned int align, > - slab_flags_t flags, void (*ctor)(void *)) > +struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, > + unsigned int align, slab_flags_t flags, > + void (*ctor)(void *)) > { > struct kmem_cache_args kmem_args = { > .align = align, > @@ -418,7 +418,7 @@ kmem_cache_create(const char *name, unsigned int size, unsigned int align, > > return __kmem_cache_create_args(name, size, &kmem_args, flags); > } > -EXPORT_SYMBOL(kmem_cache_create); > +EXPORT_SYMBOL(__kmem_cache_create); > > /** > * kmem_cache_create_rcu - Create a SLAB_TYPESAFE_BY_RCU cache. > > -- > 2.45.2 > -- Sincerely yours, Mike.