From: Charlie Jenkins <charlie@rivosinc.com>
To: Chunyan Zhang <zhangchunyan@iscas.ac.cn>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH 2/2] selftests/mm: skip virtual_address_range tests on riscv
Date: Thu, 12 Sep 2024 20:22:15 -0700 [thread overview]
Message-ID: <ZuOv55YsorfvhlQi@ghost> (raw)
In-Reply-To: <20240913022635.751505-2-zhangchunyan@iscas.ac.cn>
On Fri, Sep 13, 2024 at 10:26:35AM +0800, Chunyan Zhang wrote:
> RISC-V doesn't currently have the behavior of restricting the virtual
> address space which virtual_address_range tests check, this will
> cause the tests fail. So lets disable the whole test suite for riscv64
> for now, not build it and run_vmtests.sh will skip it if it is not present.
>
> Signed-off-by: Chunyan Zhang <zhangchunyan@iscas.ac.cn>
Which tree does this apply onto? It is failing to apply on -rc7. Also,
since this is the second version of this patch it is good practice to
put v2 in the subject like [PATCH v2 2/2]. Anyways, the content of this
patch looks good!
Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>
> ---
> tools/testing/selftests/mm/Makefile | 2 ++
> tools/testing/selftests/mm/run_vmtests.sh | 10 ++++++----
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
> index 84573ddfcfa2..912778347213 100644
> --- a/tools/testing/selftests/mm/Makefile
> +++ b/tools/testing/selftests/mm/Makefile
> @@ -112,7 +112,9 @@ endif
>
> ifneq (,$(filter $(ARCH),arm64 ia64 mips64 parisc64 powerpc riscv64 s390x sparc64 x86_64))
> TEST_GEN_FILES += va_high_addr_switch
> +ifneq ($(ARCH),riscv64)
> TEST_GEN_FILES += virtual_address_range
> +endif
> TEST_GEN_FILES += write_to_hugetlbfs
> endif
>
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index 03ac4f2e1cce..7caa624a2e5a 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -347,10 +347,12 @@ if [ $VADDR64 -ne 0 ]; then
> # allows high virtual address allocation requests independent
> # of platform's physical memory.
>
> - prev_policy=$(cat /proc/sys/vm/overcommit_memory)
> - echo 1 > /proc/sys/vm/overcommit_memory
> - CATEGORY="hugevm" run_test ./virtual_address_range
> - echo $prev_policy > /proc/sys/vm/overcommit_memory
> + if [ -x ./virtual_address_range ]; then
> + prev_policy=$(cat /proc/sys/vm/overcommit_memory)
> + echo 1 > /proc/sys/vm/overcommit_memory
> + CATEGORY="hugevm" run_test ./virtual_address_range
> + echo $prev_policy > /proc/sys/vm/overcommit_memory
> + fi
>
> # va high address boundary switch test
> ARCH_ARM64="arm64"
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-09-13 3:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 2:26 [PATCH 1/2] selftest/mm: Fix typo in virtual_address_range Chunyan Zhang
2024-09-13 2:26 ` [PATCH 2/2] selftests/mm: skip virtual_address_range tests on riscv Chunyan Zhang
2024-09-13 3:22 ` Charlie Jenkins [this message]
2024-09-13 3:41 ` Chunyan Zhang
2024-09-13 3:16 ` [PATCH 1/2] selftest/mm: Fix typo in virtual_address_range Charlie Jenkins
2024-12-11 22:32 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuOv55YsorfvhlQi@ghost \
--to=charlie@rivosinc.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=shuah@kernel.org \
--cc=zhang.lyra@gmail.com \
--cc=zhangchunyan@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).