From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05FFAC3ABAE for ; Sun, 15 Sep 2024 21:39:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CA9D6B008A; Sun, 15 Sep 2024 17:39:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 179706B008C; Sun, 15 Sep 2024 17:39:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 069136B0093; Sun, 15 Sep 2024 17:39:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DD63A6B008C for ; Sun, 15 Sep 2024 17:39:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7B963160124 for ; Sun, 15 Sep 2024 21:39:31 +0000 (UTC) X-FDA: 82568289342.22.8A4F920 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id E707D140005 for ; Sun, 15 Sep 2024 21:39:29 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qTqfmSy7; spf=pass (imf26.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726436261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KH5uiZ+HS8dLTpmEagWZDl3ZDgSyJhDYq9qBWREabHc=; b=VX6bFHmucvIs2k0AqcwCaTYBxOJPtUY97KkMNeULIySF9Q9vtbaqQFlh3LdPr9/B7bPSqg nnHg61+Wrp2zbdWqM+Ctqx/YnN/iymyO7v71kZxljL2IUQ8tPL3zKBYjGVzuoxtf3wjjNx P+KbBTNTE+1O4yTs7SWp1ieicUnGelo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726436261; a=rsa-sha256; cv=none; b=yZRTxMF0J/BAJ7TDTrLzIuxvRcJafg7//tx0L9p8byQ+MDpRn8Ww2uE6OvtZYWtARn42kC FhtN4ZU83ZC8KzVBxfnWCDZFDzF9TMQD8MjEUI94egmqA8n02CacC1WPXTNNaqr/tEEfm5 Zknf7xzh6dMotlKwroGGM1+0BIP1noY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qTqfmSy7; spf=pass (imf26.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8F1BBA413F7; Sun, 15 Sep 2024 21:39:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45890C4CEC3; Sun, 15 Sep 2024 21:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726436369; bh=2tMEMi7GDfUlc10rGRCBy0hqCwf35bAn1XHWgMvXlAQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qTqfmSy7Lm/hqHWNxGA2z+JlpAn/bHpscxEWXY+VjA9ub2iEnlU044M/b2uJAZImI 0fHM6e/uCVbPbvi2L6hF1rExcgvK9S2eHr3qKX2MO+L4EDuzIJgU+zCZ5HnR+EfeHF NkdXxH+14HMuV0PVKjDrf/9DlmJ37UHO53JoIrmBK5en2uAMuBv1pAgxXKVO4+ExLt 64hezwzEcegWfmTKzMMJRfKT30hIDPY7AFORMd105TfOZToWhlsmjrtLYGPjY8dSZn 7+5XBczmDeleb98FVY2wNvkBmcz+EInr1Be4kUBQAxPEmfADgpv6gklL1rlvTAs2xS FbLOR/sATvhzQ== Date: Sun, 15 Sep 2024 23:39:21 +0200 From: Danilo Krummrich To: Gary Guo Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v7 01/26] rust: alloc: add `Allocator` trait Message-ID: References: <20240911225449.152928-1-dakr@kernel.org> <20240911225449.152928-2-dakr@kernel.org> <20240915162813.149e21f2.gary@garyguo.net> <20240915202242.7a16b3d3.gary@garyguo.net> <20240915210827.3ee9adcd.gary@garyguo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240915210827.3ee9adcd.gary@garyguo.net> X-Rspamd-Queue-Id: E707D140005 X-Stat-Signature: 43h6bu697pcd4gmc8jwjxd4d8pz3myrj X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1726436369-77629 X-HE-Meta: U2FsdGVkX1+BcUkgq3gn8DtwTqo+ADn2VCwfdczIwvYW4qZnxvslyvS+0o7ZHoLgrQVmmOTFrZ1VOObzTjcSxUnFqGr6kbLu8ntY4cvzsE1Mdz7WFwTOgRje16KmpxzDY4WC76SzhXObTUKL42uKrbPn4ts8sdhF/4UnFN3r9JteTbIFzfTRZK3KG21d1eL3mglVNK0rcKu4PJLnfJBRxCvw3DKJ4GNxkwUzJV8OSYZZEjVCWZ4jYI0H7jfw4NUiyNKD36pd6peVCBcczXVbMTwghu1ZIhJb/tOyCfMN3rkbxq/iVNTEPm/umsCaYMi1WfXgY9itDOaowrBDvUSsx0jOggKVPmtMDGU28ad68BfqSrW90qdbz40lOvynu+dlcGbJsZ0QpViLToeQ74bJK+fBa5UwD6EXk81PwZhhqJHkzWKtpJMeB72K17+bAG//e4BMMCltFWoOrLKxB5w1U0NPF2bWbetDbeCDfdzSh45gDeKmf8lY7iFGkwkL+xz/L59fsvBfNvv0V5HjrjDYuZkAHlNT/rnAoE9iDp2et5pLAhLMkR1p1C5LzgtDWDyNkvTPk74nJVvNMwsLfgKjduVKFUuSFu2n7TtqsQt6M1R1vXHN79paObeEgQyaBb++7jerSXyRCGfhCohAcwXXVQokFw2OR/iQg6ONzao8hidO1/p6yB4rQZn1aCPdFUEizGRw3Qjgxfb3t6Oa40JcWFeAf8byOATFEmpXOkIX6vLU+1YdSwExbW9uIT0YOY4YEiiD8Y7GPAonwf9a99iF4R7o5snnB6FKkTkulwV6Lm+YN3d+3nX/080iWg8MSYH7PTi0V827gqUxT2DsofbBpo/nbFZoAkVOqd9PenMGlOk+dr9groXQx1bha8mTsOaBkJykCjEDdtB60bkicY8qMfyXOaEQNPc0COEB6DqVyKldePPHTAZG03f6Z1Nd6BROg4NrgNLP+3MH7n4ce0w /3I5uyq5 J1K3j0eFAhuml58MhcwC2DO3L85JkLbT1qynRrjOHv2sg3vO2E9eRL/3g7x9SaVSRZssA9RApRZ8Qx8iWEBs845xmQHNdv2m+ZLRCtQ6T7zJ1z6k5oj76W+MLx49LBzYNuMpspTMTCGcXyeyChwH3vlTTItZu6spagVcayYKdsj4qPfGJij4Tmm0dM1jdHzaJy/ncXi9hK8ijV0yW6m20eQYlNx5m6g7x+axi36UY1er6F2K5vQ+nuk+dGUwqXkFjRxFVf0esVJnIgt3hnm0T513h8wCqTAM6QdcOXkoT8kcThGLYUaWFOafwRuCxXxb7zQGQEaP2V3DuB25/rR1Hq0Ym4QQ+on3JBlArVe9qUS1w0Ftl8htIXGLwnY1fTACnqaIy79YhCi6ipBw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Sep 15, 2024 at 09:08:27PM +0100, Gary Guo wrote: > Just to add that if you *really* want to avoid the old layout param, > another approach accceptable to me is to have a `NonZeroLayout` and have > `alloc` only accept that. That is a good idea, I like that. > > Either `Allocator` trait handles ZST well or it refuses to handle them > at all. No "it works for alloc but not for free" please. I agree with that, then we shouldn't handle them at all. > > Best, > Gary > > > > > > > > > > > > > > > Reviewed-by: Alice Ryhl > > > > > Signed-off-by: Danilo Krummrich > > > > > --- > > > > > rust/kernel/alloc.rs | 112 +++++++++++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 112 insertions(+) > > >