From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26BCECFA76F for ; Fri, 4 Oct 2024 12:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2CC56B03AA; Fri, 4 Oct 2024 08:04:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98F2E6B03AB; Fri, 4 Oct 2024 08:04:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BAF86B03AC; Fri, 4 Oct 2024 08:04:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 598946B03AA for ; Fri, 4 Oct 2024 08:04:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CB1021217EF for ; Fri, 4 Oct 2024 12:04:14 +0000 (UTC) X-FDA: 82635786828.18.567E962 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 2065B180006 for ; Fri, 4 Oct 2024 12:04:12 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LU6PQ0jA; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728043412; a=rsa-sha256; cv=none; b=6vkFrnT8Y7RLykSSLhI8TYRT6bcSs4teK940+Pe+gHv2B5mzHhNY5T20JOhVyYYEEls7CF 1jV5tAuKtVIei4kn0iW2IB3vdfW5dt2qN71twotwkQ4bvxvcPbgK81CO5folizIEDfbyoo RCDf+ukzQlm5tcgq3y+hDErDAdyecxs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LU6PQ0jA; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728043412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XYnWv9+EAXGrwgC5EWQEZNiZXnwu0+IfQDPZw4I+zB8=; b=LORq7zJojKGhjLLNS+TIcPlWLA47X3G07+jQqRGT5FkdvMf/1+gkJFJUFEyZu2fGNDiEjX K3bXNvS2pOvyFmHlcYP94Ar670m1hFFxX9fhhvLTmFGlmwhR/q764E1x5PKpkJwnFSoiOF HjWITqx+OLYmbPR2z2DnziIUl+2qHPQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CA6AE5C5E26; Fri, 4 Oct 2024 12:04:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B609FC4CEC6; Fri, 4 Oct 2024 12:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728043451; bh=OEW/TsqnqgLFx9h4HePvE4V09nvFPccYDELGmyxvkzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LU6PQ0jAsXyGGohI/eId0raGTWH2LhKRjheq42e+U/ExabwOAq8NOU5sfkZfJxCtt /lToZouDXj5jUhQQXARqXRsej4ANMMTVOMaeJigyU3pgFKDsZ0KqDoiXsOfZkcYGs/ 0q+GNTsayXk1n7Qji5aXoUJN0NiEKyy8mRo43jJyC4sd7qeXc09Jn8TZn1pr+PiWDr 0IK4Kmn6Z8VJHt2c9hPuDBA1qOhxVtE+SvzjCX27txnSMfjnzqv5LgoTWef468IPCC bpDZ6mTDUrP8gl9BV7EogUeDBYF5ow9G13ZjVXm/D5BtvlBbx3TYeit951PiqZMQrQ J0KAZtGWaCy2g== Date: Fri, 4 Oct 2024 14:04:03 +0200 From: Danilo Krummrich To: Miguel Ojeda Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v8 11/29] rust: alloc: implement kernel `Box` Message-ID: References: <20241001150008.183102-1-dakr@kernel.org> <20241001150008.183102-12-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 2065B180006 X-Rspamd-Server: rspam01 X-Stat-Signature: f8qmcphe8dtqm7g3eaq9xftpwrqo7aug X-HE-Tag: 1728043452-499707 X-HE-Meta: U2FsdGVkX1/XOCVHjzuK/qQfSxQAeGqkez37NwRQ673qg0iEwlNlmywJ/HT/GZU0eoMlBi6iD8CFany0N9+Fi5l1l32xMZkMMvZIrxmul1bLpubPBwbrEi5VXGd2yP0e25LegJF+msB2DiUQ78beGFsVaTAXToMCGEAqKlV1VazS5kRzeHjgQ/dWAqxeGXygXGtzU3ZGtKpeWA9XXcue/6UfjY4XN/MKrAL6NRYcMkjHl/oNbZrI9wq/pTbZXIR6POn53ZhfEJkVf6UI+uKtl8c6iv5Scc3+ZWRkQmLuTP8PIAqBiInv1yBJrFo4gyj0Lthv0UZXbsBb/ircSMVX76h9s8CdH7hE6FvTl8m7mRBwWoNxuHvSy+bXlMOEqHfUXxPm3Vp0bj5mpunJwk1RYLp93INFF5XTX3E+dtMztHKUpSGo9+zAVz9vmcgSQaLMzibBp1Fmap7PYoV/6VPEn4jwUDrb4YlvHMh2SONgR3IE74/m6DpPxIM/+TCClJ41tGzxjF+Dq3BPxsH4mkxo6y/y7SU+By04nTmVGlpDbk/zLb4VifaTYHcen3M6bUJMGLgUeWjBbGTew4ZSOsiZ0JggFC2IeQVnZT8psgIDrM7ljHEdH2fr4vf4h3KQGQq+RbOjfnxTGlOSqgxQUHDBbE1RECzZ1oo8QoOBITm1tom8XkuXtoWP4uCksOnCjk2XcqJqn3vndszn56LKzrerwhmuQ9FkVKJxyauXf4UtKmSkgzjYyk90IqkxaSFM6XE20Y9DHMb861MTrYsnqCtMXeKg2dN2kv1fPIwGXiYf23sxNsy7PedM7OU0QgMqjZJ+uWvZQ8EZeTFwR/d8AVi3kAw2mTXhzFqAIzv9RelJz8PuuLBkbwZV0mTXYdSYJeEBVXbKU9sjk4Q82SA7SoSKzN79wirQGLc7M8tHvtzvipf+QmNOmQukOw6nNnWzqJGckMvaBFowM+b7gj8nyu9 NtFJVQTK zb0MW24u5kggQpNajK/5xaZcmQ1rJmqBpg3VYvOV01rty13JMk4esyatmmtEP1DvAcWlEXd56Y77yAlB+t+oJtGjE8BE9ZqYnA7Lz29SU+S9ZVGC3wn8vdRvfMZj/Ir9OmDd30ERrb4gh26Z66pldqSMmXsyNU67kPYlzIIC/XmQqY1+62CCUwFpQbuEh75mvZ9RAyijGXUeC03LZc9BYjYUof5wrZebLieUKfq482S1tuqDPUYVZj5G5Y4eFAgqn6md0pFQ3DSCTXQlQhZb3Y9xgXO5zgJrYs4XjOm4WDX7sxg/FcXCiChdKilVGaWlzLN2IBpHs4+0tNwX4mOU6MEV+Cs95PbUBSOg82juO5RS94l5wYw50wytdVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 04, 2024 at 01:00:51AM +0200, Miguel Ojeda wrote: > On Tue, Oct 1, 2024 at 5:01 PM Danilo Krummrich wrote: > > > > + /// # Examples > > + /// > > + /// ``` > > + /// let x = KBox::new(24, GFP_KERNEL)?; > > + /// let ptr = KBox::into_raw(x); > > + /// let x = unsafe { KBox::from_raw(ptr) }; > > This is the only place that, after applying your series on top of the > lints one (i.e. current `rust-next`), triggered a missing `// SAFETY` > comment lint :) > > If there is no new version, what do you want me to write when I apply it? diff --git a/rust/kernel/alloc/kbox.rs b/rust/kernel/alloc/kbox.rs index 5d20f6112cc2..ef1add933f60 100644 --- a/rust/kernel/alloc/kbox.rs +++ b/rust/kernel/alloc/kbox.rs @@ -147,6 +147,7 @@ impl Box /// ``` /// let x = KBox::new(24, GFP_KERNEL)?; /// let ptr = KBox::into_raw(x); + /// // SAFETY: `ptr` comes from a previous call to `KBox::into_raw`. /// let x = unsafe { KBox::from_raw(ptr) }; /// /// assert_eq!(*x, 24); But maybe it's better to just send a new version, to also fix the missing `#![feature(inline_const)]` for `Vec` and missing import for `size_of` in `ArrayLayout`. > > Thanks! > > Cheers, > Miguel >