From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36BA3CF6495 for ; Sun, 29 Sep 2024 14:52:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B995B8D000C; Sun, 29 Sep 2024 10:52:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B47D46B0246; Sun, 29 Sep 2024 10:52:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E7918D000C; Sun, 29 Sep 2024 10:52:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7DACD6B020F for ; Sun, 29 Sep 2024 10:52:32 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EA440AC94E for ; Sun, 29 Sep 2024 14:52:31 +0000 (UTC) X-FDA: 82618066902.22.1606D9D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf16.hostedemail.com (Postfix) with ESMTP id 594BC180006 for ; Sun, 29 Sep 2024 14:52:30 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JQdwPrhL; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727621512; a=rsa-sha256; cv=none; b=oat0tNix6bjXCFbPlvX2mCMpyzggiJYvlWb6sxjKiMg3IiJzmAaf+PXQyFJFd1at7Hia5z cDmFgItBcug+S2pe1CY3C01+ICev4BjxIv3xzx5L2cAUup2avuJPYK7SlfR3VUqlIkukld ONyJxuXW6ybEv51CVA23H1CXxG1B5eU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JQdwPrhL; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727621512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j0fpx6+jOCSDf/qdMJZ8to4znYfSZDHjapB+vRwRFYQ=; b=PSp7eRbPqjjJCdps/qx3zEzoxlLpVN3lil6hsHzhVsyRxqFbcffy11j1fmdXwlz7OdXKFd rb7ZVzYSyRbDoiqx7hD7f7sB/WTohWV6LJ+n44sg90FhxfMiHKynpChQacG6C5OtBwvWTw UshSphw439UOJsW1GY2WMA5UAAyLqAM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1AB36A40DEC; Sun, 29 Sep 2024 14:52:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E881C4CEC5; Sun, 29 Sep 2024 14:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727621549; bh=KCzOpXBaRXTqzAhkCrLfiC9LHlzekTchiyskk2fq0FU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JQdwPrhLu3Mh8AlZYHEjdJFOe8Bi5q3qapODOo690Hb8/wjgQhe1Gx8WILJ9ikULa yMgf49TyiRSk5r2bjvzzNZ4DRL5PnxIrAba9IDO4SxmdrIk5Q+p4Eauqxj3lHG7PIo BT4JT+0ZV52FAiTdLKMeUTTC3dzfalNObRi5IaDVyFdPOztazsB5NeI+MN+C7BKqoK PiNBBu5Mm06+IQIEyWnZdHCFSvBsz/w2C0X/vFlMwxLsDZFOgkq2/gNvmCQNFt3avW gP4ynf9a1qZ7FV4bmh9Gw9JZOKT9cAbY/jT7graoOSbDtgQ2p314lbyFwpw6LD6TDu 3ia4MLo5HoTtw== Date: Sun, 29 Sep 2024 16:52:21 +0200 From: Danilo Krummrich To: Gary Guo Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v7 10/26] rust: treewide: switch to our kernel `Box` type Message-ID: References: <20240911225449.152928-1-dakr@kernel.org> <20240911225449.152928-11-dakr@kernel.org> <20240928195913.5b2c04d8.gary@garyguo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240928195913.5b2c04d8.gary@garyguo.net> X-Rspam-User: X-Rspamd-Queue-Id: 594BC180006 X-Rspamd-Server: rspam01 X-Stat-Signature: dijifhyhwbz485zpw7stws8htw5sajao X-HE-Tag: 1727621550-89396 X-HE-Meta: U2FsdGVkX18jO0Edet/NEYa8Qw/55ADSTam3kvoebjz99ex5igY/JU/RI/yT9YclYopEn4fxWUGg7P9rvNexf5BD0sEMh2C7sMXohXjlMeOqox7MtbSvbY06+gNObDUchhZUzFmfOFl+dg2jQ0qOZa/xKZ8z9KJNHJp5hj6Tyvbj2oGy11ELtFe/tdx8JBzlj4j4TlQu+mkdIQMiAO7bEKNU9SsOzheRHrStpvO6pG5NFjVx4ukcMZISfFaa4Kiz0jETtfHOdDAFkA2IlIwAgzZ/HanjEUo0CD1WOBayFE3NhpIrntZDXBJsrNX0ehoRkzSaPaJECbFhyzbOFbZLJkq5MXqGcI95nRoaH8sCVRhkPk653OyDnE6eCioE2kVumvD5J4+j82YgEbo6OPb6gP5o+44cHRgnQIz/nJcCGguxByGbV7hRkBPMxbyrx4tw9hcSquMFyZuxOLjsUUF8ZdIkHoEzyRJhAkPBosvw30K6KQ6RZrc5oiS7BNE5HKPmNS1t2fat79kWspUvd2JOQ0aW+GmV1q3MT4W/8SKlvW55dIBpzqiaYDbKWxvk07y/YN2cIjPAMKd7sMyw26UA/ci1PDfGN4q1TjKMiJVqgHN9d/yXBKJuai/sFFLshCrWXc/vPynLuMk3m0CPSl7S/XoD5qrAqd9lrXhOKNUOPyt9QWp7a3EH3tu6Pqy1XXaet++/Oe8CYVGSKqbE1dJt7mJ9crPqxtM71/G7A00jgFHfWdaq8BW7X3e8KsFhItndCzX2eIJ37K8n8wKSBvpyWkIgcWILEC8qeWmz/Qf4uI1+c6JdqbuWo1xesgVAR/Y0JVmfpuSQCOFeTUWA252Jojdun2zLPtiI3eL3EtBe/lkZKvJghbcYIlXgNEfIAY6DSI8LffGawhzZMLVfClABoQXV9AhrbZdzkvwXwwYrOCkow7UjcyLplQZKL8AiDWXIDOQRvgh3v8izb+DUsdl mo5ssILv uluWDtKJJocjmB3ir+TR15xpTpz6T6+0Hd5U9QtWl5M8fWeuD3Ed+HjWaHcH0rGw7OsAHuH5lnEox+Q4FAKti11K5zR9gJ7/mp0JWnTpAoMTIZWrJXhRaLVtHgA0cjA1DAaO7CZAzjWgAmB9dw6Zml4zKulri3ykTDRpFuJQzlJAbCbiOnOMqePsUVzZei10mGzk+/CKcq9QNimL5/mlD4rIjlGNxA1IGF+Ey3n6MzodWXILdR1pMfBGJKtiWQie271hQQVpQDAGV3ckOh2VL43TI6ZZ9CyzVA9dyHy32wlAVuCoFW8rbbbCf5UHAngk46jkHDQcPuQRmFZUAqnaJyZxh8r7Rqu+PE6+/5s4hCLT3rqJw6U8fIha8zGuxa5H8eVHbNBU73mBDwFxRqOTNoVhRKRSguuSFKOHYe4oWxA6jfwE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Sep 28, 2024 at 07:59:13PM +0100, Gary Guo wrote: > On Thu, 12 Sep 2024 00:52:46 +0200 > Danilo Krummrich wrote: > > > Now that we got the kernel `Box` type in place, convert all existing > > `Box` users to make use of it. > > > > Reviewed-by: Alice Ryhl > > Reviewed-by: Benno Lossin > > Signed-off-by: Danilo Krummrich > > Reviewed-by: Gary Guo > > Have you considered defaulting the `A` in `Box` to `Kmalloc`? This > would avoid doing a lot of tree-wide changes. > > If you have a reason against it (I'm pretty sure you have), then > probably you should put it in the commit message. Yes, I want people to be forced to make an explicit decision about the allocator backend they choose, because this has relevant implications. For instance, it's likely to be unexpected to people coming from userspace Rust, that (with the default of `Kmalloc`) `Box` allocations larger than `KMALLOC_MAX_SIZE` would just fail. > > Best, > Gary > > > --- > > drivers/block/rnull.rs | 4 +-- > > rust/kernel/init.rs | 51 ++++++++++++++++--------------- > > rust/kernel/init/__internal.rs | 2 +- > > rust/kernel/rbtree.rs | 49 ++++++++++++++++------------- > > rust/kernel/sync/arc.rs | 17 +++++------ > > rust/kernel/sync/condvar.rs | 4 +-- > > rust/kernel/sync/lock/mutex.rs | 2 +- > > rust/kernel/sync/lock/spinlock.rs | 2 +- > > rust/kernel/workqueue.rs | 20 ++++++------ > > rust/macros/lib.rs | 6 ++-- > > 10 files changed, 81 insertions(+), 76 deletions(-) >