From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 523C2CF6499 for ; Sun, 29 Sep 2024 15:14:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D65518E0003; Sun, 29 Sep 2024 11:14:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE3788D0002; Sun, 29 Sep 2024 11:14:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B850F8E0003; Sun, 29 Sep 2024 11:14:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 949D98D0002 for ; Sun, 29 Sep 2024 11:14:20 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 079B8C148E for ; Sun, 29 Sep 2024 15:14:20 +0000 (UTC) X-FDA: 82618121880.10.BC2C8AC Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf22.hostedemail.com (Postfix) with ESMTP id 76BB8C0007 for ; Sun, 29 Sep 2024 15:14:18 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KSvZqq8x; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727622757; a=rsa-sha256; cv=none; b=1vHC0Pcqf7i1o5Z7b1xqGjdS+TsWqgh3NGY2snY2FfekQbxakjWt/+XoH1FHHmkv7Vgg6N SICCtnyW0z+N1tHcQTjtzFJvBwDR0SOQmxRAU4N0gafGTI12Kwuuztok5c6E0AHqhu7Oy6 4A4GjC9IVuEOSfyRxal/ge6meVByuNY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KSvZqq8x; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727622757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YZ/Lw/O5HOr8jCk88ZEC0JnoVrnD6gSUwjLM5sndvUs=; b=wS3ErYKfYXZo7xzeQORclnqmppj1cEUQcn0d4I7c/gltKEteRCZ4yjzP/bGYlwG4CLI8VY BJZLP6Ic3CIKPor2jxZ11GV7Nr9ILUPc7WrBBAn5peHI4S1HuOpiFG+mWARRwgquNCPa0E NZSbMtY6ggXhVGYYa3cKPxC5bDYgOTA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8ECDEA40D98; Sun, 29 Sep 2024 15:14:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B43A2C4CEC5; Sun, 29 Sep 2024 15:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727622857; bh=oaEjX3/xGXdgWu1xJM0CQYYIlbcXuyVjwzYezEaTK2M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KSvZqq8xyU7vmkvUjAT5SUzXcgvhtaPJ7/R/T4WWUhExlPsjWCZsClCgIqlwnJPJO AgwnZ8tnn2qCEaYhzeGP0rEQXLLgXDVpYvJiK8IiwJhGwwfVpA6s5xF+o3z/RoNaPe zXuOoumeZwQ9EAYPdpqT9E20zatm8dG3MFREr8h22TJrZuX7Lk8/W/TU3XeVmKr/hc JiQ+ECx1ShPAeTrqsPoHMC0r/KvSuzsenAFnwsz/GjLYXdkRoBStI/VuHdrWeFEziN 8lA7mDU0c7Bhxos0OhBforeSi98kPMJf4yGHaZiMIhrzlQV59g8g7OP5IlGI7lIPop p4BQgAafAcrOA== Date: Sun, 29 Sep 2024 17:14:08 +0200 From: Danilo Krummrich To: Gary Guo Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v7 22/26] rust: alloc: implement `Cmalloc` in module allocator_test Message-ID: References: <20240911225449.152928-1-dakr@kernel.org> <20240911225449.152928-23-dakr@kernel.org> <20240928203552.4d490ca0.gary@garyguo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240928203552.4d490ca0.gary@garyguo.net> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 76BB8C0007 X-Stat-Signature: wugsyat3mqo34u9cenrd3go59rm88q13 X-Rspam-User: X-HE-Tag: 1727622858-561317 X-HE-Meta: U2FsdGVkX19XPLlmnnt7Eq8Nbn+uAXGeRgGZvQOmTijsTanTBoooW+0razBFtJ2pne6yo2Ueay3YkRhdS8eiSlkqIdE0YSj/7lXwksQLPWFHNS/AgftZP+IYmuuZhARzZHzedpB7gf2A1ida4NPDCPpPtJMGLxZOA0NCWTuqh9CqUq04aGv8YRVMulTqXnzOWuNe8OVgLGdmVBnxkKZxS8ZVOnRbXERCqyylJiqG3bnZr20GnUlFkhU/Wu5yAiJYI3MJ61kohyNxhuHsayx3NRAZJdNDrbnX5ab1/XJXFplJEZ0XG91E2gZtRKNHaOx2JtN5fQyoEuuJDAKYJPs3D9mJHF4A1Cqhs+2GSR+ulgBz6d7TnngWTzPzlpVB+j983lDMAghi1x+PzCB8iz6BW70hQw7DTc/XFA8mSk7zpPOEp9Lk2GD2m2Tame3d11NF9H16saiaphJH58RXyf+TPYjW7aP4Lm18l2dHKVDzgRzvytib/BvfuFts6DcHc5BKXy6h3cRLaVgJ/hc25P6ibEVDNUmSFcSxJ90f8FxBAzSvTeivldpIUY3elGEbs9PJGmEQiGQalkDKemAVQQeWCBuzOT9XieM0+/zhS+5yMcuFXm3jLKAJ4mgH6Aih3uFXNuyxk+0B6WncNh6a7kTOrjSEgNzVQ92sVoxpIG3Bp3omCcxcN+hrLjXhXoD8iJm9NBKjWI4+vYeydyWouIdtGZRzLBNlYwPiA4vIWtdsnfNJY6PWPWT2nNAnS+VaTYlMc3FswBbLr9Gcjn8+s9GD+9jMaULz9QHgtwgz0Sjr+xMjU5EXxzrhtkezNu20OfhUtXlbX4W30FEA3EJ7dwHvMeUB8Twy/rQ9ZdxxRkcvMmXi+9wMRUnI2eP0zJGip4jUnV4ruz8CGEPGpYrKNozEMP0zvXqvOB/Sl3IKSg3nCdJ9V9yjDbwhUdJGxCfOIwqN2TyXTun8gp5YcU0Mt6c vlFcTfLZ ivtuSZJcOWBvtSpOKD7k3o7Qa1U839lfhI4SNRXr7q+QQisQEt84lzQCiszHtTIXhETyhIUuf2EqIJELTrMmM2nCnlsNUG4DWyzwAClqFld08VwXQPtaehmYrjQEHMYaoqPSManQ5qRRBVMoXUxubAgPPUEjM1aCybyPd+4HFWir+qGUuQYWVD6YrCiXdJ5F16T6uJQDOFTWb9vzpcrqPFLX1qcRphHX4CDVybtIJeMhRloQsa5G9byAHENnWD1D95JhPf0GCLU7nx6Z2vzROAgjheKQFt+QfSAetzB9GqtzaqqOSXFX/ykANdvTwxQeV10w+lz/P4Pq13NsTU0H9sP3Yo8JDll/QmCDJBrm7iymrbZ+98Oh/jbpiWVOPBQX+JqpHm/fSxaIw9iY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Sep 28, 2024 at 08:35:52PM +0100, Gary Guo wrote: > On Thu, 12 Sep 2024 00:52:58 +0200 > Danilo Krummrich wrote: > > > So far the kernel's `Box` and `Vec` types can't be used by userspace > > test cases, since all users of those types (e.g. `CString`) use kernel > > allocators for instantiation. > > > > In order to allow userspace test cases to make use of such types as > > well, implement the `Cmalloc` allocator within the allocator_test module > > and type alias all kernel allocators to `Cmalloc`. The `Cmalloc` > > allocator uses libc's realloc() function as allocator backend. > > I think this needs an explaination of why it needs a complex > implementation instead of just using aligned_alloc and free. The reason basically is that there's no `aligned_realloc` in libc. Anyways, it's gonna simplified by the introduction of `old_layout`. > > > > > Signed-off-by: Danilo Krummrich > > --- > > rust/kernel/alloc/allocator_test.rs | 193 +++++++++++++++++++++++++++- > > 1 file changed, 186 insertions(+), 7 deletions(-) >