From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D31BCF6493 for ; Tue, 1 Oct 2024 07:19:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CFB2280054; Tue, 1 Oct 2024 03:19:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77F07280036; Tue, 1 Oct 2024 03:19:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 646BC280054; Tue, 1 Oct 2024 03:19:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 44565280036 for ; Tue, 1 Oct 2024 03:19:00 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ADAB1140DEC for ; Tue, 1 Oct 2024 07:18:59 +0000 (UTC) X-FDA: 82624181598.08.A86B30A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id 248BF180010 for ; Tue, 1 Oct 2024 07:18:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z39LzbLV; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727767012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W/Kp0BzLRyOiaWLUKRoCKOZJ8mnJpPwtrBB70404Yic=; b=bvTagYSrSSabnEbpVeMk8fP9KjDvwfVBidQEYdEEq//Jn1PaPiYIkdsk+RiwzfTDmEwh3N pSmApaH0buPLRVoiR8atLjSssJKKZXCRS+D6ZqlWrx3/1W4pPPiAqEFLaZ9O1aamlYt5Pa 38MGkQAAYcYNh0MGBKeJ/KJJ1SlRFKA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727767012; a=rsa-sha256; cv=none; b=cG2CLskwzKxtcjsvn5Pfg9nBeheg8JyWWQhiyB3FbtYMIdn4YA7/rfbXY3X+OudF/12Vfh Iajyk90LNXBSR+cjiaEHCFiJHyQmFmd7DY+hz409z6KiwSVFeo/jTOIDy95sA2GZWjDe3F 9rQ/eUVJXWkdqGVGs5MNkGu+LmwkdwA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z39LzbLV; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0D498A4194D; Tue, 1 Oct 2024 07:18:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79A60C4CEC7; Tue, 1 Oct 2024 07:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727767137; bh=hHvw4rvvTLAn5PFdhwtgWaWgXl+dEkiAGCiJw1l2A54=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z39LzbLVpvagQs41yjEgupVeHDouFrPnwhL8DPPxVKC03DBey9StqC/oalSRWHhJ6 FqyVhsGTg9+3+yDh5wahTYIobStsAYg5xTSssQ3CZwb+xrLoO9ouE56GWYwx7Cz5Pi 5ezsgsjjYpDfjtLJSy1zZzmhpUUQkt8AXAMQfR3yKzWnhBvX8bRSaGKYSWpsvP4gop obhJaegucY8/ZSHebwKzSVbkLZxzBdBCdNhz+NZ1N2zruB/TUQj/esF6MjsLA20J14 imTK2ZMQ6V1JhYsMdKtpqn6NGInqiOxy/5QwBdtAAqdEdI1n+A5IQnXH/dyKKy77ni pCe0POsfkPvCg== Date: Tue, 1 Oct 2024 10:15:38 +0300 From: Mike Rapoport To: Bruno Faccini Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , Zi Yan , Timur Tabi , John Hubbard Subject: Re: [PATCH] mm/fake-numa: per-phys node fake size Message-ID: References: <20240921081348.10016-1-bfaccini@nvidia.com> <9759DD75-5DA6-4C3A-8300-CD8EA8353BAF@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9759DD75-5DA6-4C3A-8300-CD8EA8353BAF@nvidia.com> X-Rspamd-Queue-Id: 248BF180010 X-Stat-Signature: mrpytrzn74gnd3y9rdxuqafq77gcxma4 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727767137-105432 X-HE-Meta: U2FsdGVkX19nFT2MJGT9sAfArRpW8msPEwHzBz3Z0ftYzq/qgyY+cYU9lJ77BdgUPEt7tzquvosynXtkjouIcaOlgW+70V4mWjuvLZkhMSZGgKoCW2T5H1mMgwaBh1gqkkrYqznFtPHvYZEoyZomY0xnfWKsUaniqvgz8nTEN5Og/Cu7mk0UC4y/TlW8SEhQ1hpnnH/MDA6eVSxnk49jlFSQYAXyq6nNgRn5Hq9P1hA7MXYw4t1ujDJDLawKrF552wsy6mHYU+MwaVGmLGRw7gcbP0yioslp9cYT50kxBjbykfUXSVinuJH1+fz2sOr2zDvNq9bK8iHoU8OUF1ONwrJbHMmi5yPctDlZfo1FONtYpI+OKw8O9W1qs9Q/trze1iNo/Y61zuTxYfST0a8cYm7ccT0y3gvb4tipNYwQnVAwcbEypVTa1/mXOx8Mj/7OSBycFAO8vjRh2jdHu4QwC/Sd4phGoSyfIMYQcCjcdGXRv6wuR4nYpih1wDjNudsinPoPBFJiNkTgllQru10+bffSE9PAacGJEesh4jHLahHL2kX+AjMBh4uxAy9NqQnMFUOJYewaJP6OEkkotwNeKcgm3kIx6zk+TWqpdmVg8ndRRbBROuq4gDd7fSLUYCICEyNE7sE4SXO1Aoe2s+EbVERcDLS5iPNvNmdp5odxMH7I3ZTk3+xHHMIPMWHL0QC9vou8ZTTpwwwyXtaeORpGnPeCw8B3bsS0qL2trMLm7yj6FKs7QvWC51xlLFUIy5RbXC1JDwHYJZpxL4fBYRd4Ht9tIy0s190q0fo1jJuWwq7TzFZ1cxUBkWFrXjUMgdwLZUOid4O0gRKke9SUStx/mUclxI9YsczT33UhXz5lndQ18Z0Rb2L43LDcDvvNK3UFAfi1mbi1QN3RkaX/GUxgFmfdim9wETA6BzwtMrc7KYZk2HjADgGH3OrPMFkgv3+cA/G2gg1tAYjsTxTLSZM mhSlSOgN bu1rLZk1KcovrVmcKX+cpohjcD5ncHAFeJNJnySaaMrBQYs8SGK1AI5JmOtuH2GZRuedYNzi/9VmekQmUuAmk3YL0ZRHcqLcdnxN6y5SMSR0Apyjy6mbzjdv1yaDCZOadKNm7XQjCLVNrV0hOjMmmIKEF9NIetoqGW5otIzr2oe+tMJLU2dd9sWlhQWcul/ILRYekRwtts6cEVaUHlzJxCAFEHSutcsuEV+WktsYnMsqpGw4CpyUC6YYz1FXXlWw0ZZKknGvoHjZuCVj+XSK4JStma6Ry7M1xGfv26KbYHSXaYa6/rAyMCGznQNuNZmVYqzbf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Sep 29, 2024 at 03:43:50PM +0000, Bruno Faccini wrote: > > On 25/09/2024 11:32, "Mike Rapoport" > wrote: > > On Tue, Sep 24, 2024 at 03:27:52PM +0000, Bruno Faccini wrote: > > > On 24/09/2024 12:43, "Mike Rapoport" > wrote: > > > > > I don't think that fake=N allocation method is intended to get fake nodes > > > with equal size, but to get this exact number of nodes. This is why I > > > think we should use a per-phys node size for the fake nodes it will host. > > > > IMO your change adds to much complexity for a feature that by definition > > should be used only for debugging. > > Well it is only executed once during boot, and as you said for debugging, > so I believe when the boot speed is not a requirement. And my testing on > our fat Numa nodes did not show a real difference. I meant code complexity, not the execution complexity. > > Also, there is a variation numa=fake=U of numa=fake parameter that > > divides each node into N emulated nodes. > > Right, but both methods should work as expected, is'nt it ? > And one allocates emulated nodes interleaved on physical nodes when the > second is doing allocation serially. I think we can just bail out with an error if we fail to create the requested emulated nodes. -- Sincerely yours, Mike.