From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB42CCF3195 for ; Wed, 2 Oct 2024 03:38:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C50B440171; Tue, 1 Oct 2024 23:38:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2758C440168; Tue, 1 Oct 2024 23:38:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11595440171; Tue, 1 Oct 2024 23:38:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D8378440168 for ; Tue, 1 Oct 2024 23:38:37 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 082AE1A09A5 for ; Wed, 2 Oct 2024 03:38:37 +0000 (UTC) X-FDA: 82627255074.07.6092733 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id ABA85160010 for ; Wed, 2 Oct 2024 03:38:34 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CzTeLnxh; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727840276; a=rsa-sha256; cv=none; b=cHFSvdwWAbbOxibMWAka6vu8iKM53fjkrh5WgL26zIV+W/Il1t+2Ot9/A1+kEHaryRefwo oijLdlNrUCry/JfKq5MLZoLmfR01KMDvpWVXVoqyXiRufqCoqDD5CNyOkI0hmM0/0Qa8P9 3MHG0k3ZDyY4oPdDJghyJEnM4rw6mBg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CzTeLnxh; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727840276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ciCu5avsDLxUiWUnFeF8OV+7HKY4FNxRpx45aFZ6ISI=; b=IVWgac1iFgW0psOrtcwKIlrC9nJqWflSYsPzGQpV1m2XqiB7ew+2AivZn3/6FgEDtI9DWM nU8UU4tDtUGfim8qvUeHeL1VPS1HrSv0ExPGR7PMEL30vAtUvuYGsclygMvWoI595e+L8x aW9l6qlKgEP+xk5bAtXiObEbaTPE6HM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ciCu5avsDLxUiWUnFeF8OV+7HKY4FNxRpx45aFZ6ISI=; b=CzTeLnxhoVhYlObrEaGn7wEZR8 FOxdTc96fXvWFMe9t+8ib5dMgDW+4w/VdosULccb9H8hdgmevpKiZ7Rzzsa2Y1P4rKkquV4X6dyRX sg7c8WLfwWh/UTf2F2SkfcTcAU4VZlUAv3Yg0QR7hmFcuQeGCSQy/dLIHZrXbWvJk131bgqZ/RUSV 0ngK74qF4Zjowu3YAFKon7VF91+hr5qnLWcexT7oSUbY+kdY7tLUHrJynvxAhyHn2ygVRbiqintFI lA60qa8P288GUR0ry240j8w6BOZpDWL10m+lO7kLqwA9o0u9Pt3AR9f+L6Vq7yvCRahoWtyT2I8zG 3jc3QyCA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1svqBx-00000004FGy-2Fst; Wed, 02 Oct 2024 03:38:21 +0000 Date: Wed, 2 Oct 2024 04:38:21 +0100 From: Matthew Wilcox To: Pintu Kumar Cc: minchan@kernel.org, senozhatsky@chromium.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, joe@perches.com, skhan@linuxfoundation.org, pintu.ping@gmail.com Subject: Re: [PATCH 3/3] zsmalloc: replace kmap_atomic with kmap_local_page Message-ID: References: <20241001175358.12970-1-quic_pintu@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241001175358.12970-1-quic_pintu@quicinc.com> X-Rspam-User: X-Rspamd-Queue-Id: ABA85160010 X-Rspamd-Server: rspam01 X-Stat-Signature: 93dztm58sfo84dpebcird3b45g3m9xjy X-HE-Tag: 1727840314-77273 X-HE-Meta: U2FsdGVkX190To4pLgr9IoXlZfBT21QqTF0yHNU03/fpOWYTxolfeocoojVJTxUWiaI5ZmxO4D2oe7uYXbb3kBo7sfyV485D0Ig3HbFT+6qF7vDyF7/Ws6eH5FBZiiAcVKmy9am1aZI0qNOadyE5acN9XOufzZJdnjB7zZF8lcFSniNMYU/HdRJEG+E74Vo1cSHCr/UqEW0fAKOq8/JfbGjxgCrEuNNVufPcI6MRGtpDUOiD0j1KO8CP2aokSF3dCq7IAaL4Wvw9Y2jMOeKIS2lCJrINk3k7MBX7QCuz+C4eeLeLPAYnc9SvFWLZJJveV9NrW13Kyn2Xabq9HlzvGUezXzHuLquY847dKjtodUvqTilMC2LehhJiJ3QiPItFB8Y27fQjoPYOJR1n7cb6x3Rs7iH7Dk8lCqJRxUMwfSwXtnUZB+ZY4bEgTLSYlj96oUcZNZY0TkAEvrphI/JXJHDPQgdnkxA6gRoMlPpgAlTGPfbT0sSRp+M55T21p6QLjbz6krySUKeeHlsUrWSvQvu7X1YGKmpiVw5jUqw2FP25YIu1MKUM8aXMnQRPxY5xRl7Dx2XlwHIsIhA/tlQBFVxUxrzu1Qga/jcOIK3BXxGwDGC26KiKNdRHItZSqmHaC8ojubxsNuwMOvdqF035XXkKny/M7ZXrclvt9DIuP8WGMp+ogKtIjYAJaLasfRqWAmGhI3cbqWpESuBNNW2PCiLLIG4H6RWhFDTQn28ogmWTRIt/73eFYLb5WBFQfvztaoWF9AFEoeBixtU5dgsd7+zFQde2erWBEkUV9iJuT8+vVvZSI3dCgqW0/fOXhJsJPYeJ96o81cdxxhw3CNHd1e3HrlIIruQa09Pp12Rf4c5m+LWItIGo/n6YyMb2tiBtjqam28yOAsj99MwIo8wwdge+xTxoHTR1d0VQrYorBH0QehFctLXtVVY73T1uamlDrwxJ4yQMm+QRkFsFaIE /jS15onx od+08uK23mVtWbS7cGuWEedQgB1mUvtZrc8EjHS30HBiRenXHds0twtz1DfZpJtoQJtwieBGbt3GtQcB4DP+/K6SU5zk/DokyJLVWtU5dcrcn44gBULpQ0tg+PVeaf2qtsM40Z6zu09o/3dsrj9YCC+RfTFdbOp41EUuzwKzkYwKgnkqIbRiMmOgIAtMPhuaB6Ml4okV/NJxumOmq/uve0CF2YdLMh8eiEstwp2OqvAvZnmjSJ1WLTx36zxUpdztjny8uXt2SqCX3jgcgJ0I1DDtarEtDR/YnBNw0PQRiQEEvS6KbYqn/muQ+Uyp2w3F4KL1tbTQEFUlo65ObICSYfEdvgLqxmJQx2S/O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 01, 2024 at 11:23:58PM +0530, Pintu Kumar wrote: > @@ -1059,12 +1061,12 @@ static void *__zs_map_object(struct mapping_area *area, > sizes[1] = size - sizes[0]; > > /* copy object to per-cpu buffer */ > - addr = kmap_atomic(pages[0]); > + addr = kmap_local_page(pages[0]); > memcpy(buf, addr + off, sizes[0]); > - kunmap_atomic(addr); > - addr = kmap_atomic(pages[1]); > + kunmap_local(addr); > + addr = kmap_local_page(pages[1]); > memcpy(buf + sizes[0], addr, sizes[1]); > - kunmap_atomic(addr); > + kunmap_local(addr); This looks like memcpy_from_page(). > /* copy per-cpu buffer to object */ > - addr = kmap_atomic(pages[0]); > + addr = kmap_local_page(pages[0]); > memcpy(addr + off, buf, sizes[0]); > - kunmap_atomic(addr); > - addr = kmap_atomic(pages[1]); > + kunmap_local(addr); > + addr = kmap_local_page(pages[1]); > memcpy(addr, buf + sizes[0], sizes[1]); > - kunmap_atomic(addr); > + kunmap_local(addr); memcpy_from_page()? > @@ -1798,14 +1800,14 @@ static int zs_page_migrate(struct page *newpage, struct page *page, > migrate_write_lock(zspage); > > offset = get_first_obj_offset(page); > - s_addr = kmap_atomic(page); > + s_addr = kmap_local_page(page); > > /* > * Here, any user cannot access all objects in the zspage so let's move. > */ > - d_addr = kmap_atomic(newpage); > + d_addr = kmap_local_page(newpage); > copy_page(d_addr, s_addr); > - kunmap_atomic(d_addr); > + kunmap_local(d_addr); copy_highpage()? Maybe check the other uses, see if there are appropriate helpers for them too. Also, what testing have you done of this patch?