From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA5ED18123 for ; Mon, 14 Oct 2024 15:24:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97D5E6B0088; Mon, 14 Oct 2024 11:24:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92D326B0089; Mon, 14 Oct 2024 11:24:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CE9C6B008A; Mon, 14 Oct 2024 11:24:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5AB5E6B0088 for ; Mon, 14 Oct 2024 11:24:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 259DE14104C for ; Mon, 14 Oct 2024 15:24:00 +0000 (UTC) X-FDA: 82672578324.27.87E30F8 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf18.hostedemail.com (Postfix) with ESMTP id 60C871C0006 for ; Mon, 14 Oct 2024 15:24:03 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Kz+NXsHO; spf=pass (imf18.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728919303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aYH5z0L7usj3TEY2UJNHIBexzgzf90/DN2Wq22O70vU=; b=BGgxDKki04acUm9Ld9+XQYm2iT05wjOBCq/YDxLvjXf2g/UoR4lZf7dJCuvPprSSCI703R yE2nth+Rha83DXNwEc1cYdlx2O912N3E3pGi5kEicxckshlnPkcG6IjqOWZiS+SAnoZLnv SPZQZ7Ez2joSjelppggNPQsv3zY3E/0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728919303; a=rsa-sha256; cv=none; b=vgWlrD8Es+N6emQ1C8u2u9VBQLLJ0HDE+mSq4fGI5bCLbG443VjxYZEEANHX2+7/0Dj+U0 DEdVPYjXaF19ll8hJztneRoUYUWJvmOphUHvvNs+E9uO03jfw87SCqJJ8S70Rr2RRxAxc8 2jjjHFmjFeN72l8H2BGsn3mPM1lg9Z0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Kz+NXsHO; spf=pass (imf18.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7b10f298052so210137785a.1 for ; Mon, 14 Oct 2024 08:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728919445; x=1729524245; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=aYH5z0L7usj3TEY2UJNHIBexzgzf90/DN2Wq22O70vU=; b=Kz+NXsHO3qRWaPmHJXgEnlZUNa9R2BH7vPkz9SLCB76KPQfdxsYySAFw+fcgdg/7bv Mm9nMkjBqbN6ol9lgBX0VssBBBn5omQg+1Uy/7fFtXzu13aXPSp5bko0mJ7PUYEbtUEZ adAT07dm7YdL7lR/kB0Xt/XMEJWQZ4xZuknpzRDUFIYP0KVb5Ggs/EqD/jSwtqjwh51t 89uufduW8ogFgjV3Susp/wbOWwTUnMn+Fn37mqhqWJHBQHoI3iGKoXh0p+nODqHbTkHR R7/Sc3nwRWj7oEAlw6hdOgnlPQHhn6b3z+RxYLs5SkEejyUk2Hjf8EtGcKHe5DDSVjpX wkkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728919445; x=1729524245; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aYH5z0L7usj3TEY2UJNHIBexzgzf90/DN2Wq22O70vU=; b=wyp+p0UwxyyA5Od05NdCY+yRvyJQoiPCXfhUsqlfRpgeoEHix9EZD2If9E4srIgT1a GOixhVWWDl41P/YuTTr2w36wr+EfgB2XSrN2Ry8QMbqT+fUPgtEs7/xgBEj9fI3Mj/H5 WJjJFiJu8KPpAFvOCky80mnj6B01bgPX/IPlHIOitxgzB4J+W1pqE63SibGfvQsS8gjU LWlwDTejFb736FBYUXZbyjbZlf387nDWRKQx4OxwtdSFpfaRlBUB3TfJRadJE4nVL5B8 dd5mMMR7VQO9pi+NVSEN9GD8bj2I7dT/TMp+uOPSB3fTdc/K8QX7rU0mJ5EMOFPf4gJO J9lg== X-Forwarded-Encrypted: i=1; AJvYcCWSWgVT+CEFJezA69bCZsH8x3ZYKRz0WTepkSsVu59XPypIFovHp2vP6LVZIMGiWcA5H/v2JYIfwA==@kvack.org X-Gm-Message-State: AOJu0YzZ5MLyDptC/LP3MVEtbxk38p6nxt/Lz715RxughylsJ2W/eueq 4Qd2ob5FcUHMWaKpTi4sICgGzfIksB7o4gVjeh2a9r4dKIt9Tf95 X-Google-Smtp-Source: AGHT+IGeVC6/AXqBMx7WwHuZEWV0DZhQpv+Rz3dY/BO6jy+iUKkEL02ulpAZg+YJXL+ZeGXbnxsWeA== X-Received: by 2002:a05:620a:2685:b0:7ae:6e4a:c43a with SMTP id af79cd13be357-7b11a34f0c7mr2341634685a.6.1728919444771; Mon, 14 Oct 2024 08:24:04 -0700 (PDT) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b1148c70c5sm430760685a.15.2024.10.14.08.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 08:24:04 -0700 (PDT) Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfauth.phl.internal (Postfix) with ESMTP id DC9291200043; Mon, 14 Oct 2024 11:24:03 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Mon, 14 Oct 2024 11:24:03 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeghedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvden ucfhrhhomhepuehoqhhunhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrd gtohhmqeenucggtffrrghtthgvrhhnpeehudfgudffffetuedtvdehueevledvhfelleei vedtgeeuhfegueevieduffeivdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhi thihqdeiledvgeehtdeigedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmh grihhlrdgtohhmsehfihigmhgvrdhnrghmvgdpnhgspghrtghpthhtohepudelpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopegrlhhitggvrhihhhhlsehgohhoghhlvgdrtg homhdprhgtphhtthhopehojhgvuggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopeif ihhllhihsehinhhfrhgruggvrggurdhorhhgpdhrtghpthhtoheplhhorhgvnhiiohdrsh htohgrkhgvshesohhrrggtlhgvrdgtohhmpdhrtghpthhtohepvhgsrggskhgrsehsuhhs vgdrtgiipdhrtghpthhtohepjhhhuhgssggrrhgusehnvhhiughirgdrtghomhdprhgtph htthhopehlihgrmhdrhhhofihlvghtthesohhrrggtlhgvrdgtohhmpdhrtghpthhtohep rghkphhmsehlihhnuhigqdhfohhunhgurghtihhonhdrohhrghdprhgtphhtthhopehgrh gvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhrgh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Oct 2024 11:24:03 -0400 (EDT) Date: Mon, 14 Oct 2024 08:24:02 -0700 From: Boqun Feng To: Alice Ryhl Cc: Miguel Ojeda , Matthew Wilcox , Lorenzo Stoakes , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Alex Gaynor , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org, Andreas Hindborg Subject: Re: [PATCH v7 2/2] rust: miscdevice: add mmap support Message-ID: References: <20241014-vma-v7-0-01e32f861195@google.com> <20241014-vma-v7-2-01e32f861195@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241014-vma-v7-2-01e32f861195@google.com> X-Stat-Signature: hzmxifohmky3cpb5wc1wgsmjjsh83wcc X-Rspamd-Queue-Id: 60C871C0006 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728919443-438393 X-HE-Meta: U2FsdGVkX1+BZ6Ujw4FldxBt39Nyve7hVgM+1mkKVg0yDq1Rjvuc/Mm7dieAlVbFC1MWqE7jtw5HOWRtxSo0japzKappUg0qg/ZrfjJtJuuLQryMKhxham5zHnRnWxaSckTcwe/bYw/ZoO5lkbMtD6/ShSNaLrbSjLi1uLrZaRfbjnlGotj3rh99UkajxdeUETow8sP4M0T65svpPOcxkRd0obQKU01QdUhtIhwKMUJSYilZFOCKtqR8kelHOHpAiVQwHfo5z5kBj8IkFovswZ5RGIIuMlD1vsLCo/Q8ZnGSsmTC3NgCr/ogpNm5JnJPOhk5htZjCFrcvSdrz6koaXmRlGEGtnERahalPjlzpFuAQMIS99kLEkHpIhtovtjLR2VzR/ANGHTuVR0OK/w7Wq3VHOghKeeOVFTglBhbpYEaIoVeoz5xBVMycQeNL9fIskdMjBp9HI30sXdBUfg+Mx/RgH/udOUJFGB54fBgwVF4L6EuJOxQ58w2eYaZtd7t0pN1V+BleTWk1CAGFOzSU9w69Q8XKzQy8rOpVuhuRxOoV+E5XTwOJ+gWtiokwsg6x+OgTWholjUk24vlpj2509CYBYGDgRzapb7bwZfcv6UESQyMTgBm2Ly8H8wcth1B35sWJiibtyEn9l69oeAGYbjsCICBGem3HfQHh09SEItNEJUDFpvwK2+ffZ62QARRh7a8zkM4Cei0p61EdqYmfjxBjQb/Fp5zlkYbzXCyjLKM8nrzqFkcd314YKokJHNmSZ7CosMaQvcpkxIS3NXFgEyiEtJ9/6fJYhtGvdScM2+eaQVl9FUkS2Awxc3QRk5LLqplx5IKJkl9oGXy3+K5xEOggjYQkrdP6lIGbk5KXIgPr5dj1HIV3+PpWkypzhITxHlAqu8VycWJ62qF7LqAooNxkS0m5v/WYo37htTcnXbv29zbDDcBNBtoT+x6UizQ60xpaf3R9iWOw8a8NEt WdVs0ZZ3 WSuDXdn0vN6eU5tQ1oK+teruLtKbnvqShWPN+lVfqZxluQU+HAflhSbtAnHs0/H9l+JfMsHIDluZZRijKGs5dyVqHBHHrTHNFOBXBHTqNPAnc31a0NgZ2iar6TvaI2Wb5UFNAV9uOzvPTBzZRCAie5tUxLm9zhudl97b6Xr2BczqZa8O/PXSeLa06i5fpzRICWGJBjyQCvOveyO6WrCGhQcSph/uyiZoJHc4AAKmI3i9q2UVWFRb5LzuXuoGktKaWPz2i/HVngm9wWsjOEs+FQ8fquiT0tFyK9HBB3JXUq2xB/UJiAV8xA7R5swjPfezUkvFEdoPCIbNK2u4jCNwtflbGDaCtGgFvBIdl+EtgT/rY/mT8umM2l2C4AFzN04Vggvc8COP5mdlsfa8eQFQg/tWETn/ENZRDIoQzM6s6ARA1j8sh+0G8bfb8RweAiR8yeinRUgKF6Bzp9PZw+7bwqoSc4uLcsGJYsQXZoLEDTdXDA87Qy9rIzEh+MLCLXUgngO62+UYBcUUSwbg58iSXvQHlnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 09:29:52AM +0000, Alice Ryhl wrote: > Using the vma support introduced by the previous commit, introduce mmap > support for miscdevices. The mmap call is given a vma that is undergoing > initial setup, so the VmAreaNew type is used. > > Signed-off-by: Alice Ryhl Acked-by: Boqun Feng Regards, Boqun > --- > rust/kernel/miscdevice.rs | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs > index cbd5249b5b45..c9428a6154e3 100644 > --- a/rust/kernel/miscdevice.rs > +++ b/rust/kernel/miscdevice.rs > @@ -11,6 +11,7 @@ > use crate::{ > bindings, > error::{to_result, Error, Result, VTABLE_DEFAULT_ERROR}, > + mm::virt::VmAreaNew, > prelude::*, > str::CStr, > types::{ForeignOwnable, Opaque}, > @@ -110,6 +111,11 @@ fn release(device: Self::Ptr) { > drop(device); > } > > + /// Handle for mmap. > + fn mmap(_device: ::Borrowed<'_>, _vma: &VmAreaNew) -> Result { > + kernel::build_error(VTABLE_DEFAULT_ERROR) > + } > + > /// Handler for ioctls. > /// > /// The `cmd` argument is usually manipulated using the utilties in [`kernel::ioctl`]. > @@ -156,6 +162,7 @@ impl VtableHelper { > const VTABLE: bindings::file_operations = bindings::file_operations { > open: Some(fops_open::), > release: Some(fops_release::), > + mmap: maybe_fn(T::HAS_MMAP, fops_mmap::), > unlocked_ioctl: maybe_fn(T::HAS_IOCTL, fops_ioctl::), > #[cfg(CONFIG_COMPAT)] > compat_ioctl: if T::HAS_COMPAT_IOCTL { > @@ -207,6 +214,23 @@ impl VtableHelper { > 0 > } > > +unsafe extern "C" fn fops_mmap( > + file: *mut bindings::file, > + vma: *mut bindings::vm_area_struct, > +) -> c_int { > + // SAFETY: The mmap call of a file can access the private data. > + let private = unsafe { (*file).private_data }; > + // SAFETY: Mmap calls can borrow the private data of the file. > + let device = unsafe { ::borrow(private) }; > + // SAFETY: The caller provides a vma that is undergoing initial VMA setup. > + let area = unsafe { kernel::mm::virt::VmAreaNew::from_raw(vma) }; > + > + match T::mmap(device, area) { > + Ok(()) => 0, > + Err(err) => err.to_errno() as c_int, > + } > +} > + > unsafe extern "C" fn fops_ioctl( > file: *mut bindings::file, > cmd: c_uint, > > -- > 2.47.0.rc1.288.g06298d1525-goog >