From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BF98D16260 for ; Mon, 14 Oct 2024 13:11:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D9906B0082; Mon, 14 Oct 2024 09:11:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 489A96B0083; Mon, 14 Oct 2024 09:11:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 351B76B0085; Mon, 14 Oct 2024 09:11:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 164226B0082 for ; Mon, 14 Oct 2024 09:11:36 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CA38A120F0A for ; Mon, 14 Oct 2024 13:11:28 +0000 (UTC) X-FDA: 82672244382.10.805F0AE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 3F9DCC000C for ; Mon, 14 Oct 2024 13:11:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vMvBZJVO; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728911463; a=rsa-sha256; cv=none; b=ZHbU4/U8ynnOCfHEzXbp8zUp2uVIDdfEw1jWMQHhQCrU9uoln43d8miLAMFb1W/eRyO1VH p77ChlSDX03IcLKy94a1ofZbyE7jWisAVa7ER9IJdLZuA+v0+1kqe2TQw7WOdkxqPaYBeo qMcCXZvQJd/Qprg6PLvtBd9kY4gua2Y= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vMvBZJVO; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728911463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j+BOznowBtN/nii59G4lRfCPThWEa6TNxQ/kRulWlps=; b=FqsD2Y3m2j6jPRIPYpujMQQL2EnpqIYqZP+quBcEeTQyHhK8ZsFWTB8jtHSwTYiIXW3Ofu QryEWhKTlKXnN6sUgFbD+mb1BnG6M6M/zCLkoLNzvMhlRzLC2N+XLeXI4IQ1k6Cp9ZKUMt F6vy0HQF+eh0mAWct5PtKkgJIxykLKo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8CAC75C569A; Mon, 14 Oct 2024 13:11:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32D95C4CEC3; Mon, 14 Oct 2024 13:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728911492; bh=Rj0DDOED5iD2FdGYxYV+4r4tEXYq4n6Xi/0d9QAVLUc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vMvBZJVOinxsLsrPPXzSxPojzLbDfnzNQ55w0X0QwTjcMMxar0CDAK08E2JThkQpb 4cpioov/cqx2XJwdmLwC1BTnXl3vfXvrgA1ETi3RHPPFn/KFa3uZAW+joXD5HEZg+c 4U5ok631tPzwPd7hoGyNRL5ynGDynUSOamB6K2RiHfHSi/erCk9kHqPS+1U5lBuMVB r0jU8Sa0yR3rOlG2WDCJ68+YmRHtYreB6qz66TSlQdG0YMQVcdBysszRX2pWrQ1lN4 ziJbkceFmXn8rCIwx79sxsDKS6SGBNY9GisCIBFcBwGbEy+4gMh7VJcsFjn3AG+8KF uacBBUphpSFpQ== Date: Mon, 14 Oct 2024 16:07:40 +0300 From: Mike Rapoport To: Christoph Hellwig Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-8-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: kgyhrkftsqfbt9uys8w6zhroubof87if X-Rspamd-Queue-Id: 3F9DCC000C X-Rspamd-Server: rspam02 X-HE-Tag: 1728911491-870113 X-HE-Meta: U2FsdGVkX18cDPVlBvwyvfUoHB8n7egzA8XHg1eqjpS7ZFf9N2AxRfwwlMP5jw3P7mYSqfjnKtunaWA6OZrDicSBDZCBtQCbtfqFsrBzSLvNsJwaOZwM4W7lzBG5orWnwoSxKfCqeTI3iDl+rdvA95aOHcNuP2RpHWbXyDMpMSGIJBSbBPCVwzmH8xEKPX+QaojC3535CLF7tGHJq//r21NG5Tn1MvBFwMz6NP78NEDeBJhsHq+G6J8kmA5XhdftRYxXjQPlQGVONk20vaRa+6GD0QBZaWKhrA+aO2HV+UHuw4V5xhcOkRt5EqM/LU78PCAKncsSqUw0oNp0Wvb1D2fhsc9DUY7kSYOtd5c9psq32EJQe/gSi1jk/lFyDjFWy6czF7PyJBHFW0hpGennDvNYoVfLONHGnZdsKaY28ZdTh/mZOOdzORVP7nDgItehMByM67qlJmRxjYKKwfyYFNCOJOA66TMVkwJyhri4klVmfmjD4tasDjTg27kwBN+G8WSI+HBE9kXCGdYt0KEu10qdpZGZcG1MvkIPx4mfL63WeFQQCWSZLMJcbLprKg3OAC8Bq8F49qFemUblf+tH8MzFCCFVAExiBJ8CBFylAjGF54muget6IjENHeXeCilalTaPdfRtH3PQEVsL1+hY3miULYVW5RsJfuYgJeowPQFPrH4L38I+UnXvPBg9JiU8VmWsjMRiOKwWN8P8fOPDqEjjaL6uxfyCRGRkAvan2F9UuyMIc6RyfYe2R7jEWXRwAaL1gEFdx6LS5eQIC362iGTrJa2rq9tI/Es3dBb3S5jWu5QWgyl7LScA2UmcvEyNEDzpccJg8qWLgqcIdQv6V9fnDIwPBqnnHvFtwgrJCzEp5NGREWqzh7zTZilgrfhkYNutLsPEWEZrOtj6dy3SEpq/rz2rZWawD2q8FUHZ2h9OgKgtOcdLhOSLL4ucnb1GeISHDvYNd6s7an2nrP9 3GFdttYv EPlyiah80QFwaAAKNTEaWEdgLLufy/6bdIE8EOaNnXfzUIQsrAAeIgjOY/ydbSnFEl71D9vQfsqoIm+9ZjxLya4Sgss88gW/DX8izk9PunRd/FsmWfpCmukJke1gVuyaQlE3gOXXDaebkRCN/8vUGGsVnXuR47pjtwaz5mhXx0Tuak2pAgBgV6noMiVE3MdnoRXm4W2xnQW9ZnE9zzTq089GnPsL4u11fP1z1lhD4xVxI9bOwlC4PWJLR+vlQ9yLItzMRJVpdlp2Jqpl9JOPteTWZJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 13, 2024 at 10:55:25PM -0700, Christoph Hellwig wrote: > On Sun, Oct 13, 2024 at 11:43:41AM +0300, Mike Rapoport wrote: > > > But why? That's pretty different from our normal style of arch hooks, > > > and introduces an indirect call in a security sensitive area. > > > > Will change to __weak hook. > > Isn't the callback required when using the large ROX page? I.e. > shouldn't it be an unconditional callback and not a weak override? I'll add a Kconfig option to ensure that an architecture that wants to use large ROX pages has explicit callback for that. -- Sincerely yours, Mike.