From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8DF0D206A7 for ; Wed, 16 Oct 2024 07:36:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DB9B6B0082; Wed, 16 Oct 2024 03:36:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48BCD6B0089; Wed, 16 Oct 2024 03:36:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37A196B008A; Wed, 16 Oct 2024 03:36:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B1446B0082 for ; Wed, 16 Oct 2024 03:36:24 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3C93BC1A8B for ; Wed, 16 Oct 2024 07:36:13 +0000 (UTC) X-FDA: 82678657110.08.B4830D9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 4146A4000D for ; Wed, 16 Oct 2024 07:36:13 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=old0oer5; spf=none (imf27.hostedemail.com: domain of BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729064038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OafRmAoHaK4TM/K6ajx4rHrM446tv8IYnsqz/V3KSbE=; b=EAwNPQumRP1WLShtvY0Poqa0Q3iMdM1Q23y41MOy9JIPE7RMM+FRkSNXnE0K5wbnpECfMF 4/eOWwP9wWBYndYrBWoVFxiSmKcIXXh+CLdgM7w8UugwPF7RU/uMpCea15vR1cF8OgY39y n7ihFjq4tF3iZsDf2gmwu3UPLSAoj8o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729064038; a=rsa-sha256; cv=none; b=eEQn97R/W/udMnsbBBQsFxrKJSYCdGB//bPjGX8Q+gkX1VcGvr/e10EwVIAU+a0PITU8r+ ZV4XumRDVdiXT4uodXz8vH3cqDV71P54lz808I0GJsUbDAGA4GiaOT3vSdTO1okm7YCq5e 20hcsIhepM5s+gcOL4i8ewFF6F7/h90= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=old0oer5; spf=none (imf27.hostedemail.com: domain of BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OafRmAoHaK4TM/K6ajx4rHrM446tv8IYnsqz/V3KSbE=; b=old0oer5HSG2XSScMMNJQaRo2i y47AgEasnlPpAClTk6CI6RNJvzocjwE5tgA0g3sHpIw43RrqK/JZuL1tNEkIGK4AEilba9mKJs3Zp NTMMdCXOQqdGvqQa3cV3WTUzPNE+fxJ5iof98SOEffEIt+faObHdLozRYs6R60RF48kscZgmydiJ3 WOT1Vhq8b7ieyIFse5/CCFm45Wz5WdhLI9QSQ+MNYr/7mZ/8PPeTYJZICGBnE1m67G5/ZTNTNZeyc L7t8MzguY8xBskWz2SwyOGapP50Za4unOtyH07/Rd/tiTkqirUTb5carnwiZv6YmpAHc0XyYFcCpm FuYgaeQg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t0yZv-0000000AqVh-2uVJ; Wed, 16 Oct 2024 07:36:19 +0000 Date: Wed, 16 Oct 2024 00:36:19 -0700 From: Christoph Hellwig To: lizhe.67@bytedance.com Cc: hch@infradead.org, akpm@linux-foundation.org, boqun.feng@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, longman@redhat.com, mingo@redhat.com, peterz@infradead.org, will@kernel.org Subject: Re: [RFC 1/2] rwsem: introduce upgrade_read interface Message-ID: References: <20241016073340.42565-1-lizhe.67@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016073340.42565-1-lizhe.67@bytedance.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 4146A4000D X-Stat-Signature: pkyfejpkemnypqmptos8waxxb3hp1nmi X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729064173-291813 X-HE-Meta: U2FsdGVkX18z/THHEetpSpp9Dv6Lsvw56uyUIFSAJNBCZzALPK/SEAbyeLaOf+O60AdrN/mLY75D4WqTE6x7fooz1rc+SROwd/Q7TBvgLGwp29RBJ3IiYT8BntqkAuMwm9n7bWXHMVhGyrFOtV/A/C6ssEMOofM0N25Oy89B7GIqj3XzkNscY/J9zxxsozsc4BylDTvIFfFFWImTt8fHAIkjJvxcm8wTO1osJqkm1gFNWV6zAow9utebbzm1k9XDNXvNN6VRJmh3MZH5gQMjKGnm8Kg1siLXThH4bMJLTaDr8I658Ef6k2n8N0crH/Sz1mIBtgrv7XzxDZqVRuvSI+ia7ZVn0O7qHlQu0JS+PsS5hKmAcvykZK8vsXirUQZFPoKjQxePLI2SzSocLdh4WQJyZxGmSMeL+qkF2tasLa0Vey93qVsnUC8twBYhfWxVJd3JLHchRvPDCfZN55O0KfRbFLdYXiE5aWPss9bTeWjgDdFX3OOxAnumpOWl2OFrD8WF2uq8P3IT/rA7JgiLx0qmNiaRIdt/Rb0Bmq/zdmFCEIeuWA7vTgWzCy844d3hIQqv/btYw3OrhdUKUGl91uu2T8CJFA5JZlgysg3RHwqGDr4wKwYaMGp5vOSxyFt6FtRbSHo7V9ABfIVc8YeKDDr4y99AA4YXlVZkCfNPpTIWyo02HWq9OXA4h6tiw3rkNlp7w3XUZUbNJu6wVCcqDKWRz4pQzMEBa/kS2svZxbZ7Bb80eMDqyxRYTVMywcYLoI9kgxbN1BFyPK+uPFT9WkHKfOBc6ZuijSNeeEvUq5z1EhdbvSiXHdp9bi8X80NEo414BwFA/ukcbEvLzbClHtAiXBpZplNs3zzxHqY6p2bQPEl4QD163ri57L7XoHJwDoRPo6zh4NqYNvDh9At3GMeinOB/X28GJI8YyBq83NuDbgJw05vfue0X3Frr4+RwDTtHt2+KMb7gfj83xtt YWFJgyLa KRrx7zSjYe7tCgvRqy1uk1mSp+xvlaKUUA3ftn4NavWpWiyFWkdp5NQcd3mL+cIU6vje/VplNa/wIwq84vm0TZnqUxMp3qLTaZcqvDK8/oJbsJfRLcKTcmSz0Mp38ltHvJl0FXWQoAHCGYiYc/5wdkVqZyuXqd2uJbIt7aQ0xTXDISIpQFwyqm8ZhFn8olvRjR+HWiJBpOJmQMTdjUebf7fRl9u0ogl2DljZ/QLS4AXNZg3o7ysiRPizz3WShHm2I4Wh3W4M3porX0dhtMxaQ/ySdow/PzzH7M1u1Xck2hvPU0qaUQzN/KMvk1puwzBm9RXmCgP/Dmjp5XMz2Ixs09bwEelOiPDaNSuxj+mZBIi1xChkavs/SAsa+daGiY3rAyshdnyCwyiOQLCHSqsHSiA1X7deq42fCQY6WRnOPYmbwILS53/h14WYtcLItFjOIqAOzE2UhuanopDT81LjbzAg2fnH2F+YcLn1mRw3MzoCpSVh9bhAU7mZZOQ7lxU84kY9powE6aVgLcrGkbI+zZG/YdzFbUZ3AfncnW0hqqoXX5N3mJnRd8QgmmPfDhtPEFnkNb8MNRkWVSbke5uwho+y5hJQKr8wNF7lRnFw9G6qOOyxYcPvdguKOkiJl3akvrZgPurbbaZyFM/0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 03:33:40PM +0800, lizhe.67@bytedance.com wrote: > >> +extern int upgrade_read(struct rw_semaphore *sem); > > > >No need for the extern. Also please make any new advanced funtionality > > Sorry I don't understand why extern is not needed. If we remove it, > we will encounter the following compilation error: That sounds like you dropped the entire line above, and not just the "extern ".