From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF19BCFB446 for ; Mon, 7 Oct 2024 15:22:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CEB56B00A1; Mon, 7 Oct 2024 11:22:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27ED26B00A3; Mon, 7 Oct 2024 11:22:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16EB66B00A4; Mon, 7 Oct 2024 11:22:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E2C996B00A1 for ; Mon, 7 Oct 2024 11:22:05 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 92460AB5B4 for ; Mon, 7 Oct 2024 15:22:05 +0000 (UTC) X-FDA: 82647171810.24.53D629F Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id D559E14001D for ; Mon, 7 Oct 2024 15:22:02 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TEUhk+ZG; spf=pass (imf26.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728314388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=82gpj2X+yyMlMyWQZ1+JrC17wyS+513wLraVsSGccjk=; b=te7p3ciRT9EQ+ZyVDf9XrbBjArB6jzQZ5nMWd5Uh2b+/EdilaAiYzkcxTn2ds7UDOmXBS6 O1gYmC8DOKeb1fQkwonx6dVCSX/AykJl8fNtIoazI1mPRY9VLekEfOn5r5v8obUYorhDi1 Pel1SKhPQnzalIDzJ/tMu2KD2cJuTQM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728314388; a=rsa-sha256; cv=none; b=Iv0+FLeVIpGvCT6pMYIaV4B18+LM+VHCl0LjGJTd1OgrUGS/CtCmFC53xq1Vyt1MYMi0K5 IlkZHRjYPe4elyv+jF2GMs4A9yWCQf9Z1LQIP8QtREcT3DN32oIN3gSkITRjg6sQUvkdVq xmTK4Yq8k1IYv/mpSEV/ef9LZD4sz+0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TEUhk+ZG; spf=pass (imf26.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8F08DA41754; Mon, 7 Oct 2024 15:21:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C6BFC4CEC6; Mon, 7 Oct 2024 15:21:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728314521; bh=ybYxVy1r0p6tcbHPiZuncPNcUxCTPsEMephcffmJyQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TEUhk+ZG9Rbk1bhjMTqO8MNi1Es4V2uWvDnkGdAQBzMLuokn2wpHMfM3ddu4LOD3L 7N1hYXuXDQPx2IXHP28vCQxFFBfVm+QvUJ8P69NdqawJ5cp0I46+wVvuKKqMuxqTA4 EuFO4Ae5neBPamxCsRR9OIZZSG4SQ4BItCvNaxV39wS7ERaXdaa88H9yd+/HzTncAs bd98vIOwHiNEXr8z+6AgjJPUyG8PbYp6QT8O92iQcfEJlLERiIlNw2SJMw2bnFNQn+ pzEi1BWlWOYeWSuR4yO43eJJaOPfZI59IVsrSIhI87tVnnLZr5JMj0vKtZo7xscTnH fVt3u/QLcuhMg== Date: Mon, 7 Oct 2024 17:21:53 +0200 From: Danilo Krummrich To: Alice Ryhl Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v9 19/29] rust: treewide: switch to the kernel `Vec` type Message-ID: References: <20241004154149.93856-1-dakr@kernel.org> <20241004154149.93856-20-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: etx8fzudz1wxnm7sgkx1818oyn5j7y36 X-Rspamd-Queue-Id: D559E14001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728314522-587510 X-HE-Meta: U2FsdGVkX18YRcbeJmzFdfMbd3oKslC4iJipFpYgPap2oaUo7QkS90b4Lw2yq9CWqJ2pZrJ/DhpKBy/ohGC13fAWFWJqWlC2+A1YP4m1i+EVjPL9/ojabL3Cz5UV5ci4ppiLt8zsB2GQtE2dSCkJVN9dc47/60eDlwcLV9HYCzJk2AoQKJwh33P8O0pz/EV06KXWvp9QhMvb2gNmZq0ZifL3Jybk6hWQCZkcS8Ukzx1CXFG+y6B9yxUbURQui3SKgHa3jZp5NBsjsq1o4b6j3JsZAVSno9bnyrbASF7SpS9dpj6CNFzt5W7kufFR9Sh8VKxwJg5BGgO9NEDwPKD83A9LO/q1Ig8iVp8UttGBa66CE+US5D7rVAEwWpQ/05hdKTEDjJe9r7JNwI3RUYt0sPecvQuL2iED10pW6Zd8kJOCuE8U5P2khKj4mNyDbACkZ211l1P6BiAB2x7FMpIQ6BXCGwVmSAHVJNXSQ2rb4M3Y1t8cjYAe9Sv5ff5tWr4M4yNQx5T8Ed/wohqZnRC2cZwPFin6FU7BSabrtWAXHBzL60QjkqHVZi9y2TggmkO3dGDgr+XHng0WWICvXF0ZhsEx2414XX6Fe8DFeQQ9R8bbOA++Iy4FJ9tBlXNFJ9GkzkLBfR7aI2jr8q60+0FS2Wo3xFYZ61dXsePBFI1S+qKaXJIWZn83AZmnGGAKc+jRYl/NoDSx4nYm+PPmiy8Ps88612JoQjceQHgMMMDo5id7opjWEOWYfpVqCgDe/qFPAR6fIlGifQGNz8CLI8utKhcVrLcJsbLrvUOagI4ucFQB9Lono8/xFFo5Q7scDGaQ0ay+C2dfPBz/k9qmYd8kHVolC38mCqYjVhSnRWC9QnXaf03tmxmfkjDqkjwXl/uO85LGT97gcxZ1cGRwMlfh9vqz4boNp4onP+QraJ9W/2fmE+ZKyW3CNp+VVWI9xTBFO81AGa05RyQwa4vWzQj aONhT0/W DOBtWPzkLFha8vBXdEEwyYxiEthLrTb2twPAgkR1awwuqmw9ZiszfUGvcz0Pi7GvKF2tQp8SX2QJnFp00SokmBH3jzPgBp3C0J6qK5aTQRlHtqzZyxsWyT2rxSZpA8Fj8A+gHHj5R1qhImTvDJTi1dAwiQd0sktX3J4biFEexqG6D1nuTKQD3WN8O2zpEgqs3IhZVGHACSPPZuPw9+f2ScJrgiVMXd1jLTUwWBRAorm56wrVyyPztw/y3bImxjxuV3BHsMQQWicKZfsv7xKGeXJnYpyATPs7/V2KPw9C6AI+NRKNA6hfLHfzPOcc7WXwgdA5TRRGGvcjKNZCB4pVM/SxrSlfPLMqbohBdihMjxMZCdss= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 07, 2024 at 04:34:59PM +0200, Alice Ryhl wrote: > On Fri, Oct 4, 2024 at 5:43 PM Danilo Krummrich wrote: > > > > Now that we got the kernel `Vec` in place, convert all existing `Vec` > > users to make use of it. > > > > Reviewed-by: Alice Ryhl > > Reviewed-by: Benno Lossin > > Reviewed-by: Gary Guo > > Signed-off-by: Danilo Krummrich > > This is missing the mm/kasan/kasan_test_rust.rs file, which was added > in v6.12-rc1. Thanks Alice for pointing this out. diff --git a/mm/kasan/kasan_test_rust.rs b/mm/kasan/kasan_test_rust.rs index caa7175964ef..9b222624ce47 100644 --- a/mm/kasan/kasan_test_rust.rs +++ b/mm/kasan/kasan_test_rust.rs @@ -11,7 +11,7 @@ /// drop the vector, and touch it. #[no_mangle] pub extern "C" fn kasan_test_rust_uaf() -> u8 { - let mut v: Vec = Vec::new(); + let mut v: KVec = KVec::new(); for _ in 0..4096 { v.push(0x42, GFP_KERNEL).unwrap(); } @Miguel: Can you please fix this up when you apply the series? -- Unrelated to this series, but I think there's also a "regression" against the lint series in this file: warning: unsafe block missing a safety comment --> mm/kasan/kasan_test_rust.rs:20:5 | 20 | unsafe { *ptr } | ^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks = note: requested on the command line with `-W clippy::undocumented-unsafe-blocks` warning: 1 warning emitted