From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: kernel test robot <lkp@intel.com>,
Jani Nikula <jani.nikula@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Francois Dugast <francois.dugast@intel.com>,
<oe-kbuild-all@lists.linux.dev>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 2050/2483] include/linux/fault-inject.h:97:15: error: unknown type name 'bool'
Date: Mon, 7 Oct 2024 16:41:09 -0400 [thread overview]
Message-ID: <ZwRHZVQr2PARUI86@intel.com> (raw)
In-Reply-To: <202410042155.On1ck1h8-lkp@intel.com>
On Fri, Oct 04, 2024 at 09:50:36PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 58ca61c1a866bfdaa5e19fb19a2416764f847d75
> commit: 91b2c42c214f570efaff80a666e30b8f6ce4f12b [2050/2483] drm/xe: Use fault injection infrastructure to find issues at probe time
> config: i386-buildonly-randconfig-003-20241004 (https://download.01.org/0day-ci/archive/20241004/202410042155.On1ck1h8-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241004/202410042155.On1ck1h8-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202410042155.On1ck1h8-lkp@intel.com/
>
> Note: the linux-next/master HEAD 58ca61c1a866bfdaa5e19fb19a2416764f847d75 builds fine.
> It may have been fixed somewhere.
>
> All errors (new ones prefixed by >>):
>
> In file included from drivers/gpu/drm/xe/xe_guc_ads.c:8:
> >> include/linux/fault-inject.h:97:15: error: unknown type name 'bool'
> 97 | static inline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
> | ^~~~
> >> include/linux/fault-inject.h:97:43: error: unknown type name 'gfp_t'
> 97 | static inline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
> | ^~~~~
> include/linux/fault-inject.h:106:57: error: unknown type name 'gfp_t'
> 106 | static inline int should_failslab(struct kmem_cache *s, gfp_t gfpflags)
> | ^~~~~
>
>
I thought that had been fixed by commit
6ce2082fd3a2 ("fault-inject: improve build for CONFIG_FAULT_INJECTION=n")
but it looks like some config case missing still?
> vim +/bool +97 include/linux/fault-inject.h
>
> cc689c5b352d4a Ingo Molnar 2017-02-01 93
> 0866e82e40fba4 Kefeng Wang 2023-05-16 94 #ifdef CONFIG_FAIL_PAGE_ALLOC
> 53dabce2652fb8 Vlastimil Babka 2024-07-11 95 bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order);
> 0866e82e40fba4 Kefeng Wang 2023-05-16 96 #else
> 53dabce2652fb8 Vlastimil Babka 2024-07-11 @97 static inline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
> 0866e82e40fba4 Kefeng Wang 2023-05-16 98 {
> 0866e82e40fba4 Kefeng Wang 2023-05-16 99 return false;
> 0866e82e40fba4 Kefeng Wang 2023-05-16 100 }
> 0866e82e40fba4 Kefeng Wang 2023-05-16 101 #endif /* CONFIG_FAIL_PAGE_ALLOC */
> 0866e82e40fba4 Kefeng Wang 2023-05-16 102
>
> :::::: The code at line 97 was first introduced by commit
> :::::: 53dabce2652fb854eae84609ce9c37429d5d87ba mm, page_alloc: put should_fail_alloc_page() back behing CONFIG_FAIL_PAGE_ALLOC
>
> :::::: TO: Vlastimil Babka <vbabka@suse.cz>
> :::::: CC: Andrew Morton <akpm@linux-foundation.org>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-10-07 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 13:50 [linux-next:master 2050/2483] include/linux/fault-inject.h:97:15: error: unknown type name 'bool' kernel test robot
2024-10-07 20:41 ` Rodrigo Vivi [this message]
2024-10-08 9:30 ` Francois Dugast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwRHZVQr2PARUI86@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=francois.dugast@intel.com \
--cc=jani.nikula@intel.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).