From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F52CED26E for ; Tue, 8 Oct 2024 06:23:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B92A6B0083; Tue, 8 Oct 2024 02:23:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 941AF6B0085; Tue, 8 Oct 2024 02:23:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E2806B0088; Tue, 8 Oct 2024 02:23:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 602BE6B0083 for ; Tue, 8 Oct 2024 02:23:04 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 498F9120C24 for ; Tue, 8 Oct 2024 06:23:03 +0000 (UTC) X-FDA: 82649442288.04.0E7F46E Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id 6D2F514000B for ; Tue, 8 Oct 2024 06:23:02 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="HLZ7O/Hp"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728368473; a=rsa-sha256; cv=none; b=MJE9EEwK8Jb/mnRZuuOKl60P6f+9IqsgmqjOmOzJ29IrFH0AsJl47Z1cULpGk4FzbgZcX9 jUngt4WTlcgKYyYWiNol7DWYGC2IJ/HzxKBMocidj8gcQJAWRCOBBsPz49cQRPpzZgI2FD aH5Cb7r2VmrZa55gDN3ZWK2u+Qdt6Jo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="HLZ7O/Hp"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728368473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2ytn5ipKOi2iwHXLlnzsD5i06mmFCc0Gkvx6tbtOc3M=; b=geb6gBUpZXIxeCVRhRN6qE/d193hj87r/e+wBeBhesT1DG2AEtAtOqIqCNUbRYn592O0yQ bbdxh14bo06VyWuJLHBL9JsmIAJL3e1Mf0YEArZeBZzq6NCeZ+OnqBqIfa5qmD/hWJAX0d ZzZ2Q2I5RGKrWBKKaQ4AGYpCWybwxZE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id F05D1A43229; Tue, 8 Oct 2024 06:22:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C076C4CEC7; Tue, 8 Oct 2024 06:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728368581; bh=7+OOlYDwjjrmYkugp0zG3rCIOBJXVhabkZlBvijiN0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HLZ7O/HpKqwZhtBX1cNCiAk8EV6vD0WzAl1dR/RILMS7jSHhGDnYDNH2Dzn6ECEly M0+GSr/JGL8nAopaejPjKSQKa6Jmnx6kHabKvo9FyggKvIK/+rwoLnO5mphSBOrVi8 U9wdgL7Nl7zM0jbSh9FiGcxw5b5J+su+JR+7Gf4XG9wvT3v6GVYlXJH8m3l11OFKZ1 9jEHuFYuJh2kBStvb3JCpXCoRR3L/JiHNjMlM70jCbMyIiQEwYJp2wijiSZ4G1su3J 9j8W/sm+G2yCx41UsRZ1DC/eNueJYqT+Lq5WzrcGaGCVNkuw9bP/AltQfceSnkaSt6 lK+siW3UD/EyQ== Date: Tue, 8 Oct 2024 09:19:13 +0300 From: Mike Rapoport To: Huacai Chen Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 5/8] arch: introduce set_direct_map_valid_noflush() Message-ID: References: <20241007062858.44248-1-rppt@kernel.org> <20241007062858.44248-6-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6D2F514000B X-Stat-Signature: 6h3pohn5t3jytrbckew98zu7zkdjog39 X-Rspam-User: X-HE-Tag: 1728368582-88095 X-HE-Meta: U2FsdGVkX182C9BhW2jcX0E7O9XBFkrCNA1nO8HMX4kfsnTrIEJiyNjty56rCRpMaohvzcq0fVu74k2w3CEhxdEm2HUbaj5oiIt3chHIFEu7l9O1WthRvZG/uCey5TkhAUaoWz3N5M58vP4U4fzeMQtFVxhI7QwxNGfa/Yi/vs3jw+6EUwALjt63NdLkM4cRZgp33ufqJu142WGvlDJuvahhcUEkqgSS97I5w+vsyZuOIljrG5DZNGSiSsNMsVgIc6FDuROzVmrS/G91g1EpaIOpo0JB8uR1TgpE5efhyAMNJQyMHwgBmcWrkG+RVAvi0kFp/97/WUU1zBSB5d56jXlQUJI7z7JUnB/LuV9jl3VQ5zexESP8E020TKdQ4eRMtYLO/qochLGKMesrt2/65pKFhsootlSANoLYis03O9Y4UJ0qIqk1p6NdHWkZoUAQhMlY4mf9W6/yz5xGLAF+G6ZmpEGvMEtrWgxOpYq7pmPVNL2ynLY1wTJ1N75dlwMAMns0sjKF6S/dFImE44pWD9Q7YXHJ3xvRrdIdjDQ9MYrVvO/TRhxEeMpaTIZmJg2SbL4v0KES1zdvN2zlGcP3ZriKSk5vn4Gn2VHMYi+hmppm488eKLnBS2g50Abdky/q6UF7e/Uf9hQXXNh4pW5psPzF/C9d4R+FODsA9zlGfLPSWaz45HKvTUKqSOOtMQNdBSCkgAX40jP4jtVeVOZ13AQHbcQf+jEvLMC/7+ompT/Oux/hGyZ0GGjKlYhKolEGxr6YqREQBdZkMakxv9ISl/0dx5KwC8pMhSgwOjbRu83huwUxd26lOqq0kPR8e/a5Fn580gh/FgZeW6mG60Jk0WjMNQkEB06Gx+WAUCcpjf/3AkvWN/Nc8CPv7t8fgdsjcvIs6opflQtM/BI67feGZu331nyLHgmy1Em2xHuEwlFRf0DlPtk6X6oHCpYPEc/xtx6EPYoqgAUhVxMl7ed eE4I0AwX u1+gRRr6D+zTFz0k6kx1tLfasSyXx4yjvnyKDYHOUrlk3qB3K1t/9Z//AM7CDYmWRnO7ILxFzqTMeDbqIvTthxWfkK+OyKPqt/AK2AQjlRtOsETVtiKXS+ueDEhgGMMYWXZcpC9eSHNhMNodY2y3uNRzHjdElEbQ3AMvIcHHrfnccbxB/yBWrmfVPNF0elCy7w/57pMU6SV6/ezy17UAr8RDfLXfA/+yQ9zzGqD3XuXWzva/nASCyhXNqFrdSNpQ1ea1OQ9CFpKDnq/2JSTus1dZUwRtrkXJdHrmhOKkr09CcgRYOBSnqOTZSqBI+egnIuNMfWMQyiu64WhJkX7L1yF6sW9kY4q6uvgyx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Huacai, On Tue, Oct 08, 2024 at 10:11:25AM +0800, Huacai Chen wrote: > Hi, Mike, > > On Mon, Oct 7, 2024 at 2:30 PM Mike Rapoport wrote: > > > > From: "Mike Rapoport (Microsoft)" > > > > Add an API that will allow updates of the direct/linear map for a set of > > physically contiguous pages. > > > > It will be used in the following patches. > > > > Signed-off-by: Mike Rapoport (Microsoft) > > --- > > arch/arm64/include/asm/set_memory.h | 1 + > > arch/arm64/mm/pageattr.c | 10 ++++++++++ > > arch/loongarch/include/asm/set_memory.h | 1 + > > arch/loongarch/mm/pageattr.c | 21 +++++++++++++++++++++ > > arch/riscv/include/asm/set_memory.h | 1 + > > arch/riscv/mm/pageattr.c | 15 +++++++++++++++ > > arch/s390/include/asm/set_memory.h | 1 + > > arch/s390/mm/pageattr.c | 11 +++++++++++ > > arch/x86/include/asm/set_memory.h | 1 + > > arch/x86/mm/pat/set_memory.c | 8 ++++++++ > > include/linux/set_memory.h | 6 ++++++ > > 11 files changed, 76 insertions(+) > > > > diff --git a/arch/loongarch/include/asm/set_memory.h b/arch/loongarch/include/asm/set_memory.h > > index d70505b6676c..55dfaefd02c8 100644 > > --- a/arch/loongarch/include/asm/set_memory.h > > +++ b/arch/loongarch/include/asm/set_memory.h > > @@ -17,5 +17,6 @@ int set_memory_rw(unsigned long addr, int numpages); > > bool kernel_page_present(struct page *page); > > int set_direct_map_default_noflush(struct page *page); > > int set_direct_map_invalid_noflush(struct page *page); > > +int set_direct_map_valid_noflush(struct page *page, unsigned nr, bool valid); > > > > #endif /* _ASM_LOONGARCH_SET_MEMORY_H */ > > diff --git a/arch/loongarch/mm/pageattr.c b/arch/loongarch/mm/pageattr.c > > index ffd8d76021d4..f14b40c968b4 100644 > > --- a/arch/loongarch/mm/pageattr.c > > +++ b/arch/loongarch/mm/pageattr.c > > @@ -216,3 +216,24 @@ int set_direct_map_invalid_noflush(struct page *page) > > > > return __set_memory(addr, 1, __pgprot(0), __pgprot(_PAGE_PRESENT | _PAGE_VALID)); > > } > > + > > +int set_direct_map_valid_noflush(struct page *page, unsigned nr, bool valid) > > +{ > > + unsigned long addr = (unsigned long)page_address(page); > > + pgprot_t set, clear; > > + > > + return __set_memory((unsigned long)page_address(page), nr, set, clear); > This line should be removed. Argh, copy/paste is so hard... Thanks, will do. > Huacai -- Sincerely yours, Mike.