From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93905CEF17A for ; Tue, 8 Oct 2024 14:32:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C8F86B0083; Tue, 8 Oct 2024 10:32:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 079556B0085; Tue, 8 Oct 2024 10:32:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E829D6B0089; Tue, 8 Oct 2024 10:32:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C93C86B0083 for ; Tue, 8 Oct 2024 10:32:35 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6DEC1140329 for ; Tue, 8 Oct 2024 14:32:34 +0000 (UTC) X-FDA: 82650675870.07.D463918 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id BD20020002 for ; Tue, 8 Oct 2024 14:32:33 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F+MnrN8L; spf=pass (imf13.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728397885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wsrlURpFGI4cCFH+U3hlF0GN87dSFGbL3JtNiR5enWQ=; b=MqvWmOYQq52vBNG0Z9l1Sq58gcETQgknn9DRbM/jz5GpP657JQojqkImjAoVLNtbpxXJfh LDqcZ1t4P8AM6PMhYc9tKc5kTzucOnw5rRDpKfsnWNcPCOaTjU9KQrHxaXxA/LPi4S5h0B Ga9+MtBWivCWi8EYjhHE0iQrQn6R8zQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F+MnrN8L; spf=pass (imf13.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728397885; a=rsa-sha256; cv=none; b=gB6TA8dEfQD7My2hggB0uMqQw4N8HkQpDFAEzomjsFicNuMZSbjvztiXSgYLkAIbiEKj7L FQE/vMAURs/cwOse6bEITN6vByP9anu5YgCeJpjusD6nT7fmY3fFzxfg/dsZ0FGKt+ASTE OrpBIGEPp5TikFqCnx5WzMk2LxxCiTw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A09765C562F; Tue, 8 Oct 2024 14:32:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5887C4CEC7; Tue, 8 Oct 2024 14:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728397952; bh=t9DSeeXfOlcRotreqKbSLlHeaWLMsRoQIASSMIB2hwg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F+MnrN8LCmWYxWqnxbR/QkkXoB/84sd2a4yRgwzGvjfEp31aAwR/+q6fr8sOjf6eP mjmyVgiOU3A7pgB6Vu06FndHVTm322OhTvffGOZ0+XQj2OVxc/MHl2Pcnu62ZSj8un dCWe4d3dY6rGiLZrWz376i+xyJ+F4Yn6CHXcjcs0LhCRs2qALHS0pg6+ulcispOwbf UMs6KGdsmKRuj8sPM8NCK0yO8J/U0DQHwpz//VSDDmuzKgiE9Xg5N+QZsBPChGwChv uVstgtL+TNtLyzGlL+xvqGcJwdHaV5H3fp9tieoZN2MP+4/168EI+XuF/cirjHhZnM 6oGcL6LXXbb8w== Date: Tue, 8 Oct 2024 16:32:25 +0200 From: Danilo Krummrich To: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v9 25/29] rust: alloc: implement `Cmalloc` in module allocator_test Message-ID: References: <20241004154149.93856-1-dakr@kernel.org> <20241004154149.93856-26-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241004154149.93856-26-dakr@kernel.org> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: BD20020002 X-Stat-Signature: bmts8w9pk9nfucwbk714pj9uiyja4sko X-HE-Tag: 1728397953-663849 X-HE-Meta: U2FsdGVkX18jPIG9fhTvyl8nW+mqUJWDhtVHtysoGjdovIXEJUPFfc4E98h2y+5eq1iYK3KX1T0LLy0lHTJY46EBhUhNpM1eklstb/slLPJuwxzBtLMwcjCUtntWirH5N4TGdiBn9mKOehU0kHJ+fhvPhIkK5N39yocFFhbCH9+xCmi0jPQKdp6/MrmxjMn9IR7qkidw2Ow+rX6IRT/J1W2D3hacINLOJMGn8MBF1F3yvl4sEj1tp9mvcKk1wHa6U1rdnPBImHDqDgkBfOn1olwLXfTNyd1aSGGcINMLPT0hQZikDaVPwV6C/w+CvGPeumPDYqSf9Ku2udWA1mXD5m/eUGLFyVkDIxdpvdpgYkZ6PekkpBzTY5W9NJGIZPtG5Kdy2cmiyYugNCGQjk9u0gS6Srxc1ebHoPsB7gbl8R9ygvt3MUiF8UzzDWofqKf3QuFrGSzGJeJsvnhCneMldodM/VXhKZX9pm14He6k1ezLD3TqvJuN1rGbHjYDs/3pIHvU1b3PgQcOwxd2c+tt1iBGbJhN2DV2t+9JfLXEFT3udOzIaS8FQkWksM5P0DTVbL9XIJQ5lW3HomuRanBtlo7U4vRptCYxKD0AWYrrYrxHbuhQhyPB2sjZdzMUkRBYnm+fuJmtu0g8XZKbIkK6/KNORlTtY26qac3SWjr2Pr2i0hNUTRRuv/15DeJbjAt+RrkCy/t7iB5P2az8nuCE0vVKqVcP6juCzJyFVWmpqS/sySYJ8Z6d8FIha+0aBXbWLPjBX4wifgkiEdRnCEetF9OBLCDCfc3i7GtFvFwlG9pHQXqYNSUK6X0r6alAd38kR44kx5zcDVrIbGok0kNXhehQ+K5laVblVo9sfiQajY7UDbIKf9r5EbI8JPdIxxA8piq6jM0jO1LavovwM7SD2nSN6lwLISnjbmrcdy3yTSsgdEEs76+/5abfr2t3HAjtEprn1uDM3igT/OUBJJE u/xTP1Np tU2KbSvX8DBLBlUBBbURm5UChgGGRD7r02wcg+GleeNEDfPXjUECvbZjMbsHSmKg1iH0vBVBfnRgCNDKItF17uQojSzhK5NFVECtGzwbp6RMZdbx99SKidLzK4v+I5DVatDsGmBeWj1+t8IJAyfj7tq9IFd4F/UdWOEEvLN0SMuA60YaCb1s4bet8yRJ4wMVe9qnQYxLhPW6cLJQjol2LG4aSm2UjY5r5cBOHk7+j5dWS2FPJiV2q6cY79ecMfrQtEdPCv/v0ZMsxHGvHIJKNjLUBRARka0R+9mPv9LnYtZVOEspSAXMiop0PWgyOP2Oz6p3X10TMgRvNoGrrQvlLd/lZdJX3Wts+drzHhdzKaEMmMwgvRjzF/Qy1RCscF3EbWbw11whTzLIxW2+4thuMNJ1i92/r6hnIn3knmcVVvxUs4+EyMESyR9NhjDxg3GzvXtFlXoAwU+d1DCs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 04, 2024 at 05:41:29PM +0200, Danilo Krummrich wrote: > So far the kernel's `Box` and `Vec` types can't be used by userspace > test cases, since all users of those types (e.g. `CString`) use kernel > allocators for instantiation. > > In order to allow userspace test cases to make use of such types as > well, implement the `Cmalloc` allocator within the allocator_test module > and type alias all kernel allocators to `Cmalloc`. The `Cmalloc` > allocator uses libc's realloc() function as allocator backend. > > Reviewed-by: Benno Lossin > Reviewed-by: Gary Guo > Signed-off-by: Danilo Krummrich > --- > rust/kernel/alloc/allocator_test.rs | 88 ++++++++++++++++++++++++++--- > 1 file changed, 81 insertions(+), 7 deletions(-) > Here we can remove it again: diff --git a/rust/kernel/alloc.rs b/rust/kernel/alloc.rs index 912b6ba2abaa..8acaa24a8f1f 100644 --- a/rust/kernel/alloc.rs +++ b/rust/kernel/alloc.rs @@ -215,7 +215,6 @@ unsafe fn free(ptr: NonNull, layout: Layout) { } } -#[allow(dead_code)] /// Returns a properly aligned dangling pointer from the given `layout`. pub(crate) fn dangling_from_layout(layout: Layout) -> NonNull { let ptr = layout.align() as *mut u8; @Miguel: I pushed [1], which is already rebased to rust-next (-rc2) and contains the fixups. [1] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/log/?h=rust/mm