From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF9ACF11E9 for ; Thu, 10 Oct 2024 13:01:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E382D6B0083; Thu, 10 Oct 2024 09:01:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC08D6B0085; Thu, 10 Oct 2024 09:01:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C39846B0088; Thu, 10 Oct 2024 09:01:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A05406B0083 for ; Thu, 10 Oct 2024 09:01:27 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 598BC1202C1 for ; Thu, 10 Oct 2024 13:01:24 +0000 (UTC) X-FDA: 82657703814.17.C4C466B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 41E5E180027 for ; Thu, 10 Oct 2024 13:01:24 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="i15xpEq/"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728565241; a=rsa-sha256; cv=none; b=KXqS8x5apMJm0alMwg743UtouPAZFVR4Tn/Lx4l7RO790R6lm0+C7uNF91CuKH7xM4KgI8 G0mCFsEqntqh4ieXFXJcdI+9LIL2uRiBGKnhDH45VadstWk/w65mHYyvME1MYYutUlQSoH zhS9889jsooCZnSWNBFhig3QxV5PyWw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="i15xpEq/"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728565241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cPMXZCtGVsXXTQe/GGlDBbrLC+/ZwOWPH4PT2f+WeoU=; b=SGkFqI0H9sL8lo7cS/AvRL0YPVVhD67wMAxPJIVZgPbsqPUPuXfU8R99sX8AueDWWKZj/j +8ljw/JKUNjNUED4OOwvmAx8+3QEqq3kIyDVr/Nmjw0CfSfB6/zlRG6rP6FGwuU9Zn0mDF T9aWQkP+RzSpOEB9/LiPoA1lhXPIPdY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 645C55C57C3; Thu, 10 Oct 2024 13:01:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3F0EC4CEC5; Thu, 10 Oct 2024 13:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728565283; bh=0gFND+MAHX6q3fPU9Dm7aa3AX+VkNdk2ZdK9663ePGM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i15xpEq/kuFAv6DlXG15A1e80Zkeyfpm7KcH2z/4b7LHy0huNtJIfhTPl8l4m2Thz DrC+EerzAtj77QkSwvdLuoM9HsdVcSXAYblfY52ni7z3rWCwNvYecLnzzamyv05TxQ MvyRQw4iBhqZGVncP0l5I4u44ZK9GkUbVv2NjZJ1KmbX6KkRkPzCVKd/P5aEdD5W04 r/juMpxct8TYbYtPQygo8mwFvlF95PkeOYNJV8aiyjpOL0HlbI0t0P6KYVnwxFYXRs bP4FdthxlHe3zfpEHTln3UXCWui5XHPdWaBkcJjwrkqkqBVwNb4EXbX5FI3Wx8W6oT ueyyZehAwF8+A== Date: Thu, 10 Oct 2024 15:57:33 +0300 From: Mike Rapoport To: Christoph Hellwig Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-8-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 41E5E180027 X-Rspamd-Server: rspam01 X-Stat-Signature: m9mx3pyctik8tzj94c47n6sxue46dn3p X-HE-Tag: 1728565284-731585 X-HE-Meta: U2FsdGVkX18Xj53OIzuQStDh65tpitGPe9HwjbHzgc5Mxgbufbn9VSKvT8QRY9uAYcuOasCurUj7m3iEtgS3HJEvv/MwFVyXjFV17iEA2S6p3GuujXJxJr3XuWVCIYcMrwZL5ZXIIQo76N2df3AxJbKZyiBnt+ZV/C2o8KU4v04HrOZH/KEX1MtUyIcf1dXSonPTd0x3P+RstaclzhsLUfObxcfyLVAdsIpvo/dEaWSG6HLc8djB25iPuAj2Fpx4P0JA+ZylMMugue66elnggf/H28nf/wo5oLNwVoac1xotNd8zDh+sZsNumF4aSnsDrb4YPK28YWylRqJh3IaAVzbIhIqAiD6pEqPpxD0SskWx2HIN/kWvlHJpduIJjHZYHroVl/SbT4GDyko/hB3AMOyv4hpT9Pzg7+e/6ZrNApTRidR0CaXsjJWw5RpKcwNb59MnyhfXrHdmMoI/ZJ13izVko3lFHdPH870BwFPcZXJ3wXEz8wE1Bng/CzQYv8vNxagP5RtnOJQ/LWzj0kdcX6l8AW8dHZdMKdAUjb1U5BJ1ADAZcl8vubE88F9CVJn7as6BM2pZhphjEEcfL/ppDNnLR4IWX93TaO2xEwBm8M7gAzjzmvzG7GRmsvny4V2CkjKO+SWJ241VxoZj77JxogtWijgX8v50+8XUsJKKX+mQj5eYEt8j+fAwh1TLToIINMMFbuQtt/svy5aTDMnmBlBLYtCQQkdxqjHZuNLtsSsdEO6nvYk/5mKXz2bDAfzi/YP2COGB1inPzMBx99OQ9HGxC8ZqxHI+9uTgGt2bI+SZDkAldr4Fe9XiA8O3dlYImUE161Ot8Gzg63oyzSznioxrUFIfrrfh6aWtrpvNqTz5yshJCwPSU4RrCBk/Zz8OZB9jRasBfpW7vQOPvdFCDrsrzaAarPzMhWjC0T8U8eoeKI2a5h6OZzdB8JPfgF4lFAQjDcGUQU14iOxpEXx bv+w4PBJ 2JQHTdbv8iyhbXgtwbVF4RVa4w9T3vKeX7YAIEQ6hPGAk8sYFuZIsizcKyz1a//Vv1yqCqX1oSjWpzrAuvyWafv811LLozb38MaOaCH8ie7X7hWJvV+mP9qoK0Fe61R5OMU/tU6urW6N7fxhwRsacReSb46e9II44oYLgxcYpxbuzn2obcjw1G4mu2rB2b7Zw2jxFDqrK1iQTLu9y8py7CVG1C3yiwhK8rSODb+pBhYYDrgpUFg3sHMqddxn/siD697B7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 09, 2024 at 11:58:33PM -0700, Christoph Hellwig wrote: > On Wed, Oct 09, 2024 at 09:08:15PM +0300, Mike Rapoport wrote: > > /** > > * struct execmem_info - architecture parameters for code allocations > > + * @fill_trapping_insns: set memory to contain instructions that will trap > > * @ranges: array of parameter sets defining architecture specific > > * parameters for executable memory allocations. The ranges that are not > > * explicitly initialized by an architecture use parameters defined for > > * @EXECMEM_DEFAULT. > > */ > > struct execmem_info { > > + void (*fill_trapping_insns)(void *ptr, size_t size, bool writable); > > struct execmem_range ranges[EXECMEM_TYPE_MAX]; > > Why is the filler an indirect function call and not an architecture > hook? The idea is to keep everything together and have execmem_info describe all that architecture needs. -- Sincerely yours, Mike.