From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D63F2CF043A for ; Fri, 11 Oct 2024 19:46:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CB2F6B00B7; Fri, 11 Oct 2024 15:46:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67BAB6B00B8; Fri, 11 Oct 2024 15:46:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51D0D6B00B9; Fri, 11 Oct 2024 15:46:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 304526B00B7 for ; Fri, 11 Oct 2024 15:46:05 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6CF2A1201FA for ; Fri, 11 Oct 2024 19:46:00 +0000 (UTC) X-FDA: 82662352164.27.05ED630 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf02.hostedemail.com (Postfix) with ESMTP id 7334480015 for ; Fri, 11 Oct 2024 19:45:57 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=3KG8Vj6e; dmarc=none; spf=pass (imf02.hostedemail.com: domain of debug@rivosinc.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728675810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=exLsQV8+AgRTzSgIuh9REhlgyhIFFL6ykktOdGZoGFg=; b=ojCXotMLryUQknjkF54Uu9OwQMUkN0hv6Yrc0uj3rYrEp7f1pPHxQH2kVTQHbEPgNCPrCG hxYfhQchoHaNj9cBr63v+9SA+iYUlg3zlu9pLkQhGrrXskUEJJISH2hrriGPZSRZnDP5Fd Pb5WaHquIBHYnnFz52nYbGdl57ArVCY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728675810; a=rsa-sha256; cv=none; b=wfigt3pfyT05YgqAiDm1OIuvmJpiOdwE8dsubpWIofmCYvCOcudJW1JN97E12UrVurhZsR +WVtvPjf+M6mXL8EwXzQhX1b4PczCO4oKD+B3daZQA3p4wOg8T2mG/VMctJHt9f5bof28j cCRfExsHhU/mCKgKMxhjW8nQUtzKH4I= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=3KG8Vj6e; dmarc=none; spf=pass (imf02.hostedemail.com: domain of debug@rivosinc.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=debug@rivosinc.com Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-656d8b346d2so1610194a12.2 for ; Fri, 11 Oct 2024 12:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1728675961; x=1729280761; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=exLsQV8+AgRTzSgIuh9REhlgyhIFFL6ykktOdGZoGFg=; b=3KG8Vj6eWgFS15vGeplfhwWwhdYsVagKLixvbwLoLDAbte3hLfbWtD2PDTSfhY9LB6 VVvDb/VH9QyOJOZFlXCuN5hWP6/h4k7tPScDMTrqv9+sK5CkWOyVesCS+TndxBkWAPR9 0lJgZG28Vc7lezGUvZzgv2KRFd6AMOXe3tOmMI1952EfJfD2a8wOicWpewMKrcVO6OkW WWrV51UE0WRM7zt0ER9DSESfC9SsIFerjCOtcSxf7I/j2SOTLzdGi5Navwry8U6xM6Xy hLtRut7+VU3D4UyLHcAAEttvrsI0vwmTyoqKoiJKBN4TubVv43CqmMINsFeLL1EvOfXa YYTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728675961; x=1729280761; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=exLsQV8+AgRTzSgIuh9REhlgyhIFFL6ykktOdGZoGFg=; b=xMWRGXbGrjfgCDdE62GY/Vv8GQnGS7yHQuHMvlJyZaKUR9o6d6mSR7/jUpiXxN26d0 EoP/mRt6UeZsvVzTWCErn6vLS5Sblx1eZ5n9Pac39SW7CgFxH1tju6DgLmjAZdjqiWfS 8mXzOHDvPSKoYsK5Sc5zTCNJoLoLE8sk8aSxdUb9KF7X6BpXhvJ8TAkhBzoO8u95RsQC iUf5XVpPqqCo/wLCKJtfbgf4cYdUeS7if8nwJ+2ffRnEIIblzHz331HVKYdfPoIDSC4+ zJcDN4JEj39SSvoJlpGYLofcFUsMmsZYweaY9U6o4E/IBCbYBlr5whTySYAY5UU1u0Qc n/0g== X-Forwarded-Encrypted: i=1; AJvYcCXR10BYzCIfDdU8Xz9RTzKSH9K7tGACECo8p7GbJm/gl6XDOjnY0LooItUQQ99QVRDLzNLgb8GbIQ==@kvack.org X-Gm-Message-State: AOJu0YzpYckyVFHeGoj0QMGR/ZuDDkA8PxSSXIONnA+aPbKw9atnWeQj hxYoW3EmF7144606HbLABmb6UI98A8lB873qJ2QU7OzwSGMf++Y0pGxOO506X/w= X-Google-Smtp-Source: AGHT+IHj8rWFWjfeD1jnOseU69L54Nubw7fuAuLENErbM2G1CFqjE5ekNxV2rf8nSVkMr8qy+VgzZQ== X-Received: by 2002:a05:6a21:1519:b0:1cf:4d4e:532b with SMTP id adf61e73a8af0-1d8c96b986bmr675268637.43.1728675961468; Fri, 11 Oct 2024 12:46:01 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e2ab0f1dcsm2951118b3a.209.2024.10.11.12.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 12:46:01 -0700 (PDT) Date: Fri, 11 Oct 2024 12:45:57 -0700 From: Deepak Gupta To: Zong Li Cc: Mark Brown , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, rick.p.edgecombe@intel.com Subject: Re: [PATCH v6 33/33] kselftest/riscv: kselftest for user mode cfi Message-ID: References: <20241008-v5_user_cfi_series-v6-0-60d9fe073f37@rivosinc.com> <20241008-v5_user_cfi_series-v6-33-60d9fe073f37@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7334480015 X-Stat-Signature: bt83w3b8izjrmbs9c7cnnjxm7bosp8f4 X-Rspam-User: X-HE-Tag: 1728675957-600873 X-HE-Meta: U2FsdGVkX19q0ZnjHU29LhABpHXJlAiBr5WqrmFfQEEDzwGaxJMdxdyE5DYuAKSNN4qTpO3EFQNwwy8kwllCrFQfHWX8ivJIy+3xhTz2WcAlzPNb80cSMq/ELYCb2flNiq4o0maborxaawsgh2xv1JwH5XPhi0pmUtECG/vSjNYiJfhBigEcqOIvWZ+10wqrmMKhS5PaeTNPXDeNByZEEv+rL3mvHkd13O/peP5kIyx+/zqggNC46ANHYCU4JWVjLwyll0q5+pK/+RInfv6qRYjTrUrdE89YXp9y1fb4sH36SKcWv/dAnnac0Ahrr7uVN8LszjJijE5O34QsO0sy+lvt98o+cDBSYnWRD9LnQw/jGTBWU3+F0P1g2u8Fy1IU6beuhS7ckpwbKjt9PUJkTasX3n+x0g/l8ozXnC0/76IBw2viYxAuwOuQSU9vLWDY8yhQwjVitOsmlp+VIMeFuv68ApfkjKzi1GzSHRaSJo2ozOn5YxuV+f75D5eMBI+HdNghoyrfHeNje0kPalrTG0vARUurdg6OjNbvzvZnwDUWmkUZe8YtjtD6yedyEbAEe9pHWhDEppDO37VmquCqUzN6Eo+f2vCwNOhTcTGYAcFfCpqdrr4dYNKpAopIynW2aJ+4Pp6ppuFKuqrQVliT8TZSILp+bBzec2mV5z2BBuiqf4BVfQNbbxDcgrQwxdwPJQW3ayTWyuRp3HeUwtgT/U/TYUtdaxiBASw+34PBV1tq+rxmKsRwRwchvBXVlTXx5GqetzpnzUn3qVK8UxcQCrlW8lMD0fIHN5+/YRAJkqbm9ga1/yYBqXWk6j+j8M2Upv6cXRxygct0a1EkYOSlDD7gxt8jRyEylETEhfVIxh8WhlEYg3dcIvEmEf4UGeCKR6pBG03b0+NJ+S2z7sV9iS+ceZhFJS1ejRQBh8H7QYvk51NlokW/4ynW3JhtybwfBElCeNOajK4Bs1n0YIW UrN2IYWx oN0LN6kRgj2c1QmljgOzByx1gkJtO4mmfODC0yDtBaeUzR4fX/czIBt3KKzS260Z/NBZCJlSTCM3hkL7GCOC330q3RfQ/NuZes15IdaTgrfK/2MvnsLcMNUXHCzog9WQlQ+WIm09nL1EfhyA0Mo/YsJbG/jQst+fCYYvim5mxFytZDfI0KvI8nMU6U9CJX+pjsC2CCn1YIIwA/rz0ovd0SoN9UB8jaDl0WNbzz97M348TIaiYNs6z4FK+2jvWpxM5MgUQ7eVyflk7EZWjZDr6EapKHS9JHHqFx781zRy5GMlH7RUddu9K6DvVXo1WhoAvDKjt7nGdQ5XXGbH6OJfBPXxd0lWKwCMgyXGLNuhB9Tb3rfAOHyJF5bUPPzk9TWdpPcdSx1MYXIFd5KLjO5VnSp7Lz/lU2EnMkLzPT99pybjZ0AiV4aO0ZqKw04vf1vvYRPnzFFzdeXBVMITbwTUKv9cRgx4pIgcISOlndBnrxRXzNx8Dxi9OYusi8kiZcWdFHx16afs71AWMRNhR8cCTJHbzSRldb5H06M4NytA+pVwZHgs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 11, 2024 at 07:43:30PM +0800, Zong Li wrote: >On Fri, Oct 11, 2024 at 6:18 PM Mark Brown wrote: >> >> On Fri, Oct 11, 2024 at 01:44:55PM +0800, Zong Li wrote: >> > On Wed, Oct 9, 2024 at 7:46 AM Deepak Gupta wrote: >> >> > > + if (si->si_code == SEGV_CPERR) { >> >> > Hi Deepak, >> > I got some errors when building this test, I suppose they should be >> > fixed in the next version. >> >> > riscv_cfi_test.c: In function 'sigsegv_handler': >> > riscv_cfi_test.c:17:28: error: 'SEGV_CPERR' undeclared (first use in >> > this function); did you mean 'SEGV_ACCERR'? >> > 17 | if (si->si_code == SEGV_CPERR) { >> > | ^~~~~~~~~~ >> > | SEGV_ACCERR >> > >> >> Did you run "make headers_install" prior to building kselftest to get >> the current kernel's headers available for userspace builds? > >Yes, I have run "make header" and "make header_install" before >building the kselftest. This error happens when I cross compiled it, >perhaps I can help to check if it is missing some header files or >header search path. That's wierd. It doesn't fail for me even if I do not do `make headers_install`. But I am building kernel and selftests with toolchain which supports shadow stack and landing pad. It's defined in `siginfo.h`. When I built toolchain, I did point it at the latest kernel headers. May be that's the trick. """ $ grep -nir SEGV_CPERR /scratch/debug/linux/kbuild/usr/include/* /scratch/debug/linux/kbuild/usr/include/asm-generic/siginfo.h:240:#define SEGV_CPERR 10 /* Control protection fault */ $ grep -nir SEGV_CPERR /scratch/debug/open_src/sifive_cfi_toolchain/INSTALL_Sept18/sysroot/usr/* /scratch/debug/open_src/sifive_cfi_toolchain/INSTALL_Sept18/sysroot/usr/include/asm-generic/siginfo.h:240:#define SEGV_CPERR 10 /* Control protection fault */ /scratch/debug/open_src/sifive_cfi_toolchain/INSTALL_Sept18/sysroot/usr/include/bits/siginfo-consts.h:139: SEGV_CPERR /* Control protection fault. */ /scratch/debug/open_src/sifive_cfi_toolchain/INSTALL_Sept18/sysroot/usr/include/bits/siginfo-consts.h:140:# define SEGV_CPERR SEGV_CPERR """