From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 425B3D374B3 for ; Thu, 17 Oct 2024 16:09:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4CF06B0088; Thu, 17 Oct 2024 12:09:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFD8B6B0089; Thu, 17 Oct 2024 12:09:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EB7E6B008A; Thu, 17 Oct 2024 12:09:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7C3EA6B0088 for ; Thu, 17 Oct 2024 12:09:34 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C53861C68F5 for ; Thu, 17 Oct 2024 16:09:21 +0000 (UTC) X-FDA: 82683579006.07.57BBB02 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf16.hostedemail.com (Postfix) with ESMTP id 669B0180011 for ; Thu, 17 Oct 2024 16:09:22 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=s7EPobrd; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729181226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gsU2+hsDP1JpASWksnLZSchRN7kDdrA2+jWf+1Q+v4c=; b=Sw1q33gliuCMREAM3mvfVTnitFJNZvvy1x5PAiJKNYfxAE/m/nI2Nbcv486rT2aLSHh4yK F/09KOHDuk3M6PWAN6E6BwYtscYvXTDMbUXrtYz4zwdHnH02R479cxZLa2RczZnigaGsi7 sIvBdxYOhcVn0FNQBUePBgFyNNyqItY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729181226; a=rsa-sha256; cv=none; b=ST2S0lDhwsNGc+KR6oQ4/4ck7dQlDM259N7sV/AeTIuyXRHAs3eIV3S+1a3T8nCqRJHK0I OaEt6kRRzwd3S1u/XGz1n4iSCytciqg53ZwwaMtJQ1nx7WAu2y7YAUqr7dIZeWwD9gtEgK QJdFJyvN+gRDcnCoceUF15b6vVbFBJk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=s7EPobrd; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 17 Oct 2024 16:09:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729181370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gsU2+hsDP1JpASWksnLZSchRN7kDdrA2+jWf+1Q+v4c=; b=s7EPobrdGTdJjE6vOEu1ImAGAdHmLOxhf62tWT+WGH0YyZaSo7wT8ZEgve2WUzQi0/mqIi AYsSR1KnzbjJ3ctQlIdOoX3w8oj7Fi05sglLqgW2vgc0dcY6GlCPZRp37D1l5malRGnnfP 1zsVPsRLT/PeIsFjknO2y5TBJNC/ge8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Ryan Roberts Cc: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Johannes Weiner , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Michal Hocko , Miroslav Benes , Shakeel Butt , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v1 03/57] mm/memcontrol: Fix seq_buf size to save memory when PAGE_SIZE is large Message-ID: References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-3-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241014105912.3207374-3-ryan.roberts@arm.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: g7d6be59xy9qts3cfcgrzauyn9rwinqh X-Rspamd-Queue-Id: 669B0180011 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729181362-839137 X-HE-Meta: U2FsdGVkX18FPi+2f31XC7CcxS/j62xeyaaQTua2bcT/Tjr0ApuXiZ+9jdWceS548CwLUA2qH0sdAd7AnHvNhnu7HtipYemK906WXpqDPSvD4o6l5o3o2bkX/fKvJMSH3U0osaw5ZBR0uzpaFZURqebsI4lVdTH1u3HDQUK52mFHjmoJJxLXfMLNggd7BBk3PLDxV5HEQJvhpYJcFz2oLToEsigSX0Rmh0yXw3bfL2TWvpPkfDc2GnH33rX9LrOtSfpI7GjghgHMHVFy+ailN4D5M3DxbaFzjr1fuEdRsCdOJ+zxYXpH/qWjC/cBzPEG6viw4nTBLhpXyAHaOlB1vcczBI7ejztdg9YE0sKgrBlKMceTn2fJDFdD8hLp5jr2kVP9Amg0DTHg/7w+kuXfbruQGtcWv/xmgzOK5DpGmK5YzNm6ChtzW2WirciGHOLUy1+v6TyHZ0Ux+Us/Z7wE2+9a5NvAQA5bCvrHqhzdcvUALbe2mstu1a123gl0rN5ucDm7Pvz2M7MpUp4q0oqXlVG1ZGvb1vEqGLV0NOSwZOJr6upvOYXb0kW6H9/XLg+bZR3VrYE7+iE9VCBi57r5Jxj+2DL7rDGWpg9cmxXK0jgA8yh3xv6BCgtCbbqJmGmadfpAPE13k4/DGXcok7VROFu0Zm3GE3qLT3FMD9r4R20ItuHyhzhhWDz6rB4vLh6goaZbPclANFV4zWTP2orRGa6otpp2tHVVu4Ko0vcqsiYHriO72aqOV7hipxhiWZkRo0WE+SM9bg7wusZA8maRN6QPMu5P/HWcyD6tP8+32Im2YwpYUO0vTiaY07tjL/3GSm2cQ/iL6XMD2/KNVeWG8AkAfhkV377TIJD0PQqShBj45QCfC3seozNVnRJIN5GcmTV8y3C5d69kRPDRTuWuo7a+S7KNfG6t3WFA1hVHs6ouW0ZnxZG4uGjYRVrj8c39Gp/SIzXMBCvnyC4WfDh uk5IUlj9 SAnnofDHRI2OHZ2CVQdK0r6q+6WcSCZ4Y9rSr9/k885VVMvNOJCvapCnZQRwVMhrgJx1uLwCg0Q7KAsSZ/gdKlsQpzsNttUjmTVdm4gWHqLBDL8agLFqSaH7Oz+2IpJxp/JTHswM2jc47W+fOP5qI1Jy93pN3faVYx8b8ryk/NOWChZ1YPvGa/UZPyJpTBI8duYHeWSPLKLzuQbOeKVfd6Yw5NlvWQHalnzCm6iX8jyVs7ji7P32sCPPoVNlegd5TnteHxp01AnGSCWnopY42iYKJF50OSbkdPYdq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 11:58:10AM +0100, Ryan Roberts wrote: > Previously the seq_buf used for accumulating the memory.stat output was > sized at PAGE_SIZE. But the amount of output is invariant to PAGE_SIZE; > If 4K is enough on a 4K page system, then it should also be enough on a > 64K page system, so we can save 60K om the static buffer used in > mem_cgroup_print_oom_meminfo(). Let's make it so. > > This also has the beneficial side effect of removing a place in the code > that assumed PAGE_SIZE is a compile-time constant. So this helps our > quest towards supporting boot-time page size selection. > > Signed-off-by: Ryan Roberts Acked-by: Roman Gushchin Thanks!