From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F80E7716C for ; Thu, 5 Dec 2024 15:22:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA5AA6B00F8; Thu, 5 Dec 2024 10:19:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE6366B00C3; Thu, 5 Dec 2024 10:19:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B21836B00DA; Thu, 5 Dec 2024 10:19:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6A9256B0095 for ; Thu, 17 Oct 2024 10:32:20 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 163B6121524 for ; Thu, 17 Oct 2024 14:32:10 +0000 (UTC) X-FDA: 82683334230.18.34F0D97 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf05.hostedemail.com (Postfix) with ESMTP id DDC38100009 for ; Thu, 17 Oct 2024 14:31:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=oPVXLRa4; spf=pass (imf05.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729175463; a=rsa-sha256; cv=none; b=7DzvUYRwP2dyx0RYLedNTC3zUmzO6BLf9AeZZWNNGR5sL25slyT7QMOZn9MZqBH2xMbYW0 Tzfo9O8D7x4slNicnzrHNRcTJqpN+4rc6putNEtNO0Dfs3vJcjv2DM+BHdhH3afB1E/zhc J2NiIkBIZxSgya6bKrMtEELY87iqOEI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=oPVXLRa4; spf=pass (imf05.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729175463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x9M7OqCmvYwJLYp7viWiXrPFfxDnW3xZHfW7zLFJR0w=; b=BXAg5Z8BU0pvFL5dHSlboLLRWsqzSPSiyn9FY1VvTKizlbRD+SGoVgLgE9cX1YW6K08Gm9 ijVnje06Zl0iF4YpkEMCj8eE7JxtGb+mw4xHdP0QjE3G3GoTy1q3SYKSe+Em91e6ldgtA1 tvLSQFvnqkqOJEKpzX1LxmnBYRVi3Po= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49HBnpDp030939; Thu, 17 Oct 2024 14:32:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=x9M7OqCmvYwJLYp7viWiXrPFfxDnW3 xZHfW7zLFJR0w=; b=oPVXLRa46MOc6Sf+5LBNZDM0qkdDCDe2W+Ef2UqLTdqR1R mt1HSka4pBPv67fk3O7RPoDXwiupI6N4Ex7naatzPHyjB+GL/9aW6uBfHEug5GvN ZH6RAyI6rrA7u5ESXRlf5vwelKAC/D+mw4kYd5X5Yzzvf10eDW5zEUuFDHSbpG/0 a59f9iyZn1Xq8L0f851CeK/LHvCRORqZPnr2OMo9Ap6sweb9Ghig8N8TQItzoVsO 47ssd8S4GR87Rgt0oubL3bfNteAlYdBl9EUCY1kORvH1DxLHAQRSvu3xBOuppg38 V1taPJrS9eJx1nwkM6b1f4OjDKAzMk1hgqWA1meg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42asbd3a3y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Oct 2024 14:32:16 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49HERF9H018368; Thu, 17 Oct 2024 14:32:15 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42asbd3a3r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Oct 2024 14:32:15 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49HDr3Bj005377; Thu, 17 Oct 2024 14:32:14 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4285njf5dv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Oct 2024 14:32:14 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49HEWAhP48628210 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Oct 2024 14:32:10 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A8B7B20049; Thu, 17 Oct 2024 14:32:10 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C59BF20040; Thu, 17 Oct 2024 14:32:09 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 17 Oct 2024 14:32:09 +0000 (GMT) Date: Thu, 17 Oct 2024 16:32:08 +0200 From: Alexander Gordeev To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero Subject: Re: [PATCH v2 4/7] s390/physmem_info: query diag500(STORAGE LIMIT) to support QEMU/KVM memory devices Message-ID: References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-5-david@redhat.com> <04d5169f-3289-4aac-abca-90b20ad4e9c9@redhat.com> <1c7ef09e-9ba2-488e-a249-4db3f65e077d@redhat.com> <45de474c-9af3-4d71-959f-6dbc223b432b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45de474c-9af3-4d71-959f-6dbc223b432b@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: cHhgOMeaziZtns-QiP2HmAZDEba7eikD X-Proofpoint-GUID: 2uY6DRZW2AitsKuflnkKSDREZnezK4Ep X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 clxscore=1015 adultscore=0 priorityscore=1501 mlxlogscore=512 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410170100 X-Stat-Signature: 9yt1acezrkkhmac9f73teit88jdx1j4m X-Rspamd-Queue-Id: DDC38100009 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729175518-322322 X-HE-Meta: U2FsdGVkX1/w3oIoS+kS+tJONXEbYk8fVAo4O6hLYk+fySH0fCxb2dtssq0Do9TeSIMPeu9fFEWEPl2H/GwXhQnGWEBUvqnG8GeT5Kxit98Yiq8sLh4yaid5WYVm274qYlMU3uksUfxip+NscvupTvVg+8Cs1J0Csz6GMExyW3w/Ne81r4T5jYksvs+y+6aKSYnzQ7F/X/Zemx2q7419Bqzxk1DVqDBMQlImqL5V484g419SoxWUjSc541iLkTIx9qMW8JIbUHC1ZIGbA83B6APnO1HJf+VDt5yhST9cqUerZOKe1XHubiBAbq1z0PfOX5jF63i+mgUpn1fMmMZVH7gL5DoQFxeA3mOsHLfePhVXvGfauSiyzyQS7XEoFKUULsAe2d86I/P/PhpU8svp5oTXD0V0huVTcqltJGSVdUmYx1RIF6+WM4X8BjqI5fYU/Kalth4Vwg8oZI8W5vv/SUPZVvYx4eg4uftN8ex9ZLRUARXE39ur6rWAVm4O6wuPA8+BEzIECy977ZUlxa48mikU2YRaAoUuWtrIU1gi9AToHl0Nk+GOQwZSDu7pGe7PBNW53jV++2f7BPfpNzuibMwgxbAO2UVzOxmQsB4V+fbxX38rokF7K2tGS3HxO9c7OpDFBlUploOy5zFDouMl8sMpWDh1aM9MsNKH2IEwe2M27TotS6fdizbjSvLsb4/ZtMjl6bgIaTVCOGREqPqWEYtoJWAoL8FU+QvJac1Sow/HueIGzr8ejB+xGRgOEr5qUXo0OiSamCYz+aznit9zcRJO5hCi2ZjujkqWEalOBPcS/IR3MAtSth2KevzRPOiUzOMQpmZwS2En9avPwkoyqEL/ajaBsH+6Nh0Aox1u+Qox6OgXyNM1wA0dfIGCKji3LVOPWf5vAteCgExGXAoKCC7fQDyCMJ2Bs7wDc5CxxtErX78i6k3mAEnXKt1AkuSdI5iAYsYdZDFlMie/Sj9 2E66E4of Un0ZNwFbVWzeOhCLA1I+4juM1MZGEOw6ZhRmiWztyixQpSmqv/nHUvaKZbYiKoIVFK2YefFW3L+IfKMAEdOCMPL/5sLcHyliE73T6q9TsDMrPooQJuVhPUp9xNmQs3nQdNMsEWP9ZRkb5ZguYfP6ioJxeHqZf+eKVH7Li4Sv5/2agiCsloV++9KoaGPUfRxzoOqDzWINhxKFhOV0zJxSMCE5NWMpw3WJRKEWk0MRHJ+3498KdWeMB818hrfu/yzysrYH90wb/dWgxx56XDLlROKcAVzhBu2WSgcGR7VC6rVauKaJsj4Pr9N5gUaPVxS73GXm+/kiQpDe31ADU7njyorTLZCq13+XCCPhboxP3jFuqcbAtKITnemRBJW3zlnuLvazv+Wdbx1Xb/X3nB4IsLQo6hQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 17, 2024 at 02:07:12PM +0200, David Hildenbrand wrote: > On 17.10.24 12:00, David Hildenbrand wrote: > > Well, DIAGNOSE 260 is z/VM only and DIAG 500 is KVM only. So there are > > currently not really any other reasonable ways besides SCLP. > > Correction: Staring at the code again, in detect_physmem_online_ranges() > we will indeed try: > > a) sclp_early_read_storage_info() > b) diag260() So why care to call diag260() in case of DIAGNOSE 500? What about the below? void detect_physmem_online_ranges(unsigned long max_physmem_end) { if (!sclp_early_read_storage_info()) { physmem_info.info_source = MEM_DETECT_SCLP_STOR_INFO; } else if (physmem_info.info_source == MEM_DETECT_DIAG500_STOR_LIMIT) { unsigned long online_end; if (!sclp_early_get_memsize(&online_end)) { physmem_info.info_source = MEM_DETECT_SCLP_READ_INFO; add_physmem_online_range(0, online_end); } } else if (!diag260()) { physmem_info.info_source = MEM_DETECT_DIAG260; } else if (max_physmem_end) { add_physmem_online_range(0, max_physmem_end); } } > But if neither works, we cannot blindly add all that memory, something is > messed up. So we'll fallback to > > c) sclp_early_get_memsize() > > But if none of that works, something is seriously wrong. Ok, thanks for the clarification.