From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D507D3E195 for ; Sat, 19 Oct 2024 01:24:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF80C6B00A2; Fri, 18 Oct 2024 21:24:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA81E6B00A4; Fri, 18 Oct 2024 21:24:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A48B86B00A5; Fri, 18 Oct 2024 21:24:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 86D856B00A2 for ; Fri, 18 Oct 2024 21:24:35 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B901B1204BE for ; Sat, 19 Oct 2024 01:24:23 +0000 (UTC) X-FDA: 82688606364.03.DEBFD84 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf15.hostedemail.com (Postfix) with ESMTP id 8083DA000A for ; Sat, 19 Oct 2024 01:24:21 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=lc+GMeGV; spf=pass (imf15.hostedemail.com: domain of debug@rivosinc.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729300998; a=rsa-sha256; cv=none; b=F3c5/SdwGmlxQbILH87gyPTuk8uTQDL7ZHQDBx8kXY8D+p6qEkbjAR1AY83DH+QWNz8gXF e0eTUbKnFPGY2ykjXatIbOJ6IQ8yTGYDTgMQ8exNbbhj8L7oiLl8LxRkDvffveZwj9LGQo uIss5VVjJwC/AgzU+TTIHJ8Cazc2viE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=lc+GMeGV; spf=pass (imf15.hostedemail.com: domain of debug@rivosinc.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729300998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u9kwzs1TdtVADUdfMGhdcgPMuWpR4rjjZoB45wsX/po=; b=ipHhAXlt3MJjH3e5iXmXBidq/KYP2vjpKwx2z2p/N/D6/AV5OwYnTMxdN5UnTFk35bHv7d YOoPaDnZFfw7jFpKYqI59D3N7sAujhsdmrDpSTl4PUbGRROWB4xnaucOS/J8ZKyUn/9/Sx qZTWd5pCCGIWTtuXJPqMBKHovj40qyA= Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2e30fb8cb07so2089880a91.3 for ; Fri, 18 Oct 2024 18:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1729301072; x=1729905872; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u9kwzs1TdtVADUdfMGhdcgPMuWpR4rjjZoB45wsX/po=; b=lc+GMeGV7JvFQbXzK6CkC3tOrIQYDhdjvRDZOFcouRBc+Sl/ANOiHY6O+NOFF+RKdr zkLe4s6Ffo821xI6XhEchJmiRM76qHyz+cEQaQ4ppCOHsTEaPQEUfwbX4yEKJV3c4gGc X9/4BRWqoSua0SrzEn7Ifw+NzwZ+UktuFJ3BiDGfgVFfCl3rkC8IJhyC7CDfeHHC9Dai CfVCRGWFg4wpzeSpe0MvOAwaZCh0AbwbdE3dmwvywBdliNMe+TUzotB5bUIhOvQ1loHy WYs9Cf4bxM/zCqjBZaQ/B1RNCw/NIwXI6U/4wfFK6y/1fv0HerEz143I67biBlIGyI1/ YNkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729301072; x=1729905872; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u9kwzs1TdtVADUdfMGhdcgPMuWpR4rjjZoB45wsX/po=; b=wz1ehdwwvh9pAcgd3aK4DL2vUNEZ3OVQGERba8PtEEq1l8IUM25Eg/JkONkzI8AJ1n uHUYK/yLIQTbpqXog/0U+fVlVSkSofGwlOvyobq/HErxFc+PtCp2WensXR9ba1Ul7ahg 4izzLjXUG+0VjNyKHN4IMfMjfQMSuQILfVvGFdYuay3XEqLFl5kxdwivnnrpslKAtrUq MG5Mhe+17Ff7xs5vg5nyoNUaZeWxoGhQQN1FcNllMBF0teULMToljltK7AuodOO6AMN+ //TK70ljpLvZ1hIHCbwm32PlDcoK0bilp7P0S3A+5YIxb48o9EBUJExm996NW3CgUYxb t8ow== X-Forwarded-Encrypted: i=1; AJvYcCX6MfLEJHb5RUZAp1e+CIePDzzbiKnth1HTq7COxyxkngm6hyk2x0xzJdN0y5tH0GHoCZRZNqTWRQ==@kvack.org X-Gm-Message-State: AOJu0YwZP0y9ud3PVLLfG7tggbzC/gPutGGLHigHveRmc0zttXxLDPLA /kLf/JhkKNEYAm7/GtVGNkFz7qpfxRC3oHyWW4lWIZee9MUHHXGkS5q29zMczTk= X-Google-Smtp-Source: AGHT+IF5gcz420u+38TzPNJB0kfsdtlqejiS2yRDhUESPcDHjj1maJyg98yMDT7zKslsLy/qQogdfQ== X-Received: by 2002:a17:90a:ab0e:b0:2e0:74c9:ecf1 with SMTP id 98e67ed59e1d1-2e561718d7amr1522614a91.10.1729301071944; Fri, 18 Oct 2024 18:24:31 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e55da7b34fsm2876468a91.54.2024.10.18.18.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 18:24:31 -0700 (PDT) Date: Fri, 18 Oct 2024 18:24:29 -0700 From: Deepak Gupta To: Mark Brown Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Rick Edgecombe Subject: Re: [PATCH RFC/RFT v2 1/2] mm: helper `is_shadow_stack_vma` to check shadow stack vma Message-ID: References: <20241016-shstk_converge-v2-0-c41536eb5c3b@rivosinc.com> <20241016-shstk_converge-v2-1-c41536eb5c3b@rivosinc.com> <2b24849e-3595-414a-b11e-eb03cd3c3b28@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2b24849e-3595-414a-b11e-eb03cd3c3b28@sirena.org.uk> X-Stat-Signature: 7p8nf8pey8sjbzxhhdzur7yucenufn31 X-Rspamd-Queue-Id: 8083DA000A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729301061-867783 X-HE-Meta: U2FsdGVkX18OnqwsTQOj/mZJtMCFumGgTbqMZZJIXhMgy6NiJ29j85qy8SRFR6neCjwcNEMGCOhm18ey8m0/k2JPsIjhPK1TjqQrPsC97yWYOEHGLKfK43ei31cnQIeHiv505yicANBIRAZ6P4MBV4X3dK71MddWRhXTTF4t4lgclb5FzDkUbxEsvMzVgXYJbQGk4RUT0ChvnqBvLuswQvmxsrvlzEZj2jekD2J0uPB+/xo7SPSYD7tjOJgDlGhX2UcbaRux7y6bbxms/YqGP0H01b/NkY/M237sooipGScdYjehwIeSCml0Ef0C0m4JXi7MpniHn5ZJSs9Y9I30Zx1GkXFy1MmNbbg9Q2zLE1D/urJ3mnyqXBedjZVOcWgsnLF7v2BTz1zbFseW8MRlbqLS4KW8VDAb0D/tZAvYVFNSKaqEWqD2zmGB0Tr9n4+ZZaxwJoXZZ5Vl3LQpkVTsWV/0Aq25jzVNg54RyrNIXDfMypW4RqPoueX3UBX38fil3N0Esv7k+xEopu8anP3bGCDpjMrHLa5OoTvViVcxuNInBSrClTFBx+Bqe2DyUZcsqMxHl0Lm5B08vdyq4/wmdB315ZQxri121ap0CLRvpncCNKXouIHq5bUg1uj+h8byGMGkutM+A7/SQaecGODeHikCMYbcj8XfEyZPsz3CFIU0ZL02EpoPzJErk+cFfacDeVVtJtxCHb/f89zT7PfU+6Z5GBNJ6DxXFAYUZ+V1zLavRiR27lIFVXk0s8u5D2pUVo90bjXZpkSFLXJRbpaC/vF/z7LAuVzOfy7aAp7oI/yu172uVSWDKWR79hBhbgMGmhPkwsaCM99Z/r+PByo7v4dvzXlwQyuAdMjMXtDZlLpCQl0vovWKPfhUcwloY32VHumwywNZKnl6cTqSDQjVenr4HFC4CCiyPfSVm3AzjXIUqDOUM8BSc4QUwUrKNWfzc2eeJZORUpo8DG+CHwC q6AoHo9O vXfyyYZkSocIgWo1kRDwjK7cFiOMMs0f3zbJzYs7lxPTWhUBz+a8cczgmb8CKS7cNK8dxeK6Aj2/0cNV6u72EQIpqRZ8d//IxPJ+ykdqE4CSh4U6lgxfkzRrjBm/kW1Tnu0n8FJ8kHV9vFlZujS5JNl0mgyZgAF/eo7felQbw8L/RfOTxMQg9rd6AI1upfdbnC4xXcSucP7q4fu/RX2mdXHwRGTsZOZoYGaGA5OaDoLG0MBGUMmLP99e+ueB53+3qxhpE5bi1zg+nF2uHHILqQFQtKE+nSnNa0zUsm57aTzNEaJxy8aXwlOw+e5FYwSFnYakcAhNlKPducM81nHrADu7j4un4BMXifTuMLMf/htaAZLAMjhBJ+HjYJ8uX29J7tSnB1bIiqhv/zY0fVfnJOuHi9ubewkffNRGKmevG06IkEczhhg4QkSA0RQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 17, 2024 at 12:22:02PM +0100, Mark Brown wrote: >On Wed, Oct 16, 2024 at 02:57:33PM -0700, Deepak Gupta wrote: >> VM_SHADOW_STACK (alias to VM_HIGH_ARCH_5) is used to encode shadow stack >> VMA on three architectures (x86 shadow stack, arm GCS and RISC-V shadow >> stack). In case architecture doesn't implement shadow stack, it's VM_NONE >> Introducing a helper `is_shadow_stack_vma` to determine shadow stack vma >> or not. > >Reviewed-by: Mark Brown > >though > >> @@ -387,7 +392,6 @@ static inline bool is_data_mapping(vm_flags_t flags) >> return (flags & (VM_WRITE | VM_SHARED | VM_STACK)) == VM_WRITE; >> } >> >> - >> static inline void vma_iter_config(struct vma_iterator *vmi, >> unsigned long index, unsigned long last) >> { >> > >Unrelated (but reasonable) whitespace change. Yeah I'll put that in commit message indicating this clean up in next version.