From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD9BD74941 for ; Tue, 29 Oct 2024 22:06:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A6546B0095; Tue, 29 Oct 2024 18:06:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32EC06B0096; Tue, 29 Oct 2024 18:06:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F6966B0099; Tue, 29 Oct 2024 18:06:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0058B6B0095 for ; Tue, 29 Oct 2024 18:06:20 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9A4281407E5 for ; Tue, 29 Oct 2024 22:06:20 +0000 (UTC) X-FDA: 82728023658.11.24D3E91 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf02.hostedemail.com (Postfix) with ESMTP id 2A75380009 for ; Tue, 29 Oct 2024 22:05:30 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=D6mPYY08; dmarc=none; spf=pass (imf02.hostedemail.com: domain of debug@rivosinc.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730239535; a=rsa-sha256; cv=none; b=ST2glJ8NHBboYRZSLHaUBZYIRLjW1mfuTi9+6k4++l0wwBAnZKOQFbCsWT68E828ah7KFE nJk1KTv0JdVRbFZXyPGQGAzPkMRJzke0f6XM7AeCzvHIo0FDZv5yTfttS0+ZdEUra5Z5am YsPrTVoRgK2FvnkkP+9P/E+2qBFU8vw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=D6mPYY08; dmarc=none; spf=pass (imf02.hostedemail.com: domain of debug@rivosinc.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730239535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4EACvvUKKkKxlPkQ/qPPcljk+9uxcKmU+j4zoW5wcX4=; b=RlXlyENL7n1jB8VUBk8pvytdpSpKqhRc8wne82TES2+mEKexuyrbjCcFwX4xuyI8meT4qX /DvNkFUxYSW2w71S52vOcq1mHQOId8tnFtd7fLv2VXtdsf1xzvlxZ8ALT9pry0Ko9J8/h7 XeLk6LTD7unDfp6t5ODk5oPJ6LbawQo= Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-71e8235f0b6so4544921b3a.3 for ; Tue, 29 Oct 2024 15:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1730239577; x=1730844377; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4EACvvUKKkKxlPkQ/qPPcljk+9uxcKmU+j4zoW5wcX4=; b=D6mPYY088l5jmo4zA2tTXQGb3kyDtu6+S+GgxbtxCEgeDg+4IRFHSIHP1xLUioVrYp 73eGGqOUR4TD7emmfnQdy3Cy4ql+6cL5zn3y/NCiyOr0PcR627E2InWccOxSWIBJfYSZ YQtYGElb+0vmObRUdFfW83cM4Ej6xKedKYcyj2KHxXojtVgjFbpE6Sv/gMKFRAy4cZYT Ih/WZk2Pf99Mv/RF/EPpOKzfPMaQsm2vsoLRR4/XogueAEp6FCI/3J2h9sfODFgoBCz7 XRsSoqenTwaFIW+EwaTxnY2cHDIQ+H1tXT3j1yBdBgb1plmQJgOvUTi2RKenKOARccTI q6Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730239577; x=1730844377; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4EACvvUKKkKxlPkQ/qPPcljk+9uxcKmU+j4zoW5wcX4=; b=XrcWINqY11DVDyYjVEItFhZdysvajM7zRBr6MQBLfW3o1TWy5jVXsjmJWeKkaOTeWS ve+Bo4Al2X1vvowTpzcmA9EqNmb/wQzSxE0AgQzczaETcG4YD9h29IcBxd04/UDzFaCd H5uFvBFjN7CX7ZOgdqr18iHg3dDwzxcBurFR87LfwDzBj+/QZuLWeTfRmkFcj8g4/GU9 kiDqchZL7azXY3m13tiUmhQgca++r7J3UY9TzycshL87bXlZceWA5pkdNgtFG8fTXv5B ZpvtRQNCul7dSirRYFSssM4oz0wgjRP7iEY4Kpltfq3SXmkbMOHl7xUwDOPvkM/86Ez8 UDrA== X-Forwarded-Encrypted: i=1; AJvYcCVgRc44UypoWSKD7lyUCWAEsKVjbymEDe+x4Bq8oy+0zBBR71R7L8zotpOjZnepB7klj4W890pwhA==@kvack.org X-Gm-Message-State: AOJu0Yyxb6GFVt/bhzoutWbVaKQC+0JlnIwXT1DQ6tlBU9emWLgWANZp t7QIsNdH/64u5knXclOTTclc+TPdVQPBnTWnR7WXMs+6XyZdD1kW0GT9CdN2Oq4= X-Google-Smtp-Source: AGHT+IGu+eejp1brQK3EJJSUet3qZ/a8s4zNTUr6AdFScB1Xjyv2wQw7qpS7Goqe3NU4f5vJRYVCtw== X-Received: by 2002:a05:6a00:9286:b0:71e:db72:3c87 with SMTP id d2e1a72fcca58-7206306effemr15837533b3a.20.1730239577232; Tue, 29 Oct 2024 15:06:17 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720579397d8sm8135017b3a.86.2024.10.29.15.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 15:06:16 -0700 (PDT) Date: Tue, 29 Oct 2024 15:06:13 -0700 From: Deepak Gupta To: Mark Brown Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, rick.p.edgecombe@intel.com Subject: Re: [PATCH v6 06/33] riscv/Kconfig: enable HAVE_EXIT_THREAD for riscv Message-ID: References: <20241008-v5_user_cfi_series-v6-0-60d9fe073f37@rivosinc.com> <20241008-v5_user_cfi_series-v6-6-60d9fe073f37@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 6p7ucqchfprnyfkekou79jbuqohsf9kh X-Rspamd-Queue-Id: 2A75380009 X-Rspamd-Server: rspam02 X-HE-Tag: 1730239530-487945 X-HE-Meta: U2FsdGVkX19zFHz119RKPumwGM0hgYwzpOF4jPFr4O3pI2fMcb5MsJDxCmNGDFSHHchFm4GJsZniWnsA6uLlKjsWq/7oF2Q8ZIH53+X2snM+Uuv9Dv8E30+M/eMtF4Xq5hECUnOYOApbLQwomxUQ3yrI98Q4lxj1AfIHX81IhQnx2mB5rGPnfQlq9wC+5dzKOFhJOw2lp3FLR493KH2ucklBA8SSGkt7i2tjElA5yxT/zrnR3SHZUBEEojKm06lRPuqcW6XkxJc4+99cRavJXPutky4sQy4YL+9DAX8xPVB7V1MexETu4RUUWDwoqOLfsXwhdEemmAEkQLWUYezF407gP6eOq5BNcmikTVq3h6PSYdmT5Usj72PYKCejagbFaaOFryUs8tdnrjvZhKdb7+hYCZEk2FIR2oBhuFIC3hUzvm4Kev3OO7ez18gtCUChE0YKerWJXFKXCERLw6mlF3hqh39y9pKZQDVv5w25CqCyDizUgBn92mGXxnIXn42FVgEWJjilj5tIDFgC2jCBIwtgwPxihKk3KP2aBxO/Qdd05pNWLM8JeP/pzlut1NQcDh27RkbiXO1goq930U590zrFrlzcsRw7yNDi7KS0bJIbrP28igPbZ2vqpH/l9kdyDe5dOqzPsdSih3O4bs6STUC9MNdJulbsqHw0GPl2KT/hd0G5PAFUDHGIPinlMaivVPGCsKdgCkOked+voG6AqWWtbs3N/37BsOrd7D4aaU+6wVSZCqL5XrK62zSSJihi5KGc4jGBF3VNyvHhPcx05vR2g7wihIu/L7mnUEUwrJIdQl66nQz+Vm8mPKAlwgFbEFl/6njHGlDwL2JtknYe593E0flT8lmjytaIw9ITPngh8GL/61ljrserMnPEVEhAbdy6IUwBKdSw8JcZEVoLaoPX+bsYaMCr++AG2GW5dczsAdqG6qdoZPY4FMTwDYE8v24Ffft3b1rNOtuACjb ximpYjMU m3VBdu3RscWIoKqlZNuoERtmh4sL4B1/VXbaybRHIg9Grdth/G3YEtWOSxHPouF17QQ5c7YfbkqBsSYpV2rXE2+NQfSPEneHq/AijGjHMZbOl2Q6jqxgAn4m7DuNuNm2+BGsMoZ4wMf4BKT+CuWRvPZzW0aAwlpZv3kVrmrKq8X5nlYE4hBvcq4OQfiDdSydsnTBNvfLRjTpohO5mewKb/09TEXMk15i3pxLN4stGASTzUVh7vLGpT8Dk/9ZWiDoaUm2Fi2O92tEDCDSlx0mSPaLCj4Om8NO6aUvtoyivZ3FHvqK8HnCaD74JqALFQJuzFhxjGEjA4/7i5XKMehfWQgCBZ+a6NULM0HEkD2B/LolOUpYi3qEZemeK+b7cXfG8KpINMN2vVSq6cndVlBoIZx88FypghxnA2iNa8KpPOQ2zT/JQRFw5lwwNEEzrWMuDEf7Tzw/Nfhrj86L1K+ahH0YKEqsOlpP9ZIKD9Mhc8V8+Soc6XZnRZWr/vzS6RFmJmebM68K2R8+wzd7QFlwaoE57qw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 09, 2024 at 12:28:03PM +0100, Mark Brown wrote: >On Tue, Oct 08, 2024 at 03:36:48PM -0700, Deepak Gupta wrote: > >> riscv will need an implementation for exit_thread to clean up shadow stack >> when thread exits. If current thread had shadow stack enabled, shadow >> stack is allocated by default for any new thread. > >FWIW both arm64 and x86 do this via deactivate_mm(). ISTR there's some >case where exit_thread() doesn't quite do the right thing but I can't >remember the specifics right now, possibly the vfork() case but ICBW? >In any case like Rick said factoring out the common patterns would be >good, keeping things aligned would support that. Now getting back to collecting feedback and sending another version. Yeah I found what you meant. https://lore.kernel.org/all/20230908203655.543765-1-rick.p.edgecombe@intel.com/#t Seems like an issue for riscv as well. Will fix it. This particular issue screaming out loud for converging flows as well.