From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88066C4338F for ; Fri, 23 Jul 2021 07:11:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2595260E77 for ; Fri, 23 Jul 2021 07:11:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2595260E77 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B86D56B005D; Fri, 23 Jul 2021 03:11:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0F786B006C; Fri, 23 Jul 2021 03:11:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B0266B0070; Fri, 23 Jul 2021 03:11:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id 7DEE96B005D for ; Fri, 23 Jul 2021 03:11:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1B3F820BCA for ; Fri, 23 Jul 2021 07:11:01 +0000 (UTC) X-FDA: 78392980722.14.2B0209B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 97DD9300273D for ; Fri, 23 Jul 2021 07:11:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627024259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yQQEn4AJk4jpfjaQyvDLnuQEm5eCkpcI1tfMEOwcZwY=; b=fd0RmUZYBKkSC2ppUrIAGtVVT0yWS/FZ2gS5l3S84tfOsDiSTUM0cCiDNgTrN+tumTXZad Kcs4nOUTZeGXi9Yp5LhqkXsPBR4aU4IDeO59Zk1Ifd+DuLBQdYxOlcvu4LY6IEFpS2/7rR AVdAnFVOg0Ql0irHH18Qor9XDOd2cqo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-vsNnu2WHMAae7LDoRfVJ4A-1; Fri, 23 Jul 2021 03:10:56 -0400 X-MC-Unique: vsNnu2WHMAae7LDoRfVJ4A-1 Received: by mail-wr1-f71.google.com with SMTP id d14-20020adfe2ce0000b029013a357d7bdcso608723wrj.18 for ; Fri, 23 Jul 2021 00:10:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yQQEn4AJk4jpfjaQyvDLnuQEm5eCkpcI1tfMEOwcZwY=; b=dqcSdm6ztA33zHWbNy4ud61YL1J50qKcmKaG0zHOkc4L5D5ddh2cVmIniBKH8+V0d9 KGWbCOdm2TXcg0eCdIU2ovBh0xWGACTDjhVUntJuXngiBen/YWxRryCz3/CNKrSaO5SG 9vDr3YSfn8N3dntQ1qKjlLwlZxpIwC2BlxTMx8UE/FkYigEbo/KoEGom9xQsM+sJyzto hfOUSSdg24nmDgcveQ+UXwcGJjNM850cjJpqHKu2g+9fpxRldXSPoBpVdg1yDE57CMPp P33Vve4uZWULLss5Y3HUMKJ4DfkhL9E7K8QO+PkYWEGHzw8vwTpJHIBm1DkI6qj35Aee 782A== X-Gm-Message-State: AOAM53259TCwL+OKD56kpYR027IGfpuGn3E7CoJ3CmEcIWHKGcldTTh1 c4AD1mdRu1bh3L096d0rGoWpv46NKQIA8nRfmMDMJynDByUGftDeOVrBkqRNtFklflW5bEaz2wk K+tCl04P+3uI= X-Received: by 2002:a1c:5419:: with SMTP id i25mr3030836wmb.71.1627024255219; Fri, 23 Jul 2021 00:10:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWxbBRVGgAi+ozrhBgrntbx1X/RgUw72RP8WBiXPq3KSVreuWRGEjszp3XAGBZRo8PxJt5BQ== X-Received: by 2002:a1c:5419:: with SMTP id i25mr3030796wmb.71.1627024254780; Fri, 23 Jul 2021 00:10:54 -0700 (PDT) Received: from [192.168.3.132] (p5b0c676e.dip0.t-ipconnect.de. [91.12.103.110]) by smtp.gmail.com with ESMTPSA id 6sm4458632wmi.3.2021.07.23.00.10.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 00:10:54 -0700 (PDT) Subject: Re: [RESEND PATCH v2] mm/sparse: clarify pgdat_to_phys To: Miles Chen , Andrew Morton , Mike Rapoport , Mark Rutland Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com References: <20210723070137.23321-1-miles.chen@mediatek.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Fri, 23 Jul 2021 09:10:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210723070137.23321-1-miles.chen@mediatek.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 97DD9300273D Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fd0RmUZY; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf08.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: 1k7at4955fa8e8gahpxgdukfft17iw4m X-HE-Tag: 1627024260-141486 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.07.21 09:01, Miles Chen wrote: > Clarify pgdat_to_phys() by testing if > pgdat == &contig_page_data when CONFIG_NUMA=n. > > contig_page_data is only available when CONFIG_NUMA=n > so we have to use #ifndef here. > > No functional change intended. > > Comment from Mark [1]: > " > ... and I reckon it'd be clearer and more robust to define > pgdat_to_phys() in the same ifdefs as contig_page_data so > that these, stay in-sync. e.g. have: > > | #ifdef CONFIG_NUMA > | #define pgdat_to_phys(x) virt_to_phys(x) > | #else /* CONFIG_NUMA */ > | > | extern struct pglist_data contig_page_data; > | ... > | #define pgdat_to_phys(x) __pa_symbol(&contig_page_data) > | > | #endif /* CONIFIG_NUMA */ > " > > Comment from Mike [2]: > " > I'm not sure a macro is better than a static inline. > > Maybe we'd want to warn if pgdat passed to pgtat_to_phys() is not > &contig_page_data, e.g something like > > static inline phys_addr_t pgdat_to_phys(struct pglist_data *pgdat) > { > if (!IS_ENABLED(CONFIG_NUMA)) { > if (pgdat == &contig_page_data) > return __pa_symbol(&contig_page_data); > else > pr_warn("Unexpected pglist_data pointer!\n"); > } > > return __pa(pgdat); > } > " > > [1] https://lore.kernel.org/linux-arm-kernel/20210615131902.GB47121@C02TD0UTHF1T.local/ > [2] https://lore.kernel.org/patchwork/patch/1452903/#1650759 > > Cc: Mike Rapoport > Cc: Mark Rutland > Signed-off-by: Miles Chen > > --- > > Change since v1: > Thanks for Mike's comment, check if pgdat == &contig_page_data, > so it is clearer that we only expect contig_page_data when > CONFIG_NUMA=n. > --- > mm/sparse.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 6326cdf36c4f..f73ff3c124c5 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -348,10 +348,11 @@ size_t mem_section_usage_size(void) > static inline phys_addr_t pgdat_to_phys(struct pglist_data *pgdat) > { > #ifndef CONFIG_NUMA > - return __pa_symbol(pgdat); > -#else > + if (pgdat == &contig_page_data) > + return __pa_symbol(&contig_page_data); > + pr_warn("Unexpected pglist_data pointer!\n"); Shouldn't this rather be a VM_BUG_ON()? Because it looks like something that should barely happen and we might not want to perform runtime checks on each and every system? -- Thanks, David / dhildenb