From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A5EC433EF for ; Thu, 9 Jun 2022 10:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA17A6B0093; Thu, 9 Jun 2022 06:24:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C53238D0002; Thu, 9 Jun 2022 06:24:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B19FA6B00A0; Thu, 9 Jun 2022 06:24:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A5C376B0093 for ; Thu, 9 Jun 2022 06:24:06 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 7466780EC8 for ; Thu, 9 Jun 2022 10:24:06 +0000 (UTC) X-FDA: 79558312092.19.3D6972D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id E1A2E40012 for ; Thu, 9 Jun 2022 10:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654770245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6a5SsgsnTuFo9sIZWQwmUlikCgiuGiGF/De3NllGDd0=; b=XVjc1IaW9+h0AT7m4eJPkSiRAZyyJmdHLmZtXiHwgpS4W4hK4GetjQbhDQyQ3EqvlWtYvu FaDh21JIQmGjPprkoeqx3OltqEjMsLPdnEQjDP05ltjMNjHUFeFwAvs9/G8m+X155ksnL0 0c3bNwMdsQx6vWo040Ev6ln87zg/9yk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-0J1OqszWO_2JgRi8JL5W7Q-1; Thu, 09 Jun 2022 06:24:02 -0400 X-MC-Unique: 0J1OqszWO_2JgRi8JL5W7Q-1 Received: by mail-wm1-f70.google.com with SMTP id u12-20020a05600c19cc00b0038ec265155fso15794939wmq.6 for ; Thu, 09 Jun 2022 03:24:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=6a5SsgsnTuFo9sIZWQwmUlikCgiuGiGF/De3NllGDd0=; b=zgF5RzWHTWj+y8gSXiarCCtFQP3822i48AG3338WTHnNENWd88bs7V2kjxbq5dSfsv taFJxoEP3JAKY76hEFqTGdKlOfXdGqAYrElutPdCUeYcU7pJ2kaHTmxACjLWy2YYEhEm CB5/Z8fGCqsln8CucpA9VtSvWYZj6OBWZPrwMeqKErSMl5muXAy1gA62+s1yVmPEiCT6 XeZ3Kmk++ejovW1kD6dYTqTmZ2rrQLHutvgaWYkRK0T5LfvtLkBNEc9Kunish5fn4H0l XcT5tImXfAtpvLepmRYKY/Q0fkZ8npUbjtvE8o8Ba/ia/5j+/u25BCFctPtiSTm8xnYu udVQ== X-Gm-Message-State: AOAM530phbNY9fsCG2bctr1afMXIVNI89oOocAy+fyKtb4y3O7aWA8RA cc568SXfRe2dAFK/hF+no0bHX/Rpw9TzLd/TagYWis3lB932Nhr1HhEWT/Ez3/NQYpoB/OWOm6x qIECx9O5adWs= X-Received: by 2002:a1c:a301:0:b0:392:9bc5:203c with SMTP id m1-20020a1ca301000000b003929bc5203cmr2594387wme.67.1654770241361; Thu, 09 Jun 2022 03:24:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy58rh3fuuccVM2J0IS1QrE1vJ3CH41QyKYHa1IrWm/Rvain2xs2JDw35eE5SOSwtsykjkKLA== X-Received: by 2002:a1c:a301:0:b0:392:9bc5:203c with SMTP id m1-20020a1ca301000000b003929bc5203cmr2594345wme.67.1654770240948; Thu, 09 Jun 2022 03:24:00 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:20af:34be:985b:b6c8? ([2a09:80c0:192:0:20af:34be:985b:b6c8]) by smtp.gmail.com with ESMTPSA id t10-20020a5d460a000000b0021552eebde6sm17782568wrq.32.2022.06.09.03.23.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 03:23:59 -0700 (PDT) Message-ID: Date: Thu, 9 Jun 2022 12:23:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 02/19] mm: Convert all PageMovable users to movable_operations To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, virtualization@lists.linux-foundation.org References: <20220608150249.3033815-1-willy@infradead.org> <20220608150249.3033815-3-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220608150249.3033815-3-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654770246; a=rsa-sha256; cv=none; b=StynRTq5mAkH9JIWW7Z//r8iatcc2HwlblLtSoMB34vVMe5nEONlPInqNxQ2mSg4Sc6XjB NvFSRtQRQN1ThijfvmaAagieN6j0LyNfVN5rPZAvKA8WAI9jEm7t6sOfWTbshhYMB5BotL Lxe+WXWhO3c0d0b4d4Ux4RZHT0X/uAE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XVjc1IaW; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf17.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654770246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6a5SsgsnTuFo9sIZWQwmUlikCgiuGiGF/De3NllGDd0=; b=cGUBWbAzFa1zYJicIEEoD58YlTPXQExBC/8Q+1aLruDTz8JWJ79duX4hU4iCTawVHd5OLa QZrh+6Bmel5BiilOnEXjNWtnIxSwbEMvgU4zUiIyfpu4Y9J3SGZOX1k1CEBHvJK0O8x6Ah mQ0VgYlFiuMh6imLqrMFlCyi8n5AvIU= X-Stat-Signature: 1dhrta4kouipk41s6jb81kgriwitku1u X-Rspam-User: X-Rspamd-Queue-Id: E1A2E40012 X-Rspamd-Server: rspam07 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XVjc1IaW; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf17.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1654770245-865087 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > These drivers are rather uncomfortably hammered into the > address_space_operations hole. They aren't filesystems and don't behave > like filesystems. They just need their own movable_operations structure, > which we can point to directly from page->mapping. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > arch/powerpc/platforms/pseries/cmm.c | 60 +--------------- > drivers/misc/vmw_balloon.c | 61 +--------------- > drivers/virtio/virtio_balloon.c | 47 +----------- > include/linux/balloon_compaction.h | 6 +- > include/linux/fs.h | 2 - > include/linux/migrate.h | 26 +++++-- > include/linux/page-flags.h | 2 +- > include/uapi/linux/magic.h | 4 -- > mm/balloon_compaction.c | 10 ++- > mm/compaction.c | 29 ++++---- > mm/migrate.c | 24 +++---- > mm/util.c | 4 +- > mm/z3fold.c | 82 +++------------------ > mm/zsmalloc.c | 102 ++++++--------------------- > 14 files changed, 94 insertions(+), 365 deletions(-) You probably should have cc'ed the relevant maintainers (including me :P ). For everything except z3fold.c and zsmalloc.c, Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb