linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests/mm: Deduplicate default page size test results in thuge-gen
@ 2025-05-15  9:36 Mark Brown
  2025-05-15  9:44 ` Dev Jain
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2025-05-15  9:36 UTC (permalink / raw)
  To: Andrew Morton, Shuah Khan
  Cc: linux-mm, linux-kselftest, linux-kernel, Mark Brown

The thuge-gen test program runs mmap() and shmget() tests for both every
available page size and the default page size, resulting in two tests for
the default size. These tests are distinct since the flags in the default
case do not specify an explicit size, add the flags to the test name that
is logged to deduplicate.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 tools/testing/selftests/mm/thuge-gen.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c
index cd5174d735be..a41bc1234b37 100644
--- a/tools/testing/selftests/mm/thuge-gen.c
+++ b/tools/testing/selftests/mm/thuge-gen.c
@@ -127,7 +127,7 @@ void test_mmap(unsigned long size, unsigned flags)
 
 	show(size);
 	ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
-			 "%s mmap %lu\n", __func__, size);
+			 "%s mmap %lu %x\n", __func__, size, flags);
 
 	if (munmap(map, size * NUM_PAGES))
 		ksft_exit_fail_msg("%s: unmap %s\n", __func__, strerror(errno));
@@ -165,7 +165,7 @@ void test_shmget(unsigned long size, unsigned flags)
 
 	show(size);
 	ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
-			 "%s: mmap %lu\n", __func__, size);
+			 "%s: mmap %lu %x\n", __func__, size, flags);
 	if (shmdt(map))
 		ksft_exit_fail_msg("%s: shmdt: %s\n", __func__, strerror(errno));
 }

---
base-commit: 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3
change-id: 20250514-selfests-mm-thuge-gen-dup-7e1c40716091

Best regards,
-- 
Mark Brown <broonie@kernel.org>



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftests/mm: Deduplicate default page size test results in thuge-gen
  2025-05-15  9:36 [PATCH] selftests/mm: Deduplicate default page size test results in thuge-gen Mark Brown
@ 2025-05-15  9:44 ` Dev Jain
  0 siblings, 0 replies; 2+ messages in thread
From: Dev Jain @ 2025-05-15  9:44 UTC (permalink / raw)
  To: Mark Brown, Andrew Morton, Shuah Khan
  Cc: linux-mm, linux-kselftest, linux-kernel



On 15/05/25 3:06 pm, Mark Brown wrote:
> The thuge-gen test program runs mmap() and shmget() tests for both every
> available page size and the default page size, resulting in two tests for
> the default size. These tests are distinct since the flags in the default
> case do not specify an explicit size, add the flags to the test name that
> is logged to deduplicate.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Acked-by: Dev Jain <dev.jain@arm.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-05-15  9:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-15  9:36 [PATCH] selftests/mm: Deduplicate default page size test results in thuge-gen Mark Brown
2025-05-15  9:44 ` Dev Jain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).