From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAC9BEE4993 for ; Tue, 22 Aug 2023 17:15:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CF78280050; Tue, 22 Aug 2023 13:15:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 358C0280046; Tue, 22 Aug 2023 13:15:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D2E5280050; Tue, 22 Aug 2023 13:15:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 08F3B280046 for ; Tue, 22 Aug 2023 13:15:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CF4A5160406 for ; Tue, 22 Aug 2023 17:15:02 +0000 (UTC) X-FDA: 81152390844.05.1359280 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 798424001C for ; Tue, 22 Aug 2023 17:15:00 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aXICV+gv; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692724500; a=rsa-sha256; cv=none; b=M98kabKiLOCO9tPrj0vJi9136Vsbn2aI5nJJ6+Nu2QWu9pkvyEBlEwWtxdLVRMX0ClUp5w Axy+So1N+tokZmT+9dXEIMzdMQY6JbTM3Y+4j5MpuJSrQJELlsF2cqDaWynr+a3OS7cq4L x5GavAqg48ERuGvY/RtwjRB5rwVNtuU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aXICV+gv; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692724500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WVwfq44EfyjOUMF9Cqrif+Xnw1bx5Ni+IbYDS3wJpQk=; b=KHuz5Yxcs7H5s5DlyuogiG/tkhA3djpBM/tWWdnDX1AD7AUuZsZvn8jBE6b83kA+4lfKT0 Aqihdu0OuVIWudUifspAWj66uYcqhGc95N2n5nqiLixeuSHKA/dI8HOsxkreL2a/1UgFUu j+P8ptLpDpAFGmICTCzXEz/HjcZUEbI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692724499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WVwfq44EfyjOUMF9Cqrif+Xnw1bx5Ni+IbYDS3wJpQk=; b=aXICV+gvciFZyxPKonFBK6oxly1A44qwOKR4HfZFJbdJcBFEGgLVGjAafAtdoNfs1f5pvg /Yl9llSl5qw0qujhJxWHZMFYYt82/kao2p0tU3Svwx0Qw3e1ZEwCSkSwceF2+K/dNwHtTB wIp4/rzuxt7c0eZuAvETZwen1EdhwCs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-DzBhPLvNMWqxZZMauG3Apw-1; Tue, 22 Aug 2023 13:14:58 -0400 X-MC-Unique: DzBhPLvNMWqxZZMauG3Apw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fe2a5ced6dso30175195e9.2 for ; Tue, 22 Aug 2023 10:14:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692724497; x=1693329297; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WVwfq44EfyjOUMF9Cqrif+Xnw1bx5Ni+IbYDS3wJpQk=; b=SxCeisFn8CF2jGXwlrA7R/6F68AKx8asjJ3tcOejGr2Eyt4gkNXPVFf4i2U6qVyuD9 p1F2Rk4x1yJHNlddO4n2KyVVI0WirImQyfXMcGH5rxJxph0DPQe4kkIZUnMUM09zlrbO FiXE0sUsTAZ0BNZOpnZpu6pN4gVj9Cx3wre1NTT1NbwcQJx48Z8wr219WnKkmyX8Z4PN mtidhVxdTlhpc9ybMnRGgyGd6HWn1klc5Cyu3secYLmy4H5IDpMrlED3RpWPdyhxmn4J 5gqdD6b6JX6NaCYtNhxNeQewG0WwXUCvJgU0oS9aH5T1sON9YETxGJvgMR2xMgdM7arC UXWw== X-Gm-Message-State: AOJu0YzXqz6zgJ4XKwwS5W4qiym1CP4YMZsocZbs5HNiQWHarDDkXATU /mb0E9j7QyFsZ+c8U5e8nEL+UqNlws7ifeLszSzL0uuU9WVu9DfTdR+PmsCahWbwI6ZAEw4f/a5 r/nw0lx9vT1M= X-Received: by 2002:a05:600c:21d7:b0:3fb:adc0:609b with SMTP id x23-20020a05600c21d700b003fbadc0609bmr8272110wmj.13.1692724497284; Tue, 22 Aug 2023 10:14:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH23bPSS+vVpGjWOU/XLeF3o8YSRaJk61qT7CmrK10eD+OTjKTmDNWRtt1BojDn7JN7UWCgIw== X-Received: by 2002:a05:600c:21d7:b0:3fb:adc0:609b with SMTP id x23-20020a05600c21d700b003fbadc0609bmr8272094wmj.13.1692724496901; Tue, 22 Aug 2023 10:14:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:7400:83da:ebad:ba7f:c97c? (p200300cbc706740083daebadba7fc97c.dip0.t-ipconnect.de. [2003:cb:c706:7400:83da:ebad:ba7f:c97c]) by smtp.gmail.com with ESMTPSA id q1-20020a1cf301000000b003feea62440bsm9821557wmq.43.2023.08.22.10.14.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Aug 2023 10:14:56 -0700 (PDT) Message-ID: Date: Tue, 22 Aug 2023 19:14:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH mm-unstable v1 1/4] mm/swap: stop using page->private on tail pages for THP_SWAP To: Yosry Ahmed Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Andrew Morton , Matthew Wilcox , Peter Xu , Catalin Marinas , Will Deacon , Hugh Dickins , Seth Jennings , Dan Streetman , Vitaly Wool References: <20230821160849.531668-1-david@redhat.com> <20230821160849.531668-2-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 798424001C X-Stat-Signature: 8m8bq65fc4883766ewtkbg35k8x5imd7 X-Rspam-User: X-HE-Tag: 1692724500-960457 X-HE-Meta: U2FsdGVkX1+aSV/+WsNsLGOkGW+wTfY0LN09yH0fUrMmT9LgRpVXrJNnPSUUymdqZdLkzgT33koIhZGPuuIspEssknCwOXS+zlB0WCDNpc9RvX3uD6mdwA24aS4bsiOl3IcNvntmOE+wN368Tpis/NEYbeP9BL+hBfFijmObf2DdUcZdIRbPdaMQoFzdmhO8c1cGCml4C5IfTj6BpLHs871n55ftHSZRtmLtIEW1ktxkTz5vBlGNivjNL1I7ZjFEVB9nbN56YvYnjFxAdFginySZyn3/rSsvLR2jDikEIzp2tncp1iJ+npGSRvwHzrpBdtPuMuSQSYa06mveD4butVq3iSMnUMmIt5m6OYqV6ATtHkWPWIEtTbW3N1ikcc1roxJpAYD0ll3MBlNX5mKrSNXm+BLF2mMMoSmbJS2cMxEbP5VnjtiOzPBtxVM0G5z9yHgypFPb8lpp4MYtqRvuGg40qaGBCrjakbpLu7Bnp9Q+wR43yMDjs/aTMaLQaYkFYl6f1WCOOkyN+iuI1/Eyidud2eJxaXXx8/NdZaaqMkOuqpCyrj2KZ1YSozo/lu/rVs9X1GAUcW3pgZuX67dXnllSmUPkcdstuhV6qwpMkbZYFrinGC3eDZpH6KL/X/gR8mBMOzA6qlObqzBbozHo3yn6BoDsGDoumDGacOzGfKAP6a/12aaweHShyDiTDvjNGUGia7pVd4phJrsW4PrYwhFr5icCWjkB+OfiZbNH0YpDzQ1R+CpWGcH/au6C6YxoKkWH9bpDBDEVn9g58TC9wgNvu8ddOhb/XCexfE/aC6Fx47AidjgXAOeRW+rWQtXqa2UVHMjG94zK70oa/oxmhvrpoZ1Exb1Ta06RrBDaNtvYk4HwV9ouwm/RRff1Ul/Cut5GvAumGFLmQF6l62O9TgM77rxxmDwgc0kaiV+bhmjyMSHTT9hnRgraL94LVysQI2CR/4cjhxMkSCDIBXB qy1laVOU jhF8VcGa5qo0bx2E2ss2pAZdlkg7C2Bwr66cw6CXdONPYFZyo/qVWk/gdqwIB31VRgNZf+NvbZsdqEbLrmIhaMIOC+9xj5JbvH2IP80xp5kTlT8zFwN3iF5Sya70OC1XWPhUp8Bkk8iT6M4OaKQ4qj4ch/rtdpt/+jwVsDQr1xJZQ9UVCJs09iy1wbxDwxXZXclK+3ezbSujYogmEXBHvke4UQcRui42eZ+8QcYxK7WH0e6yWMtg/1rWzpvTF2RpNPPCL8XgtXqr92wJqMeKaAsgA6FpNN810Ftgqto5bFYP6axMO9iG0bGt/1POBZRd98LfsiHIDkhf+bEYbf41/gaO2xrLyfEDlQC3OGHAygdgv9xyQVxbEBnDzuywhxRnkt8lcCanYAc7aDX3bEcTx9pcprhHZCaXQgFB7Ijc8sIjWlxcryHVH8pruVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> >> +static inline swp_entry_t page_swap_entry(struct page *page) >> +{ >> + struct folio *folio = page_folio(page); >> + swp_entry_t entry = folio_swap_entry(folio); >> + >> + entry.val += page - &folio->page; > > Would it be better to use folio_page_idx() here? Sounds reasonable! -- Cheers, David / dhildenb