From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA9BC021B8 for ; Tue, 25 Feb 2025 16:45:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1870128000C; Tue, 25 Feb 2025 11:45:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 137A928000B; Tue, 25 Feb 2025 11:45:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECB5228000C; Tue, 25 Feb 2025 11:45:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CF3D128000B for ; Tue, 25 Feb 2025 11:45:06 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5848FC1C07 for ; Tue, 25 Feb 2025 16:45:06 +0000 (UTC) X-FDA: 83159041812.05.9B6C022 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id BCF20120019 for ; Tue, 25 Feb 2025 16:45:03 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dAyOefY1; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740501904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zgtMS7lnc2iJ8NZz5qc7ro7UVfbncD2D53CMQ2PQPfk=; b=7IiJhgJezjJVeY0K2EYn9CYLuk5UzWqVd6MogH4NMlnxi2r8/VSkb0XK1PRd2bjgNefF0e HSdAGGLVbMHfCOKTaxgDsMs7B4pcgWtAM0CJci23Um1tUIlf924RtoFwWQfJ8kjk/DxUnp EA6izHyfGqxCll/NpOjnPBmLH1Z9hRg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dAyOefY1; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740501904; a=rsa-sha256; cv=none; b=TdGTKhKuO6hZjhQUvP/FoK715UY+qeiVCq4HgsIvCBV+z2EfYGSjhciHXqU2JBIPzsGh1v 7y3FGWV6vluxRYzQOn5iaxFFji3dDM7CYECNFaw2F2gmhLjFYvcjPKcxO5kJtsIgo1ywuB DBLQHVqdYvHyiBx1PwzaEmzuylSS9KA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740501903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zgtMS7lnc2iJ8NZz5qc7ro7UVfbncD2D53CMQ2PQPfk=; b=dAyOefY14Ybb8MTo7hHUZ3BFsSlsj1btjH7p11qW6WvUuQpdd6Sg3DjmzUFgHKTCdWEgiy edtx+G486P6eLR+G4u10lOxSPxyWtuGklz5+56dvmZYrrNiEVrrxZmd9mTwSVyk6O2BAiQ SrPLLVK8lDiLNIoYRwc0SctowEbs4v4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-SDEqAmH4PWCd5cX8IHlIOA-1; Tue, 25 Feb 2025 11:45:01 -0500 X-MC-Unique: SDEqAmH4PWCd5cX8IHlIOA-1 X-Mimecast-MFC-AGG-ID: SDEqAmH4PWCd5cX8IHlIOA_1740501901 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38f628ff78eso3124662f8f.1 for ; Tue, 25 Feb 2025 08:45:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740501900; x=1741106700; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zgtMS7lnc2iJ8NZz5qc7ro7UVfbncD2D53CMQ2PQPfk=; b=nxSl/wXHDxG/G/4o2zh7p71c2EEAigosWv3BVBzChMu8M6mZS7g9PDuf6n42pSpQM3 nlZbOhH3zuFco+yMpTezHXuUglPK6mJ2RuXyt2Hjrs2JMCL+Nxfn97PIBpE+sVESb2Jw 3hjPLV6OryvvPICKV7BLYsDnLX+p60ikUWhuXZzjyT9eXylFKWX+5X9CFmbFKzYHKJFK ZBGgaGftYQf1mhXMV2g9V91SheAL6SAMDn0V2sc/Aksf0cfmnRNuVkzo7UZ1OBH3xMHe JjG87U0OFcGI82H3ZHasD+lzjFco2/qBjq5nMzcyXeO5gdKHctDHy7rzEG4ZMruZVEHQ 8O0w== X-Forwarded-Encrypted: i=1; AJvYcCVyE9/4w720oV0kjFUQ/wSh51jEDRfUtTM2l8wHcLbFKNU0rDK6axT5NiVDuOogp4lfkIg27ZInfg==@kvack.org X-Gm-Message-State: AOJu0YyIH/3hu82ASywYyEaA1DjMqj3dH52c/y6/iM4ueKtqxxEDAjFI 41hidaxAzg06RXHZ3ZvHaKVu2CQrUlScTG8rQPRUUUPvjQ5FCh3hXUjgDTQginCf2P6LOKg6F+M JaNMqwd9UfpuRf7HTQk3TllWY51KZUXMhSOcpZ8+4zKk5spgT X-Gm-Gg: ASbGncsT00HgfaOMs0vdmPstGvIjwoGuC4Dik5I3ZP31nOzeFWA52xrvNKjVkX6Pezn Jw1t2sz2j6Cx2IMqKt6f4aYsoR2f2YJGUYSCNfAIj2xXQKROgUTCJZzRvnxTQkVJUlSDGpagfFW oYezup9v1QCWZhyV4K545d4G5XE9Q1C/fXL0Vykb8HqCGAWqBb0dV3QDeJIYMFcP69uDguul7Jt BWGl9RuHnAGh9HukJxH90ybX5ucRKwkn8jUemsT9ji4CTEh+EB119Gz7wijJVhAV+hdbd3OMF4p 3zhzZT6ZHIp+PHUhlz885RNw6yOqbq2IiBv2CKfszyQUGigyAQcV92VWRESoexv3K9Dmyx2TalQ 6x0DJToHbxHJJPzB10gFUPPDolFkv6XoAxIaHVd74dW8= X-Received: by 2002:a5d:47cf:0:b0:38d:fede:54f8 with SMTP id ffacd0b85a97d-38f6f3dc975mr13459207f8f.16.1740501900577; Tue, 25 Feb 2025 08:45:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFH/ppmqPuHv9x4JWuJwDh8X2zE6J0Qu0E5QL3bigRQ34cHTtjW/smUzdS4y56n8NeYTmt+rA== X-Received: by 2002:a5d:47cf:0:b0:38d:fede:54f8 with SMTP id ffacd0b85a97d-38f6f3dc975mr13459183f8f.16.1740501900262; Tue, 25 Feb 2025 08:45:00 -0800 (PST) Received: from ?IPV6:2003:cb:c73e:aa00:c9db:441d:a65e:6999? (p200300cbc73eaa00c9db441da65e6999.dip0.t-ipconnect.de. [2003:cb:c73e:aa00:c9db:441d:a65e:6999]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390cd86d1d5sm2894726f8f.39.2025.02.25.08.44.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2025 08:44:59 -0800 (PST) Message-ID: Date: Tue, 25 Feb 2025 17:44:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] mm: page_owner: use new iteration API To: Luiz Capitulino , linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhao@google.com, pasha.tatashin@soleen.com Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, muchun.song@linux.dev References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: X0Qnll1ho2YJpq06uYlhkqcvszFseOOR7ExD0HSTWfw_1740501901 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BCF20120019 X-Stat-Signature: 7zmj3ewx5j7mkf8nyqehmcenf9k9jn11 X-HE-Tag: 1740501903-955399 X-HE-Meta: U2FsdGVkX1+InGg4ZDyeKA1t5Tdsf6ZUOLthbcnKSfT7wuHQrSNel2uDZh7v4aUWBWR8mcuwCtZvxg7pVMYRGCr7ib9GnqxyuaPelTyZ70m1SRTny/XW31itz2oN4IDBvgKrmmp3tJwD4/oOS6Ywekw6FcxDoqM0H66URX9TEUWZ2xAKroHrWe5JqP4/2Pk2aaP4P5j/mcGVo4sFzU8kjZjLH11OHdA5iju+S6XUhI8NxEAOn361LApO4qB4q/mSah/NRmcr7xMiS2TbNcPW115Tum9gw1C7H4hhCcmP8HKioivi8fWZCS5vdwUiCaDlvBBIb9jm0Ql2T853oEas6REz8uV8M8K1JwBoI9srfkkmiDAx5GD4LoxAxAUq7H8vb5y06BVkjJVZd+CUU928wsHrTlqy6llZfQ6l0OrQ3ff7l/9/NYX639cO4+hx3Wd0TfUUTCgplvlOxscFdnnEGlvf9xm+442RiIWDpNuMl8FvMRCTZ2Uu2KvTwcFS7Dbmvms13l4M6T6SGbK5TaQf/7KE8PqsKo1Z1nItWdExf0EaPYA5xkRn0f49Utd4TNR7T1rya+GYRVRUdHet+NGO1sKQw933atis0ILb/x5qurMQ1YbqDVZWnDe+jmpw6BDp+F7a2oYtNlO3YAqVLZR1UsiJbKmFwa8//9R5ZZT4scSiUN39ARdul2lBPEOjYE2d75mtKQxt/oW3gPd+0BB1BZNIF2wu/jZEWfLXxELTSWGMOLp24tEu+GsLbJE93mOFpeYPSmIYoRSOABxyEIvP4iqVuW+TqROpntV4Uw5pYY6byZ+AQiTU7vn3cu435FqCSSE4bAsOWZBpt/22w1AfX4jhK+RCqpMk6nKszrnQBgewJca/ZSiYr9YmPNdkcYpjNFiisXSvy2IKQ9i+HpjdERDT7Kx0Vtkpwi9mXYFpkQ5g21L+qq/SuPeR3TPOWmkGiRHfFQlbuJdkETY0rYt aqoXiqOo nbZRrFFB6tn0PfMtgymYvkz0upNj5dQ6mm2LBM9WcgBcykmdgSxKV8FaOLY5r2iFmN/zG6z1wOx0+3bEW9hjXytCCTrQue8Lte7rHmOHA4a21mFiBaq71gi6Y5kc+Rsc2G0xUNGjUYgmNBHri2rEVhL6PtgZ/lbW8kxuujppHcq6IAJ4VqSzzZt4wWVPCn9suwrcDerIuBlKYTFx0cY0Ex64u6RNVjwhwwufBt/bOtMwJc1dwvGBXhZpJKiLiBLXMEn2I05eDAx4tkn1tQ1hmKKK9LldrVbfI+OznNh5vKWVlSLGxcbAF1cEzodEslupAyhy3Bxg9nr2KZz19FeOl7aKP9KiZ6r4HU91fB4C8l4/qwOd+YemnQGavEkHUBrFPYNnLZ1yQO3Lr7SG468r7Om0ZlxSSj7MnKxU5C5hGMnrFja1LyOGo1Trt2BjxuM1FNhKWGa96t9LifgFBS6lJqHCRu5WteraCUMMBP2EMXAlGJaIVvqBvb5pBSyJ/ZD0tiTBKd++Wp+EkSomKoAm735CzyRKCeftZYO7QrOtCFy0iKg+I5k5KH1ilDsvpojfhNBOVbjjAundeo9c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.02.25 22:59, Luiz Capitulino wrote: > The page_ext_next() function assumes that page extension objects for a > page order allocation always reside in the same memory section, which > may not be true and could lead to crashes. Use the new page_ext > iteration API instead. > > Fixes: cf54f310d0d3 ("mm/hugetlb: use __GFP_COMP for gigantic folios") > Signed-off-by: Luiz Capitulino > --- > mm/page_owner.c | 61 +++++++++++++++++++++++-------------------------- > 1 file changed, 29 insertions(+), 32 deletions(-) > [...] > void __reset_page_owner(struct page *page, unsigned short order) > @@ -293,11 +297,11 @@ void __reset_page_owner(struct page *page, unsigned short order) > > page_owner = get_page_owner(page_ext); > alloc_handle = page_owner->handle; > + page_ext_put(page_ext); > > handle = save_stack(GFP_NOWAIT | __GFP_NOWARN); > - __update_page_owner_free_handle(page_ext, handle, order, current->pid, > + __update_page_owner_free_handle(page, handle, order, current->pid, > current->tgid, free_ts_nsec); > - page_ext_put(page_ext); I assume moving that is fine ... but I'll not that ... > - for (i = 0; i < (1 << new_page_owner->order); i++) { > + rcu_read_lock(); > + for_each_page_ext(&old->page, 1 << new_page_owner->order, page_ext, iter) { > + old_page_owner = get_page_owner(page_ext); > old_page_owner->handle = migrate_handle; > - old_ext = page_ext_next(old_ext); > - old_page_owner = get_page_owner(old_ext); > } > + rcu_read_unlock(); > > page_ext_put(new_ext); > page_ext_put(old_ext); ... here you are not moving it? In general, LGTM, only the remaining page_ext_put() are a bit confusing. -- Cheers, David / dhildenb