From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4BCC47258 for ; Wed, 31 Jan 2024 11:07:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 113566B0096; Wed, 31 Jan 2024 06:07:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C34C6B0099; Wed, 31 Jan 2024 06:07:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7ED36B009A; Wed, 31 Jan 2024 06:07:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D32DC6B0096 for ; Wed, 31 Jan 2024 06:07:08 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7A2CD80C91 for ; Wed, 31 Jan 2024 11:07:08 +0000 (UTC) X-FDA: 81739329336.08.F8A1582 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 27CAE100006 for ; Wed, 31 Jan 2024 11:07:05 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TD/FNxOR"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706699226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EPrRA4G16rNph0HwrpyFZd0WmfVM9XjFuWwPmxCMxPs=; b=x0Gie5W8xGkp/bG7RplJe69JwbsZw8Vu9QcncQJpy1teHPy+XyAMQWPD6CAgxWx29B7KG2 yKE5RBeDzxHGyxkXYMx12WpITn/HANKaaWc5fAt3KB3is97nJEgR8+95kQgnwFDPsPSnJr wnQhuD+tUfp8ckwTUnuWo9thiKQrz1s= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TD/FNxOR"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706699226; a=rsa-sha256; cv=none; b=uCJGXIOl6VjWelR18pSzhduoKB0ufNbdbo9b1GgfCxfaqszUKfYBnlLmKc2lffUPp2qMSn N94LQw2+QpTrl8jjx9pKP+3x/aQ163F3m1428q5NuREl1MrFo20ExL4Ma4OfhBCkrqYMPf US5QChfWB447bGEjdN6eY8W/VWxrbHY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706699225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EPrRA4G16rNph0HwrpyFZd0WmfVM9XjFuWwPmxCMxPs=; b=TD/FNxORQHbDyEVbyrtLj2KmRDFk+/DR6k1C9ZoaTyULeO31qA4zcX8BJKWeaydPZuugGK 7k4nUslBpFju71CyMZ0AoZ4worpyqvxgWpZuDX/ixWOdlgkfSa8HVzGDdDN7SU9GP2BluY jeBV5zoxloLVdLV9mQ0nid0kuTL2Kbs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-nxOaiPNTMcSV2qokNBoTFw-1; Wed, 31 Jan 2024 06:07:02 -0500 X-MC-Unique: nxOaiPNTMcSV2qokNBoTFw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33ae7482b2dso1581978f8f.0 for ; Wed, 31 Jan 2024 03:07:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706699221; x=1707304021; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EPrRA4G16rNph0HwrpyFZd0WmfVM9XjFuWwPmxCMxPs=; b=JEyfTD+sHlGaQyZEAO4mSOzwo0r4GmDRaMWYIT9KBnykZS5eybQJy7VKOsZxlldEAe ETAGwZjV5/os7gaYYS5R8wLBHUC07/iNi7EHUHV4GcsUci8Z48NvhnJXiRqdmZqMAkyD 175MVjAL+Sp08kTgZKUW5YRHEaivP0PSJ7UWHZRRYJSpCn1VPaOK4hvoPvFKAkSMtlze FHf+G3rQZsZVS1G6NEotuZOe0nOVSvMBTCSJaOgCaAiwnILfUQl+DMhwUrcj+y2ra2Ht lG7LhWTG6v8bdxL++sUpdtqp0JPtoPWrL5GQwFluUp8xyTG3s9yWYujU2+s27Cw62FpR AAVQ== X-Gm-Message-State: AOJu0YxQ8IKG8RI9EceHueOIZh/OqaQtAj9yOlqgb5Pdq+8e6SFoZZ5C HZ/YP2hoEh3Uh983unCz8bod7qNiV3H1X1XZWksGcaqDOFudiOQ568Nl8Ppcv35P3/oxzIMwfHf 5tjDb7Qgc7gX1Tkn1yzOmqHTyn623gqL7QYMICFloVVYiKL4b X-Received: by 2002:adf:cd0b:0:b0:336:6377:6e3d with SMTP id w11-20020adfcd0b000000b0033663776e3dmr731881wrm.66.1706699221613; Wed, 31 Jan 2024 03:07:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IFA/lbkXBUTF2Q1hwLU6vcNIzd8zfJwdZPFVoQqQvBcWoL3J9lF0IZkIJXh4wwNAzmG9wj1/Q== X-Received: by 2002:adf:cd0b:0:b0:336:6377:6e3d with SMTP id w11-20020adfcd0b000000b0033663776e3dmr731857wrm.66.1706699221183; Wed, 31 Jan 2024 03:07:01 -0800 (PST) Received: from [10.32.64.237] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id fo4-20020a056000290400b0033af3294417sm6643931wrb.21.2024.01.31.03.06.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jan 2024 03:07:00 -0800 (PST) Message-ID: Date: Wed, 31 Jan 2024 12:06:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 00/15] mm/memory: optimize fork() with PTE-mapped THP To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org References: <20240129124649.189745-1-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 27CAE100006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: czkxkxieisj4deydizd84myzc3iu4gk5 X-HE-Tag: 1706699225-203051 X-HE-Meta: U2FsdGVkX1+GNxK95RhgYZ67lsoO9PJR5ecwU2x8q7sko8NZK5X1IVz8DIe/la0lyyu7UZCR/RbzXJFnj/VdG6Ww2wdeKqjWe3LcQuX/ggnrJiTEO7Tm7jZlbS0WJyRCUUCHsY/7eloFG7xIGKWCwTfXfRqgWgkZ+2qmjxDpsc/sza1wEaeUm9/sp2fPG9Of5FRSwt8k4z58ciz1aFlsRvAElwjgJRcCOK57niGst9ziOEq4RWC68REA1NW06XOICiwQ7xbQ7qKfFjq0jnNOlGAKDN0EywZdK0r1m41GPE+Kp5xKfDkCMZkmwO6p51WKLnZU+Y/xwvDUVFMN12lioFz5nQj+CoZnkY/Kl1wibGLOu8rCsTl58taIsOAFwvhqVl8WSesjNem26VgxIQq3bkzgnHDxhwiBlnfEHMIe08dFdOnk0iJCe2Vn2HdCH9unsn9mqKK6Jg3AKNZZjbKC2WkxsS+Ncr6+vSFjlnvNB9BR98gVi+bnDVA/muKjgMDnl2NKJ4ixrwoZ8DUVce6lzBsIS6KR7iPwbMOHt5WeJztZ7b4ng6a/r/9vuVfXHqbE60R0r72dUWKriHCinqFbKmEa50uZjWeyHir3y3BF4ehm67wHaNBzk4mdJesNU3BT396Qd263PG3rY5TSDyCxWURoFFjwy25FPfCmtlJYxR2jXe38HymEsQDn/DzgCh4UrxVq/y0BsTBHanJ5k575dHSkL08FRBB8pcUE6n9OQSlQE3QOLYroBWTK9Qc7cVncndLw8JOgl4cktyitSbuwHQBhDtRgWrpikDYPV9J7cQmd9UltHEc6OePmeq+xo5Mc+9YGBJiKEuvhV7cB5dbMykMFPoc9bkE/suhneI2RKfbfyi+mnWOy+vaZbmkVMJ2KkHBjPtSJIVCObalC+6zOi7x02M/M7MZPHWEXSbQP89oAc0Zyut7a6ukOcXx8j5tnYai8qaz5ALaoimTstSe BHKiysBQ V5/CASY+yF5JAIorhiS5GoP0x7JM9swS4dRWWDH2M4VWvTP/hYS8U5EoBu+LP3g8d6dK8PM85d4NsCro4Dm2iXmkfXSuIODuJOBYg9fv54DD4r2NY3e6OfO8kOYmy2MBlmv0N9bxUc6QbrFHDEtybDz/8yd/sw1otTB0P0SJs/9Pr7yV/uKyNUdV5oNv+0Gufa5JFEZu0Y2gwcjgsH7utFN7nMLxhfNeFCHqxrpgX80lSCRcOUTs1lzoODK0DP912WV0EIR3GyGktZJgfuXGwzY61mi5vHa5sxXx3zZQcaceTq06PFzrV/GuEGuyG/8AMuyXzFG2Dv6MKYScPlwfZFm8LwoPRY7MqXi0nxzxHTU8XIw2weNUlkc+nGU3a+Op0HUpuEY9kEa6kYY9HO/2tK0G1yFsIbhNl5DlC0AWGbNbo9g1wwkXUgs2A8sZkqAzrZVubiOVShiW1rhFf9VHjr9nsYg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.01.24 11:43, Ryan Roberts wrote: > On 29/01/2024 12:46, David Hildenbrand wrote: >> Now that the rmap overhaul[1] is upstream that provides a clean interface >> for rmap batching, let's implement PTE batching during fork when processing >> PTE-mapped THPs. >> >> This series is partially based on Ryan's previous work[2] to implement >> cont-pte support on arm64, but its a complete rewrite based on [1] to >> optimize all architectures independent of any such PTE bits, and to >> use the new rmap batching functions that simplify the code and prepare >> for further rmap accounting changes. >> >> We collect consecutive PTEs that map consecutive pages of the same large >> folio, making sure that the other PTE bits are compatible, and (a) adjust >> the refcount only once per batch, (b) call rmap handling functions only >> once per batch and (c) perform batch PTE setting/updates. >> >> While this series should be beneficial for adding cont-pte support on >> ARM64[2], it's one of the requirements for maintaining a total mapcount[3] >> for large folios with minimal added overhead and further changes[4] that >> build up on top of the total mapcount. >> >> Independent of all that, this series results in a speedup during fork with >> PTE-mapped THP, which is the default with THPs that are smaller than a PMD >> (for example, 16KiB to 1024KiB mTHPs for anonymous memory[5]). >> >> On an Intel Xeon Silver 4210R CPU, fork'ing with 1GiB of PTE-mapped folios >> of the same size (stddev < 1%) results in the following runtimes >> for fork() (shorter is better): >> >> Folio Size | v6.8-rc1 | New | Change >> ------------------------------------------ >> 4KiB | 0.014328 | 0.014035 | - 2% >> 16KiB | 0.014263 | 0.01196 | -16% >> 32KiB | 0.014334 | 0.01094 | -24% >> 64KiB | 0.014046 | 0.010444 | -26% >> 128KiB | 0.014011 | 0.010063 | -28% >> 256KiB | 0.013993 | 0.009938 | -29% >> 512KiB | 0.013983 | 0.00985 | -30% >> 1024KiB | 0.013986 | 0.00982 | -30% >> 2048KiB | 0.014305 | 0.010076 | -30% > > Just a heads up that I'm seeing some strange results on Apple M2. Fork for > order-0 is seemingly costing ~17% more. I'm using GCC 13.2 and was pretty sure I > didn't see this problem with version 1; although that was on a different > baseline and I've thrown the numbers away so will rerun and try to debug this. > So far, on my x86 tests (Intel, AMD EPYC), I was not able to observe this. fork() for order-0 was consistently effectively unchanged. Do you observe that on other ARM systems as well? > | kernel | mean_rel | std_rel | > |:------------|-----------:|----------:| > | mm-unstable | 0.0% | 1.1% | > | patch 1 | -2.3% | 1.3% | > | patch 10 | -2.9% | 2.7% | > | patch 11 | 13.5% | 0.5% | > | patch 12 | 15.2% | 1.2% | > | patch 13 | 18.2% | 0.7% | > | patch 14 | 20.5% | 1.0% | > | patch 15 | 17.1% | 1.6% | > | patch 15 | 16.7% | 0.8% | > > fork for order-9 is looking good (-20%), and for the zap series, munmap is > looking good, but dontneed is looking poor for both order-0 and 9. But one thing > at a time... let's concentrate on fork order-0 first. munmap and dontneed end up calling the exact same call paths. So a big performance difference is rather surprising and might indicate something else. (I think I told you that I was running in some kind of VMA merging problem where one would suddenly get with my benchmark 1 VMA per page. The new benchmark below works around that, but I am not sure if that was fixed in the meantime) VMA merging can of course explain a big difference in fork and munmap vs. dontneed times, especially when comparing different code base where that VMA merging behavior was different. > > Note that I'm still using the "old" benchmark code. Could you resend me the link > to the new code? Although I don't think there should be any effect for order-0 > anyway, if I understood your changes correctly? This is the combined one (small and large PTEs): https://gitlab.com/davidhildenbrand/scratchspace/-/raw/main/pte-mapped-folio-benchmarks.c?inline=false -- Cheers, David / dhildenb