From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_RED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB00C4338F for ; Tue, 3 Aug 2021 05:49:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E2DC560F93 for ; Tue, 3 Aug 2021 05:49:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E2DC560F93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 597EF6B0033; Tue, 3 Aug 2021 01:49:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5486B6B0036; Tue, 3 Aug 2021 01:49:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 437226B005D; Tue, 3 Aug 2021 01:49:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id 272CC6B0033 for ; Tue, 3 Aug 2021 01:49:47 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BB535181AC9B6 for ; Tue, 3 Aug 2021 05:49:46 +0000 (UTC) X-FDA: 78432692772.39.D844024 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf08.hostedemail.com (Postfix) with ESMTP id 312B1300696E for ; Tue, 3 Aug 2021 05:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:References:To:From:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=/VI0OX6tPjo83WWVqMyso0s285F63zqU4KmdLeopRwU=; b=COGaYEF72MXSP2D0X1YkdMlcuk ve9jynmiZNNLkNGM+XGnPwmwomSkKQiiIHVr7Y/Hhb4IBpVsMOpyuRBP7ks8JCcNDAaKkSnSX9Uls Pg8Z0N0Qalz2aZrwljhk5wFYq9tzXn+CWds6bA0JkyF7c6UnSSH1xaqejehTPUEQRBKTiXqgdhnfM roOHaWEIfkYZeN1P32kdHdmtWbUb/uCbCTZUVsEcTGodNKkCyzMs+g3IObtS3tVyAer0d0D6cyQzY 9KgwJYo4p8cQZlnZMAqM+BbAyow6fqrHAFwTO6eOXOidJlAxP7JK0NFs4ZRO2d0F1vnJ1DiVSdvvf UoGWqfoA==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAnJ3-005L8h-0N; Tue, 03 Aug 2021 05:49:37 +0000 Subject: Re: mmotm 2021-08-02-18-51 uploaded (struct user_struct when CONFIG_EPOLL is not set) From: Randy Dunlap To: akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Nicholas Piggin References: <20210803015202.vA3c5O7uP%akpm@linux-foundation.org> Message-ID: Date: Mon, 2 Aug 2021 22:49:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=COGaYEF7; spf=none (imf08.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 312B1300696E X-Stat-Signature: bdfq3y3rd5nsxotfu4z1mifp4tsy33bo X-HE-Tag: 1627969785-306803 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/2/21 10:41 PM, Randy Dunlap wrote: > On 8/2/21 6:52 PM, akpm@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2021-08-02-18-51 has been uploaded to >> >> =C2=A0=C2=A0=C2=A0 https://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >> https://www.ozlabs.org/~akpm/mmotm/ >> >> This is a snapshot of my -mm patch queue.=C2=A0 Uploaded at random hop= efully >> more than once a week. >> >> You will need quilt to apply these patches to the latest Linus release= =20 >> (5.x >> or 5.x-rcY).=C2=A0 The series file is in broken-out.tar.gz and is=20 >> duplicated in >> https://ozlabs.org/~akpm/mmotm/series >> >> The file broken-out.tar.gz contains two datestamp files: .DATE and >> .DATE-yyyy-mm-dd-hh-mm-ss.=C2=A0 Both contain the string yyyy-mm-dd-hh= -mm-ss, >> followed by the base kernel version against which this patch series is= to >> be applied. >> >=20 > I am seeing build errors on i386 or x86_64 when CONFIG_EPOLL is not set= : >=20 > ../kernel/user.c: In function =E2=80=98free_user=E2=80=99: > ../kernel/user.c:141:30: error: =E2=80=98struct user_struct=E2=80=99 ha= s no member named=20 > =E2=80=98epoll_watches=E2=80=99; did you mean =E2=80=98nr_watches=E2=80= =99? > =C2=A0 percpu_counter_destroy(&up->epoll_watches); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~~~ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 nr_watches > In file included from ../include/linux/sched/user.h:7:0, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 from ../kernel/user.c:17: > ../kernel/user.c: In function =E2=80=98alloc_uid=E2=80=99: > ../kernel/user.c:189:33: error: =E2=80=98struct user_struct=E2=80=99 ha= s no member named=20 > =E2=80=98epoll_watches=E2=80=99; did you mean =E2=80=98nr_watches=E2=80= =99? > =C2=A0=C2=A0 if (percpu_counter_init(&new->epoll_watches, 0, GFP_KERNE= L)) { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ > ../include/linux/percpu_counter.h:38:25: note: in definition of macro=20 > =E2=80=98percpu_counter_init=E2=80=99 > =C2=A0=C2=A0 __percpu_counter_init(fbc, value, gfp, &__key);=C2=A0 \ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = ^~~ > ../kernel/user.c:203:33: error: =E2=80=98struct user_struct=E2=80=99 ha= s no member named=20 > =E2=80=98epoll_watches=E2=80=99; did you mean =E2=80=98nr_watches=E2=80= =99? > =C2=A0=C2=A0=C2=A0 percpu_counter_destroy(&new->epoll_watches); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~~~ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 nr_watches > In file included from ../include/linux/sched/user.h:7:0, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 from ../kernel/user.c:17: > ../kernel/user.c: In function =E2=80=98uid_cache_init=E2=80=99: > ../kernel/user.c:225:37: error: =E2=80=98struct user_struct=E2=80=99 ha= s no member named=20 > =E2=80=98epoll_watches=E2=80=99; did you mean =E2=80=98nr_watches=E2=80= =99? > =C2=A0 if (percpu_counter_init(&root_user.epoll_watches, 0, GFP_KERNEL= )) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ > ../include/linux/percpu_counter.h:38:25: note: in definition of macro=20 > =E2=80=98percpu_counter_init=E2=80=99 > =C2=A0=C2=A0 __percpu_counter_init(fbc, value, gfp, &__key);=C2=A0 \ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = ^~~ >=20 >=20 Also do this change in kernel/user.c please: if (percpu_counter_init(&root_user.epoll_watches, 0, GFP_KERNEL)= ) - panic("percpu cpunter alloc failed"); + panic("percpu counter alloc failed"); --=20 ~Randy Reported-by: Randy Dunlap https://people.kernel.org/tglx/notes-about-netiquette